Re: [Zope-dev] Zope2 - Breaking out more packages
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hanno Schlichting wrote: Hi. I've started working some more on my pet project of refactoring Zope2 - specifically to move all C code to external distributions. My working branch is at svn+ssh://svn.zope.org/repos/main/Zope/branches/hannosch-dtml-vs-accesscontrol which also has a TODO.txt with some notes. On the branch DocumenTemplate imports from AccessControl but not the other way around. Yay! So in general I think this can be made to work. My current plan involves: - Move Shared.TaintedString to an external distribution. It's used both by DocumentTemplate and ZPublisher. Moving it into DocumentTemplate and have ZPublisher depend on it, sounds like a poor choice to me - a publisher shouldn't depend on a markup language. We could also move it into AccessControl as it's sort of a security feature. +1 for putting it into AccessControl. - Move zExceptions to an external distribution. It's used from all over, but has no external dependencies on its own. Instead of just moving it out, I'd look at merging some of it into zope.exceptions. The two share a good deal of code like the exception formatter and common exception classes. Sounds fine to me. Maybe the new egg can be mostly BBB shims / impedance matching. - Move the ZMI parts of AccessControl into the App package. App already holds a good deal of general ZMI pages, so this seems a good fit. It basically makes App the zope.app of Zope2. +1 for the generic security tab stuff. I'm not so sure about anything related to the userfolder, though, unless moving it is a huge win. Hmm, you must have wrestled with that already, no? There's a bunch of more minor stuff to work out and lots of awful test dependencies, but in general it looks good. Yay again. If you have any feedback on the above, please shout - otherwise I'll continue as planned and time permits. Once this is finished and merged, ZCTextIndex holds the last bits of C code inside the Zope2 distribution - there's multiple ways to deal with it: break it and HelpSys out or reuse the C code from zope.index. We can look at that later. Before trying the latter, we need to triple check that the zope.index stuff hasn't bitrotted, or lost / missed any features from the Z2 version. BTW, making *all* the products seaparate eggs seems like a good plan to me. Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software Excellence by Designhttp://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkvxlvsACgkQ+gerLs4ltQ7TxACfaBoOZQondYrXT9f7foWZaqAe XksAoME99b8mAoJKWMbKwV1vTWmC7M8C =NOhD -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Zope2 - Breaking out more packages
On Mon, May 17, 2010 at 9:20 PM, Tres Seaver tsea...@palladion.com wrote: Hanno Schlichting wrote: - Move Shared.TaintedString to an external distribution. +1 for putting it into AccessControl. Yeah, makes most sense I guess. It's just one file after all. - Move the ZMI parts of AccessControl into the App package. App already holds a good deal of general ZMI pages, so this seems a good fit. It basically makes App the zope.app of Zope2. +1 for the generic security tab stuff. I'm not so sure about anything related to the userfolder, though, unless moving it is a huge win. Hmm, you must have wrestled with that already, no? The ZMI functionality needs DTMLFile, App.MessageDialog and a couple more of things from App. We could introduce another package that holds the ZMI screens, but that feels like over-abstraction to me. It's not like anyone really would want to use AccessControl's ZMI screens without having App around. I admit App would get to be a bit of a dumping ground :) Before trying the latter, we need to triple check that the zope.index stuff hasn't bitrotted, or lost / missed any features from the Z2 version. Sure. Shane and Chris have done some of that work for the C code already, that's why I'm considering it at all. BTW, making *all* the products seaparate eggs seems like a good plan to me. Generally yes. But they need to be actually independent first. There's a good deal of imports in all directions or usage of Testing and such. We can clean them up one after another and break them out after they are clean. Thanks for the feedback, Hanno ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Zope2 - Breaking out more packages
Hi. I've started working some more on my pet project of refactoring Zope2 - specifically to move all C code to external distributions. My working branch is at svn+ssh://svn.zope.org/repos/main/Zope/branches/hannosch-dtml-vs-accesscontrol which also has a TODO.txt with some notes. On the branch DocumenTemplate imports from AccessControl but not the other way around. So in general I think this can be made to work. My current plan involves: - Move Shared.TaintedString to an external distribution. It's used both by DocumentTemplate and ZPublisher. Moving it into DocumentTemplate and have ZPublisher depend on it, sounds like a poor choice to me - a publisher shouldn't depend on a markup language. We could also move it into AccessControl as it's sort of a security feature. - Move zExceptions to an external distribution. It's used from all over, but has no external dependencies on its own. Instead of just moving it out, I'd look at merging some of it into zope.exceptions. The two share a good deal of code like the exception formatter and common exception classes. - Move the ZMI parts of AccessControl into the App package. App already holds a good deal of general ZMI pages, so this seems a good fit. It basically makes App the zope.app of Zope2. There's a bunch of more minor stuff to work out and lots of awful test dependencies, but in general it looks good. If you have any feedback on the above, please shout - otherwise I'll continue as planned and time permits. Once this is finished and merged, ZCTextIndex holds the last bits of C code inside the Zope2 distribution - there's multiple ways to deal with it: break it and HelpSys out or reuse the C code from zope.index. We can look at that later. Hanno ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
