Re: [Zope-dev] I want some Python 3 C coding style guidance.

2010-11-30 Thread Lennart Regebro
On Thu, Nov 25, 2010 at 11:37, Wichert Akkerman  wrote:
> On 11/25/10 11:31 , Lennart Regebro wrote:
>> Which style do you prefer? I'll make zope.hookable, zope.i18nmessage
>> and zope.proxy use the same style if we can agree on one.
>
> The second. #ifdefs in code make code hard to follow and tend to lead to
> problems. FWIW the Linux kernel tree has a similar policy: they hide all
> differences behind macros and helper functions.

OK, only one voice, but it agrees with me, so I'll go for this. Thanks!

//Lennart
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] I want some Python 3 C coding style guidance.

2010-11-25 Thread Wichert Akkerman
On 11/25/10 11:31 , Lennart Regebro wrote:
> Which style do you prefer? I'll make zope.hookable, zope.i18nmessage
> and zope.proxy use the same style if we can agree on one.

The second. #ifdefs in code make code hard to follow and tend to lead to 
problems. FWIW the Linux kernel tree has a similar policy: they hide all 
differences behind macros and helper functions.

Wichert.
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )