Re: [Zope-dev] Re: buildout-based buildbot back

2008-03-06 Thread Marius Gedminas
On Wed, Mar 05, 2008 at 05:01:53PM -0500, Tres Seaver wrote:
> Marius Gedminas wrote:
> > On Tue, Mar 04, 2008 at 05:03:13PM -0500, Tres Seaver wrote:
> >> I would think that getting 'python setup.py test' to work for each
> >> package-being-tested, which a) makes sure that the package works even
> >> for non-buildout-aware users, and b) fits what everybody else in the
> >> Python eggs word expects.
> > 
> > That would be great.  Do you know how to make setup.py test invoke the
> > zope.testing test runner?  The standard unittest test runner that
> > setuptools uses by default is not sufficient -- it doesn't know anything
> > about test layers.
> 
> Chris McDonough added support for 'setup.py test' to the ZODB trunk:
> 
>   http://svn.zope.org/ZODB/trunk/setup.py?rev=84132&view=markup
> 
> The set of tests which get run seems not to respect the '--all' flag,
> even when I hack the 'alltests()' function to force it into the
> testrunner optoins.

That code finds the right test suites, but then hands it back to
setuptools which runs them using the standard unittest.TextTestRunner.
This won't work with any package that tries to use the zope.testrunner
layer machinery to, e.g., load the zcml for functional tests.

Marius Gedminas
-- 
As easy as 3.14159265358979323846264338327950288419716


signature.asc
Description: Digital signature
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] Re: buildout-based buildbot back

2008-03-05 Thread Chris Withers

Tres Seaver wrote:

I would think that getting 'python setup.py test' to work for each
package-being-tested, which a) makes sure that the package works even
for non-buildout-aware users, and b) fits what everybody else in the
Python eggs word expects.


+1

Chris

--
Simplistix - Content Management, Zope & Python Consulting
   - http://www.simplistix.co.uk

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
http://mail.zope.org/mailman/listinfo/zope-announce

http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] Re: buildout-based buildbot back

2008-03-05 Thread Marius Gedminas
On Tue, Mar 04, 2008 at 05:03:13PM -0500, Tres Seaver wrote:
> Marius Gedminas wrote:
> 
> > Also, I think that lack of a bin/test for any package can be rightly
> > considered to be a bug.
> 
> 'bin/test' doesn't make much sense to me as a way to run the tests
> belonging to the packge-being-tested:  it corresopnds to the tests for
> an entire configured environment.

And that's what you get when you run bin/buildbot in a checkout of any
zope.foo package -- an entire configured environment, sufficient for
testing that package.  IMHO.

> I would think that getting 'python setup.py test' to work for each
> package-being-tested, which a) makes sure that the package works even
> for non-buildout-aware users, and b) fits what everybody else in the
> Python eggs word expects.

That would be great.  Do you know how to make setup.py test invoke the
zope.testing test runner?  The standard unittest test runner that
setuptools uses by default is not sufficient -- it doesn't know anything
about test layers.

Marius Gedminas
-- 
As an aside, UPnP's implementation (which features SOAP, HTTP over
multicast/broadcast UDP, and extremely odd XML) is a must-read for fans of
unnatural and baroque network protocols.
-- Anthony Baxter


signature.asc
Description: Digital signature
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )