Re: [Zope-dev] SVN: zope.index/trunk/ - Port okascore.c optimization used in okapiiindex from Zope2 catalog

2009-06-09 Thread Christian Theune
On Tue, 2009-06-09 at 20:07 -0400, Tres Seaver wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
> 
> Chris McDonough wrote:
> > Log message for revision 100775:
> >   - Port okascore.c optimization used in okapiiindex from Zope2 catalog
> > implementation.  This module is compiled conditionally, based on
> > whether your environment has a working C compiler.
> >   
> >   - Don't use ``len(self._docweight)`` in okapiindex _search_wids method
> > (obtaining the length of a BTree is very expensive at scale).
> > Instead use self.documentCount().  Also a Zope2 port.
> 
> Crap!  this set of performance fixes was added *six years ago* to the
> Zope2 version from which zope.index was forked!
> 
> Hasn't anybody been using this package?

We're using this package. The text index I can only remember in a
not-so-critical piece where performance currently is not an issue. Also,
following checkins even today wouldn't have me remember that this code
is shared.

Christian

-- 
Christian Theune · c...@gocept.com
gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany
http://gocept.com · tel +49 345 1229889 7 · fax +49 345 1229889 1
Zope and Plone consulting and development


signature.asc
Description: This is a digitally signed message part
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] SVN: zope.index/trunk/ - Port okascore.c optimization used in okapiiindex from Zope2 catalog

2009-06-09 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Chris McDonough wrote:
> Log message for revision 100775:
>   - Port okascore.c optimization used in okapiiindex from Zope2 catalog
> implementation.  This module is compiled conditionally, based on
> whether your environment has a working C compiler.
>   
>   - Don't use ``len(self._docweight)`` in okapiindex _search_wids method
> (obtaining the length of a BTree is very expensive at scale).
> Instead use self.documentCount().  Also a Zope2 port.

Crap!  this set of performance fixes was added *six years ago* to the
Zope2 version from which zope.index was forked!

Hasn't anybody been using this package?


Tres.
- --
===
Tres Seaver  +1 540-429-0999  tsea...@palladion.com
Palladion Software   "Excellence by Design"http://palladion.com
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFKLvkv+gerLs4ltQ4RAqC8AKCjJefCXo3eXBiW5cH1uC+70Qz/lQCcD6t2
o0aJ+MhKZBWUT/CKhXKD9+Y=
=gHGc
-END PGP SIGNATURE-

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )