Re: [Zope-dev] TypesTool speedup

2007-03-05 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Alec Mitchell wrote: Looking at the changes rocky made, I don't see why allowing external methods from non-Products should require making the whole process completely dynamic on every call. The old mechanism of storing the product list should be

Re: [Zope-dev] TypesTool speedup

2007-03-04 Thread Andreas Jung
--On 4. März 2007 13:57:23 +0100 Wichert Akkerman [EMAIL PROTECTED] wrote: I'm forwarding a message from limi here, since it makes much more sense here than it does on plone-developers. To summarize it: while analying performance of the Plone 3 codebase they noticed a lot of time was spent

Re: [Zope-dev] TypesTool speedup

2007-03-04 Thread Wichert Akkerman
Previously Andreas Jung wrote: --On 4. März 2007 13:57:23 +0100 Wichert Akkerman [EMAIL PROTECTED] wrote: I'm forwarding a message from limi here, since it makes much more sense here than it does on plone-developers. To summarize it: while analying performance of the Plone 3 codebase they

Re: [Zope-dev] TypesTool speedup

2007-03-04 Thread Wichert Akkerman
Previously Wichert Akkerman wrote: http://paste.plone.org/13217 should do the trick. It makes _product_packages cache its result using the list of products in Control_Panel as a cache key. That makes sure that removing or adding products there will not result in stale data being returned by

Re: [Zope-dev] TypesTool speedup

2007-03-04 Thread Sidnei da Silva
Mutable default values are evil. I would get rid of that. -- Sidnei da Silva Enfold Systemshttp://enfoldsystems.com Fax +1 832 201 8856 Office +1 713 942 2377 Ext 214 ___ Zope-Dev maillist - Zope-Dev@zope.org

Re: [Zope-dev] TypesTool speedup

2007-03-04 Thread Wichert Akkerman
Previously Sidnei da Silva wrote: Mutable default values are evil. I would get rid of that. I modeled that on how get_module_info worked, so at least the pattern is not new in the Zope2 codebase. It could just as easily be done in a global value as well. I'm more interested in seeing if people

Re: [Zope-dev] TypesTool speedup

2007-03-04 Thread Alec Mitchell
Looking at the changes rocky made, I don't see why allowing external methods from non-Products should require making the whole process completely dynamic on every call. The old mechanism of storing the product list should be put back in place, along with the addition of non-Product information