Re: [Zope-dev] zope.index 3.5.2 broken

2009-08-06 Thread Martijn Faassen
Hey, Andreas Jung wrote: [snip] The diff between 3.5.1 and 3.5.2 is pretty long and substantial. I doubt that such a major change us ok as a bugfix release. I should have become a new major release. From what you say, agreed. Regards, Martijn

Re: [Zope-dev] zope.index 3.5.2 broken

2009-08-03 Thread Marius Gedminas
On Sun, Aug 02, 2009 at 08:48:24PM +0200, Andreas Jung wrote: Hi, the doctests for zope.index 3.5.2 - as used in Zope 2.12 - fail badly: File /home/ajung/.buildout/eggs/zope.index-3.5.2-py2.6-linux-x86_64.egg/zope/index/text/tests/../textindex.txt, line 143, in textindex.txt Failed

Re: [Zope-dev] zope.index 3.5.2 broken

2009-08-03 Thread Shane Hathaway
Marius Gedminas wrote: On Sun, Aug 02, 2009 at 08:48:24PM +0200, Andreas Jung wrote: Hi, the doctests for zope.index 3.5.2 - as used in Zope 2.12 - fail badly: File /home/ajung/.buildout/eggs/zope.index-3.5.2-py2.6-linux-x86_64.egg/zope/index/text/tests/../textindex.txt, line 143, in

Re: [Zope-dev] zope.index 3.5.2 broken

2009-08-03 Thread Chris McDonough
On 8/3/09 1:07 PM, Shane Hathaway wrote: Marius Gedminas wrote: On Sun, Aug 02, 2009 at 08:48:24PM +0200, Andreas Jung wrote: Hi, the doctests for zope.index 3.5.2 - as used in Zope 2.12 - fail badly: File

Re: [Zope-dev] zope.index 3.5.2 broken

2009-08-03 Thread Andreas Jung
On 03.08.09 20:15, Chris McDonough wrote: On 8/3/09 1:07 PM, Shane Hathaway wrote: Marius Gedminas wrote: On Sun, Aug 02, 2009 at 08:48:24PM +0200, Andreas Jung wrote: Hi, the doctests for zope.index 3.5.2 - as used in Zope 2.12 - fail badly: File

Re: [Zope-dev] zope.index 3.5.2 broken

2009-08-03 Thread Shane Hathaway
Chris McDonough wrote: On 8/3/09 1:07 PM, Shane Hathaway wrote: How insane were these tests? Well, the author of the tests noticed that the C optimization produces different scores than the Python version, and compensated for that in a way that dramatically reduced readability. /me hangs

Re: [Zope-dev] zope.index 3.5.2 broken

2009-08-03 Thread Chris McDonough
On 8/3/09 2:34 PM, Shane Hathaway wrote: Chris McDonough wrote: On 8/3/09 1:07 PM, Shane Hathaway wrote: How insane were these tests? Well, the author of the tests noticed that the C optimization produces different scores than the Python version, and compensated for that in a way that

Re: [Zope-dev] zope.index 3.5.2 broken

2009-08-03 Thread Wolfgang Schnerring
* Andreas Jung li...@zopyx.com [2009-08-03 20:21]: On 03.08.09 20:15, Chris McDonough wrote: On 8/3/09 1:07 PM, Shane Hathaway wrote: Marius Gedminas wrote: On Sun, Aug 02, 2009 at 08:48:24PM +0200, Andreas Jung wrote: the doctests for zope.index 3.5.2 - as used in Zope 2.12 - fail badly:

Re: [Zope-dev] zope.index 3.5.2 broken

2009-08-02 Thread Andreas Jung
On 02.08.09 20:48, Andreas Jung wrote: Hi, the doctests for zope.index 3.5.2 - as used in Zope 2.12 - fail badly: File /home/ajung/.buildout/eggs/zope.index-3.5.2-py2.6-linux-x86_64.egg/zope/index/text/tests/../textindex.txt, line 143, in textindex.txt Failed example: [(k, %.4f % v)

Re: [Zope-dev] zope.index 3.5.2 broken

2009-08-02 Thread Andreas Jung
On 02.08.09 21:00, Andreas Jung wrote: On 02.08.09 20:48, Andreas Jung wrote: Hi, the doctests for zope.index 3.5.2 - as used in Zope 2.12 - fail badly: File /home/ajung/.buildout/eggs/zope.index-3.5.2-py2.6-linux-x86_64.egg/zope/index/text/tests/../textindex.txt, line 143, in

Re: [Zope-dev] zope.index 3.5.2 broken

2009-08-02 Thread Chris McDonough
On 8/2/09 3:07 PM, Andreas Jung wrote: On 02.08.09 21:00, Andreas Jung wrote: On 02.08.09 20:48, Andreas Jung wrote: Hi, the doctests for zope.index 3.5.2 - as used in Zope 2.12 - fail badly: File

Re: [Zope-dev] zope.index 3.5.2 broken

2009-08-02 Thread Chris McDonough
On 8/2/09 4:41 PM, Chris McDonough wrote: On 8/2/09 3:07 PM, Andreas Jung wrote: On 02.08.09 21:00, Andreas Jung wrote: On 02.08.09 20:48, Andreas Jung wrote: Hi, the doctests for zope.index 3.5.2 - as used in Zope 2.12 - fail badly: File

Re: [Zope-dev] zope.index 3.5.2 broken

2009-08-02 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andreas Jung wrote: Hi, the doctests for zope.index 3.5.2 - as used in Zope 2.12 - fail badly: File /home/ajung/.buildout/eggs/zope.index-3.5.2-py2.6-linux-x86_64.egg/zope/index/text/tests/../textindex.txt, line 143, in textindex.txt Failed

Re: [Zope-dev] zope.index 3.5.2 broken

2009-08-02 Thread Hanno Schlichting
On Sun, Aug 2, 2009 at 10:41 PM, Chris McDonoughchr...@plope.com wrote: That said, why does Zope 2.1.2 use the zope.index textindex?  The Zope 2 implementation is still very superior. The current policy for the test runs is to test both all direct dependencies and all transitive dependencies

Re: [Zope-dev] zope.index 3.5.2 broken

2009-08-02 Thread Chris McDonough
On 8/2/09 5:19 PM, Tres Seaver wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andreas Jung wrote: Hi, the doctests for zope.index 3.5.2 - as used in Zope 2.12 - fail badly: File

Re: [Zope-dev] zope.index 3.5.2 broken

2009-08-02 Thread Chris McDonough
On 8/2/09 5:23 PM, Hanno Schlichting wrote: On Sun, Aug 2, 2009 at 10:41 PM, Chris McDonoughchr...@plope.com wrote: That said, why does Zope 2.1.2 use the zope.index textindex? The Zope 2 implementation is still very superior. The current policy for the test runs is to test both all direct

Re: [Zope-dev] zope.index 3.5.2 broken

2009-08-02 Thread Hanno Schlichting
On Sun, Aug 2, 2009 at 11:35 PM, Chris McDonoughchr...@plope.com wrote: There's no way any release of Zope 2 should depend on zope.index, at least until its index implementations are as good as the ones in Zope 2 itself.  I don't know if in the short term (for a release) that means that the

Re: [Zope-dev] zope.index

2008-12-03 Thread Marius Gedminas
On Tue, Dec 02, 2008 at 10:03:01PM +0100, Wichert Akkerman wrote: Previously Marius Gedminas wrote: On Tue, Dec 02, 2008 at 02:04:39AM +0300, Dan Korostelev wrote: I just removed zope.testing from the zope.index dependency and replaced zope.testing.doctest imports with plain python

Re: [Zope-dev] zope.index

2008-12-02 Thread Dan Korostelev
2008/12/2 Marius Gedminas [EMAIL PROTECTED]: On Tue, Dec 02, 2008 at 02:04:39AM +0300, Dan Korostelev wrote: I just removed zope.testing from the zope.index dependency and replaced zope.testing.doctest imports with plain python doctest and it seems to work with python 2.4 and 2.5 here. Now, it

Re: [Zope-dev] zope.index

2008-12-02 Thread Marius Gedminas
On Tue, Dec 02, 2008 at 02:04:39AM +0300, Dan Korostelev wrote: I just removed zope.testing from the zope.index dependency and replaced zope.testing.doctest imports with plain python doctest and it seems to work with python 2.4 and 2.5 here. Now, it only depends on ZODB3 and zope.interface,

Re: [Zope-dev] zope.index

2008-12-02 Thread Benji York
On Tue, Dec 2, 2008 at 6:48 AM, Dan Korostelev [EMAIL PROTECTED] wrote: 2008/12/2 Marius Gedminas [EMAIL PROTECTED]: On Tue, Dec 02, 2008 at 02:04:39AM +0300, Dan Korostelev wrote: I just removed zope.testing from the zope.index dependency and replaced zope.testing.doctest imports with plain

Re: [Zope-dev] zope.index

2008-12-02 Thread Ross Patterson
Benji York [EMAIL PROTECTED] writes: On Tue, Dec 2, 2008 at 6:48 AM, Dan Korostelev [EMAIL PROTECTED] wrote: 2008/12/2 Marius Gedminas [EMAIL PROTECTED]: On Tue, Dec 02, 2008 at 02:04:39AM +0300, Dan Korostelev wrote: I just removed zope.testing from the zope.index dependency and replaced

Re: [Zope-dev] zope.index

2008-12-02 Thread Wichert Akkerman
Previously Marius Gedminas wrote: On Tue, Dec 02, 2008 at 02:04:39AM +0300, Dan Korostelev wrote: I just removed zope.testing from the zope.index dependency and replaced zope.testing.doctest imports with plain python doctest and it seems to work with python 2.4 and 2.5 here. Now, it only