Re: [Zope-dev] zope.location.pickling.PathPersistent and BBB

2009-09-17 Thread Thomas Lotze
Martijn Faassen wrote:

 Sounds like you did the research.

I've considered all packages mentioned in the current ztk.cfg that come
from the zope.* namespace. The BBB stuff from zope.location.pickling is
neither used by any of them, nor do compat-tests involving the pinned
versions of those packages and the modified zope.location fail.

Come to think about it, I'm not sure whether and how far I should
investigate beyond the ztk for removals like this; are there zope.*
packages in the repository that should no longer be cared about at all?

 I'm +1 on removing it.

Done.

-- 
Thomas



___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope.location.pickling.PathPersistent and BBB

2009-09-16 Thread Thomas Lotze
I asked about this before; let me do so again before assuming silence to
mean consent:

There's a PathPersistent class in zope.location.pickling which is
decorated with a recent BBB comment, and had been questioned by a XXX
comment for some time before that.

The class doesn't seem to be used anywhere in Zope, so removing it would
rid zope.location of some unused code. As PathPersistent is the only user
of the ITraverser interface within zope.location, removing it would also
make it possible to move ITraverser back to zope.traversing where it fits
much better conceptionally.

Does anyone object to these changes?

-- 
Thomas



___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope.location.pickling.PathPersistent and BBB

2009-09-16 Thread Fabio Tranchitella
Hello,

* 2009-09-16 15:34, Thomas Lotze wrote:
 There's a PathPersistent class in zope.location.pickling which is
 decorated with a recent BBB comment, and had been questioned by a XXX
 comment for some time before that.
 
 [snip]
 
 Does anyone object to these changes?

+1, I fully agree with the change.

Fabio
___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope.location.pickling.PathPersistent and BBB

2009-09-16 Thread Martijn Faassen
Thomas Lotze wrote:
 I asked about this before; let me do so again before assuming silence to
 mean consent:
 
 There's a PathPersistent class in zope.location.pickling which is
 decorated with a recent BBB comment, and had been questioned by a XXX
 comment for some time before that.
 
 The class doesn't seem to be used anywhere in Zope, so removing it would
 rid zope.location of some unused code. As PathPersistent is the only user
 of the ITraverser interface within zope.location, removing it would also
 make it possible to move ITraverser back to zope.traversing where it fits
 much better conceptionally.
 
 Does anyone object to these changes?

Sounds like you did the research. I'm +1 on removing it.

Regards,

Martijn

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )