[Zope3-dev] Re: Pagelet and LayoutTemplate recursion

2007-09-27 Thread Christian Zagrodnick
On 2007-09-26 17:30:21 +0200, Stephan Richter 
[EMAIL PROTECTED] said:



On Wednesday 26 September 2007 11:23, Christian Zagrodnick wrote:

Ok. Would this break anything when z3c:template suddenly uses a
different interface?


I don't think so, because this is not used in Python code usually.

Thanks for fixing this!!


I released a z3c.tempalte 1.1a1 to downloads.zope.org and made 
z3c.pagelet trunk depend on it. So that problem should be gone.


Would somebody test it and release it on pypi?

--
Christian Zagrodnick

gocept gmbh  co. kg  ·  forsterstrasse 29 · 06112 halle/saale
www.gocept.com · fon. +49 345 12298894 · fax. +49 345 12298891



___
Zope3-dev mailing list
Zope3-dev@zope.org
Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com



[Zope3-dev] Re: Pagelet and LayoutTemplate recursion

2007-09-26 Thread Christian Zagrodnick
On 2007-09-26 17:01:45 +0200, Stephan Richter 
[EMAIL PROTECTED] said:



On Wednesday 26 September 2007 10:19, Christian Zagrodnick wrote:

there is a recursion problem with Pagelets and layout templates when
you don't register a template for the pagelet.


Yep, nasty, isn't it?


The problem is, that ILayoutTemplate is derived from IPageTemplate.
This is why the pagelet tries to render its contents with the layout
template.

I'm not sure what to do about this.


Roger and I discussed this issue over the weekend and just have not had the
time to work it out.


a) Explicitly check that the template is *not* an ILayoutTemplate in
BrowserPagelet.render


Good solution. :-)


b) make z3c:template use another interface which is also derived from
IPageTemplate and use the new interface in BrowserPagelet.render.


Also a good solution. :-)

I think both approaches are fine. Roger and I had decided on (b) when we
discussed it.


Ok. Would this break anything when z3c:template suddenly uses a 
different interface?



--
Christian Zagrodnick

gocept gmbh  co. kg  ·  forsterstrasse 29 · 06112 halle/saale
www.gocept.com · fon. +49 345 12298894 · fax. +49 345 12298891



___
Zope3-dev mailing list
Zope3-dev@zope.org
Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com



Re: [Zope3-dev] Re: Pagelet and LayoutTemplate recursion

2007-09-26 Thread Stephan Richter
On Wednesday 26 September 2007 11:23, Christian Zagrodnick wrote:
 Ok. Would this break anything when z3c:template suddenly uses a
 different interface?

I don't think so, because this is not used in Python code usually.

Thanks for fixing this!!

Regards,
Stephan
-- 
Stephan Richter
CBU Physics  Chemistry (B.S.) / Tufts Physics (Ph.D. student)
Web2k - Web Software Design, Development and Training
___
Zope3-dev mailing list
Zope3-dev@zope.org
Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com