Re: [Zope3-dev] Re: The bug fixing problem

2006-07-11 Thread Martijn Faassen
Jim Fulton wrote: [snip] I would say that there are two bugs in the case you are describing: the one you meant to fix and the one which is the lack of any tests for the module / class / whatever. I would bet that spending your thirty minutes adding minimal tests to such a module is a *higher*

Re: [Zope3-dev] Re: The bug fixing problem

2006-07-08 Thread Marius Gedminas
On Fri, Jul 07, 2006 at 08:48:39PM +0200, [EMAIL PROTECTED] wrote: In many cases, I can convince myself that a fix does actually work without performing a test -- at least in the sense that it removes one bug. In many cases I have made completely trivial bug fixes that I was absolutely

Re: [Zope3-dev] Re: The bug fixing problem

2006-07-07 Thread Jim Fulton
On Jul 6, 2006, at 12:29 PM, Philipp von Weitershausen wrote: [EMAIL PROTECTED] wrote: Christian Theune wrote at 2006-7-5 11:46 +0200: ... Another thing are the rules about unit tests. Some bugs touch areas that are poorly tested. When I fix a bug over there, do I have to work harder to

Re: [Zope3-dev] Re: The bug fixing problem

2006-07-07 Thread Jim Fulton
On Jul 6, 2006, at 2:03 PM, Lennart Regebro wrote: On 7/6/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: When I have introduced secondary bugs in my fixes (which occasionally happened), then a unit test would not have helped. The reason was then that the affected code was used in

Re: [Zope3-dev] Re: The bug fixing problem

2006-07-07 Thread Jim Fulton
On Jul 6, 2006, at 10:11 PM, Tres Seaver wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Christian Theune wrote: Hi, Marius Gedminas wrote: I do not think that the requirements to 4. Write unit tests 5. Merge bugfixes from trunk to the release branch 6. Wait for the incredibly slow

Re: [Zope3-dev] Re: The bug fixing problem

2006-07-07 Thread Christian Theune
Hi, Jim Fulton wrote: On Jul 6, 2006, at 12:29 PM, Philipp von Weitershausen wrote: [EMAIL PROTECTED] wrote: Christian Theune wrote at 2006-7-5 11:46 +0200: ... Another thing are the rules about unit tests. Some bugs touch areas that are poorly tested. When I fix a bug over there, do I

Re: [Zope3-dev] Re: The bug fixing problem

2006-07-07 Thread Jim Fulton
On Jul 7, 2006, at 7:52 AM, Christian Theune wrote: Hi, Jim Fulton wrote: On Jul 6, 2006, at 12:29 PM, Philipp von Weitershausen wrote: [EMAIL PROTECTED] wrote: Christian Theune wrote at 2006-7-5 11:46 +0200: ... Another thing are the rules about unit tests. Some bugs touch areas that

Re: [Zope3-dev] Re: The bug fixing problem

2006-07-06 Thread Lennart Regebro
On 7/6/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: When I have introduced secondary bugs in my fixes (which occasionally happened), then a unit test would not have helped. The reason was then that the affected code was used in unanticipated ways -- and because it was unanticipated, I would

Re: [Zope3-dev] Re: The bug fixing problem

2006-07-06 Thread dieter
Lennart Regebro wrote at 2006-7-6 20:03 +0200: On 7/6/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: When I have introduced secondary bugs in my fixes (which occasionally happened), then a unit test would not have helped. The reason was then that the affected code was used in unanticipated ways