Re: [Zope3-dev] Proposal based development!: was Re: Event fixes

[Jim Fulton]

Roger Ineichen wrote:
...

I'm not happy with this changes too. But I hope I can live
with that.

But I'm really not happy how this code get into the core.
We defined a proposal based process for announce such changes.


This was a pretty minor change, one that most of the people who
responded agreed with.

It's really bad if such changes break our unit tests and 
existing applications. Especially if this happens because 
of new events where are really ugly to trace down.


Did applications break? I wasn't aware of that.

It isn't uncommon for bug fixes to cause tests to break,
especially when tests were asserting incorrect behavior.



Please propose such important changes in the future.


He did.  It could be argued that he should have waited a
bit longer for feedback.

Jim

--
Jim Fulton   mailto:[EMAIL PROTECTED]   Python Powered!
CTO  (540) 361-1714http://www.python.org
Zope Corporation http://www.zope.com   http://www.zope.org
___
Zope3-dev mailing list
Zope3-dev@zope.org
Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com

[Zope3-dev] Proposal based development!: was Re: Event fixes

[Roger Ineichen]

Hi

 If you don't feel that containment boundaries are a 
 sufficiently fundamental concept, then we have a strong 
 disagreement. I stand by what I checked in.

[...]

 Florent

I'm not happy with this changes too. But I hope I can live
with that.

But I'm really not happy how this code get into the core.
We defined a proposal based process for announce such changes.

It's really bad if such changes break our unit tests and 
existing applications. Especially if this happens because 
of new events where are really ugly to trace down.

Please propose such important changes in the future.

Regards
Roger Ineichen

___
Zope3-dev mailing list
Zope3-dev@zope.org
Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com