Re: [Zope3-dev] RC 3 for Zope 3.1 needed
Fred Drake wrote:
> On 9/6/05, Stuart Bishop <[EMAIL PROTECTED]> wrote:
>
>>Is this something I need to be aware of? Because I'm not ;)
>
>
> This test in the Zope 3 trunk is failing:
>
> def testParseTimeZoneNames(self):
> dt = self.format.parse('01.01.2003 09:48 EST', 'dd.MM. HH:mm zzz')
> self.assertEqual(dt.tzinfo.utcoffset(dt),
> datetime.timedelta(hours=-6))
> self.assertEqual(dt.tzinfo.zone, 'EST')
> # I think this is wrong due to a bug in pytz
> self.assertEqual(dt.tzinfo.tzname(dt), 'CST')
>
> dt = self.format.parse('01.01.2003 09:48 US/Eastern',
>'dd.MM. HH:mm ')
> self.assertEqual(dt.tzinfo.utcoffset(dt),
> datetime.timedelta(hours=-5))
> self.assertEqual(dt.tzinfo.zone, 'US/Eastern')
> # I think this is wrong due to a bug in pytz
> self.assertEqual(dt.tzinfo.tzname(dt), 'EST')
>
> This is from src/zope/i18n/tests/test_formats.py, line 304. This
> failed both before and after your latest update (sometime in the last
> few hours).
I talked to Gary about this. I've fixed the i18n code and tests, and am just
adding another test (prove historical timezone handling) before committing.
--
Stuart Bishop <[EMAIL PROTECTED]>
http://www.stuartbishop.net/
signature.asc
Description: OpenPGP digital signature
___
Zope3-dev mailing list
Zope3-dev@zope.org
Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] RC 3 for Zope 3.1 needed
On 9/6/05, Gary Poster <[EMAIL PROTECTED]> wrote: > I talked with Stuart on IRC. It appears to be a symptom of using > pytz incorrectly in i18n (it needs to localize, as per the pytz > README). He said he would look into the i18n package and try to > address. Excellent! Thanks for the update. -Fred -- Fred L. Drake, Jr. Zope Corporation ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] RC 3 for Zope 3.1 needed
On Sep 6, 2005, at 10:27 PM, Fred Drake wrote: On 9/6/05, Stuart Bishop <[EMAIL PROTECTED]> wrote: Is this something I need to be aware of? Because I'm not ;) This test in the Zope 3 trunk is failing: I talked with Stuart on IRC. It appears to be a symptom of using pytz incorrectly in i18n (it needs to localize, as per the pytz README). He said he would look into the i18n package and try to address. Gary ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] RC 3 for Zope 3.1 needed
On 9/6/05, Stuart Bishop <[EMAIL PROTECTED]> wrote:
> Is this something I need to be aware of? Because I'm not ;)
This test in the Zope 3 trunk is failing:
def testParseTimeZoneNames(self):
dt = self.format.parse('01.01.2003 09:48 EST', 'dd.MM. HH:mm zzz')
self.assertEqual(dt.tzinfo.utcoffset(dt), datetime.timedelta(hours=-6))
self.assertEqual(dt.tzinfo.zone, 'EST')
# I think this is wrong due to a bug in pytz
self.assertEqual(dt.tzinfo.tzname(dt), 'CST')
dt = self.format.parse('01.01.2003 09:48 US/Eastern',
'dd.MM. HH:mm ')
self.assertEqual(dt.tzinfo.utcoffset(dt), datetime.timedelta(hours=-5))
self.assertEqual(dt.tzinfo.zone, 'US/Eastern')
# I think this is wrong due to a bug in pytz
self.assertEqual(dt.tzinfo.tzname(dt), 'EST')
This is from src/zope/i18n/tests/test_formats.py, line 304. This
failed both before and after your latest update (sometime in the last
few hours).
-Fred
--
Fred L. Drake, Jr.
Zope Corporation
___
Zope3-dev mailing list
Zope3-dev@zope.org
Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] RC 3 for Zope 3.1 needed
Gary Poster wrote: > > On Sep 6, 2005, at 4:29 PM, Stephan Richter wrote: > >> Hi everyone, >> >> I just learned that we need to have a Zope 3.1 RC 3 release. I know >> that some >> people found bugs, so please check in fixes into the branch in the next >> couple of days. >> >> Gary, does the pytz problem affect the branch? > > Yes. The combination of pytz and i18n appears to have already been > broken. The i18n tests seem to have been fudged to pass. Is this something I need to be aware of? Because I'm not ;) -- Stuart Bishop <[EMAIL PROTECTED]> http://www.stuartbishop.net/ signature.asc Description: OpenPGP digital signature ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] RC 3 for Zope 3.1 needed
On Sep 6, 2005, at 4:29 PM, Stephan Richter wrote: Hi everyone, I just learned that we need to have a Zope 3.1 RC 3 release. I know that some people found bugs, so please check in fixes into the branch in the next couple of days. Gary, does the pytz problem affect the branch? Yes. The combination of pytz and i18n appears to have already been broken. The i18n tests seem to have been fudged to pass. Gary ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] RC 3 for Zope 3.1 needed
[Stephan Richter] > I just learned that we need to have a Zope 3.1 RC 3 release. I know that some > people found bugs, so please check in fixes into the branch in the next > couple of days. > > Gary, does the pytz problem affect the branch? I ran all the tests on the 3.1 branch today after stitching ZODB 3.5.1b1 into it. They all passed (Windows). I bumped into the trunk test failure after doing a similar thing to Zope3 trunk (stitching ZODB 3.6.0a2 into it). OTOH, the "passing" version of this test on 3.1 branch verifies that a time zone named "EST" gets name "CST", and gets an offset appropriate for CST. IOW, when this test passes, it's guaranteeing that that the EST time zone doesn't work correctly in any respect ;-) ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
[Zope3-dev] RC 3 for Zope 3.1 needed
Hi everyone, I just learned that we need to have a Zope 3.1 RC 3 release. I know that some people found bugs, so please check in fixes into the branch in the next couple of days. Gary, does the pytz problem affect the branch? Regards, Stephan -- Stephan Richter CBU Physics & Chemistry (B.S.) / Tufts Physics (Ph.D. student) Web2k - Web Software Design, Development and Training ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
