Re: [Zope3-dev] zc.selenium test isolation

2007-01-10 Thread Christian Theune
Am Mittwoch, den 10.01.2007, 11:04 -0500 schrieb Benji York:
> Christian Theune wrote:
> > I propose to add an "ultimate" pop at the beginning of each test, to
> > ensure consistency/isolation at those points.
> 
> Where "ultimate pop" means to remove all stacked demostorages added by 
> previous tests?  If so, sounds good.
> 
> I do worry a little about that hiding mismatched push/pop operations in 
> non-failing tests.  Perhaps the "ultimate pop" could generate a selenium 
> error if there was anything there to pop.

I think that would defeat the purpose of having the other tests pass and
not get spurious errors.

I think under normal conditions, the mismatched operations shouldn't be
a problem, anyway, normal users of zc.selenium shouldn't have to worry
about it. All of those operations are generated automatically anyway.

Christian

-- 
gocept gmbh & co. kg - forsterstraße 29 - 06112 halle/saale - germany
www.gocept.com - [EMAIL PROTECTED] - phone +49 345 122 9889 7 -
fax +49 345 122 9889 1 - zope and plone consulting and development


signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
___
Zope3-dev mailing list
Zope3-dev@zope.org
Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com



Re: [Zope3-dev] zc.selenium test isolation

2007-01-10 Thread Benji York

Christian Theune wrote:

I propose to add an "ultimate" pop at the beginning of each test, to
ensure consistency/isolation at those points.


Where "ultimate pop" means to remove all stacked demostorages added by 
previous tests?  If so, sounds good.


I do worry a little about that hiding mismatched push/pop operations in 
non-failing tests.  Perhaps the "ultimate pop" could generate a selenium 
error if there was anything there to pop.

--
Benji York
Senior Software Engineer
Zope Corporation
___
Zope3-dev mailing list
Zope3-dev@zope.org
Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com



Re: [Zope3-dev] zc.selenium test isolation

2007-01-10 Thread Jim Fulton

Christian Theune wrote:

Hi,

I'd like to propose a change to zc.selenium to increase test isolation
in the face of failing tests.

We use demostorage elegantly by keeping a stack of wrapped storages that
are pushed and popped automatically while the selenium tests run.

However, when a test fails, selenium might skip a few pop operations and
following tests might fail spuriously.

I propose to add an "ultimate" pop at the beginning of each test, to
ensure consistency/isolation at those points.


+1

Jim

--
Jim Fulton   mailto:[EMAIL PROTECTED]   Python Powered!
CTO  (540) 361-1714http://www.python.org
Zope Corporation http://www.zope.com   http://www.zope.org
___
Zope3-dev mailing list
Zope3-dev@zope.org
Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com



[Zope3-dev] zc.selenium test isolation

2007-01-10 Thread Christian Theune
Hi,

I'd like to propose a change to zc.selenium to increase test isolation
in the face of failing tests.

We use demostorage elegantly by keeping a stack of wrapped storages that
are pushed and popped automatically while the selenium tests run.

However, when a test fails, selenium might skip a few pop operations and
following tests might fail spuriously.

I propose to add an "ultimate" pop at the beginning of each test, to
ensure consistency/isolation at those points.

Christian

-- 
gocept gmbh & co. kg - forsterstraße 29 - 06112 halle/saale - germany
www.gocept.com - [EMAIL PROTECTED] - phone +49 345 122 9889 7 -
fax +49 345 122 9889 1 - zope and plone consulting and development


signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
___
Zope3-dev mailing list
Zope3-dev@zope.org
Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com