Review: Needs Fixing
Looks good! Here are some comments:
- Did you check that the invalid option type error does not exist already? Will
it be consistent also in all other modules?
- Should JSONiq modules not be suffixed as .jq (but it's only cosmetics of
course).
- empty-sequence() - ()
-
Paul J. Lucas has proposed merging lp:~zorba-coders/zorba/bug-1188035-csv into
lp:zorba/csv-module.
Commit message:
Updated module URI.
Requested reviews:
Paul J. Lucas (paul-lucas)
Related bugs:
Bug #1188035 in Zorba: Update non-core module csv
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655
Your team Zorba Coders is subscribed to branch lp:zorba/csv-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655
Your team
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655 :
Votes: {'Approve': 1}
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655
Your team Zorba Coders is subscribed to branch
The proposal to merge lp:~zorba-coders/zorba/bug-1188035-csv into
lp:zorba/csv-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655
--
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655
Stage CommitZorba failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/144/console to
view the results.
--
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1189804/+merge/181973
https://code.launchpad.net/~zorba-coders/zorba/html-module-bug-1189804/+merge/182529
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
Looks good! Here are some comments:
- Did you check that the invalid option type error does not exist already?
Will it be consistent also in all other modules?
Yes, I did. This will become consistent as soon as the JSound implementation is
there.
- Should JSONiq modules not be suffixed as
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1189804/+merge/181973 :
Votes: {'Pending': 1, 'Needs Fixing': 1, 'Needs commit message': 1}
https://code.launchpad.net/~zorba-coders/zorba/html-module-bug-1189804/+merge/182529
:
Votes:
Review: Needs Fixing
- use p/P tags between paragraphs
- use pre for blocks of code (e.g. for $options in csv:parse#2)
- the namespace of the nodes that are created by the parse function is still
http://www.zorba-xquery...; (e.g. test7:row
xmlns:test7=http://www.zorba-xquery/modules/csv;)
--
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/bug-1189804/+merge/181973
Stage CommitZorba failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/145/console to
view the results.
--
- use p/P tags between paragraphs
- use pre for blocks of code (e.g. for $options in csv:parse#2)
- the namespace of the nodes that are created by the parse function is still
http://www.zorba-xquery...; (e.g. test7:row xmlns:test7=http://www.zorba-
xquery/modules/csv)
Done.
--
The proposal to merge lp:~zorba-coders/zorba/jdbc_module-bug-1188050 into
lp:zorba/jdbc-module has been updated.
Commit Message changed to:
renamed module and improved documentation
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/jdbc_module-bug-1188050/+merge/182757
--
Matthias Brantner has proposed merging
lp:~zorba-coders/zorba/jdbc_module-bug-1188050 into lp:zorba/jdbc-module.
Commit message:
renamed module and improved documentation
Requested reviews:
Matthias Brantner (matthias-brantner)
Related bugs:
Bug #1188050 in Zorba: Update non-core module
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/jdbc_module-bug-1188050/+merge/182757
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/jdbc_module-bug-1188050/+merge/182757
:
Votes: {'Pending': 1}
--
https://code.launchpad.net/~zorba-coders/zorba/jdbc_module-bug-1188050/+merge/182757
Your team Zorba Coders is subscribed to
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/jdbc_module-bug-1188050/+merge/182757
Stage CommitZorba failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/146/console to
view the results.
--
Matthias Brantner has proposed merging
lp:~zorba-coders/zorba/couchbase_module-bug-1188063 into
lp:zorba/couchbase-module.
Commit message:
renamed to zorba.io and adapted documentation
Requested reviews:
Matthias Brantner (matthias-brantner)
For more details, see:
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/couchbase_module-bug-1188063/+merge/182781
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/couchbase_module-bug-1188063/+merge/182781
Your team Zorba Coders is subscribed to branch lp:zorba/couchbase-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/couchbase_module-bug-1188063/+merge/182781
Stage TestZorbaUbuntu failed.
20 tests failed (8409 total tests run).
Check test results at
http://jenkins.lambda.nu/job/TestZorbaUbuntu/253/testReport/ to view the
results.
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655
Your team Zorba Coders is subscribed to branch lp:zorba/csv-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/csv2 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/csv2/+merge/182786
--
https://code.launchpad.net/~zorba-coders/zorba/csv2/+merge/182786
Your team Zorba
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/csv2/+merge/182786
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655
Your team
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655
Stage TestZorbaUbuntu failed.
2 tests failed (8409 total tests run).
Check test results at
http://jenkins.lambda.nu/job/TestZorbaUbuntu/254/testReport/ to view the
results.
--
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1188056 into
lp:zorba/security-module.
Requested reviews:
Zorba Coders (zorba-coders)
Related bugs:
Bug #1188056 in Zorba: Update non-core module security
https://bugs.launchpad.net/zorba/+bug/1188056
For more details, see:
Review: Needs Fixing
1. sha256 test failures.
2. There are error codes thrown like hmac:unsupported-algorithm; they should be
like hmac:UNSUPPORTED_ALGORITHM, and the XQDoc should be updated accordingly.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188056/+merge/182790
Your team
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655
Your team
Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655
Your team Zorba Coders is subscribed to branch lp:zorba/csv-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
The proposal to merge lp:~zorba-coders/zorba/bug-1188035-csv into
lp:zorba/csv-module has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/csv2/+merge/182786
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/csv2/+merge/182786
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/csv2/+merge/182786
Your team Zorba Coders is
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/csv2/+merge/182786
Stage TestZorbaUbuntu failed.
7 tests failed (8452 total tests run).
Check test results at
http://jenkins.lambda.nu/job/TestZorbaUbuntu/256/testReport/ to view the
results.
--
35 matches
Mail list logo
