Matthias, I did not look at those tests to see how important they are. But,
if they do test something important, rather than changing the expected result,
I think you should modify the tests to use an ordered collection, and add one
or two new tests for the error condition.
--
According to Launchpad, the change I suggested has not been made - why the new
Merge Proposal?
(Also confused by Launchpad's saying that the Approved Revision is no longer
in the source branch...)
Strange, I can see the following changes in the diff:
=== removed file
Review: Approve
Ah, I see the deleted files now. So, I'll approve the diff. However, I'm not
sure the remote queue will pick it up with the no longer in the source branch
message for Approved Revision. You may need to re-Approve the Merge Proposal.
--
The proposal to merge lp:~matthias-brantner/zorba/bug-863730 into lp:zorba has
been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~matthias-brantner/zorba/bug-863730/+merge/77784
--
The proposal to merge lp:~matthias-brantner/zorba/bug-863730 into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~matthias-brantner/zorba/bug-863730/+merge/77784
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-863730-2011-10-03T20-24-36.523Z/log.html
--
https://code.launchpad.net/~matthias-brantner/zorba/bug-863730/+merge/77784
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
Validation queue job bug-863730-2011-10-03T20-24-36.523Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~matthias-brantner/zorba/bug-863730/+merge/77784
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~matthias-brantner/zorba/bug-863730 into lp:zorba has
been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~matthias-brantner/zorba/bug-863730/+merge/77784
--
According to Launchpad, the change I suggested has not been made - why the new
Merge Proposal?
(Also confused by Launchpad's saying that the Approved Revision is no longer
in the source branch...)
--
https://code.launchpad.net/~matthias-brantner/zorba/bug-863730/+merge/77784
Your team Zorba
Matthias Brantner has proposed merging lp:~matthias-brantner/zorba/bug-863730
into lp:zorba.
Requested reviews:
Zorba Coders (zorba-coders)
For more details, see:
https://code.launchpad.net/~matthias-brantner/zorba/bug-863730/+merge/77769
Fix for bug #863730 (static delete-node* functions
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-863730-2011-09-30T23-47-05.623Z/log.html
--
https://code.launchpad.net/~matthias-brantner/zorba/bug-863730/+merge/77769
Your team Zorba Coders is requested to review the proposed merge of
The attempt to merge lp:~matthias-brantner/zorba/bug-863730 into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:231
(message):
Validation queue job bug-863730-2011-09-30T23-47-05.623Z is finished. The
The proposal to merge lp:~matthias-brantner/zorba/bug-863730 into lp:zorba has
been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~matthias-brantner/zorba/bug-863730/+merge/77769
--
Matthias Brantner has proposed merging lp:~matthias-brantner/zorba/bug-863730
into lp:zorba.
Requested reviews:
Zorba Coders (zorba-coders)
Related bugs:
Bug #863730 in Zorba: static delete-node* functions don't raise ZDDY0012
https://bugs.launchpad.net/zorba/+bug/863730
For more details,
The proposal to merge lp:~matthias-brantner/zorba/bug-863730 into lp:zorba has
been updated.
Commit Message changed to:
Fix for bug #863730 (static delete-node* functions don't raise ZDDY0012).
For more details, see:
https://code.launchpad.net/~matthias-brantner/zorba/bug-863730/+merge/2
The proposal to merge lp:~matthias-brantner/zorba/bug-863730 into lp:zorba has
been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~matthias-brantner/zorba/bug-863730/+merge/2
--
Matthias Brantner has proposed merging lp:~matthias-brantner/zorba/bug-863730
into lp:zorba.
Requested reviews:
Chris Hillery (ceejatec)
Related bugs:
Bug #863730 in Zorba: static delete-node* functions don't raise ZDDY0012
https://bugs.launchpad.net/zorba/+bug/863730
For more details,
The proposal to merge lp:~matthias-brantner/zorba/bug-863730 into lp:zorba has
been updated.
Commit Message changed to:
Fix for bug #863730 (static delete-node* functions don't raise ZDDY0012).
For more details, see:
https://code.launchpad.net/~matthias-brantner/zorba/bug-863730/+merge/77784
The proposal to merge lp:~matthias-brantner/zorba/bug-863730 into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~matthias-brantner/zorba/bug-863730/+merge/77784
--
19 matches
Mail list logo
