Review: Approve
I'm not sure why Launchpad is showing hundreds of changes on this branch;
something odd when merging from the trunk, I assume. But the diff looks good,
so if it merges OK, I'm happy.
--
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256
Your team Zorba Coders
I'm not sure why Launchpad is showing hundreds of changes on this branch;
something odd when merging from the trunk, I assume. But the diff looks good,
so if it merges OK, I'm happy.
Since most of the changes are in bin folder, that has not been changed in a
while now, just to be 100% sure
Review: Needs Information
What happened to Fixed bug #866958 (Parsing error not explicit enough) in the
ChangeLog?
--
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
That bug was never part of this proposal. I think it's showing up in the did
here due to my merge from the trunk. The Changelog had a number of things get
rearranged which made conflict resolution hard. That bug is in fact fixed so I
assume it should be in the Changelog.
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/1025564-2013-04-30T22-40-03.37Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The attempt to merge lp:~zorba-coders/zorba/1025564 into lp:zorba failed. Below
is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job 1025564-2013-04-30T22-40-03.37Z is finished. The
final status
The proposal to merge lp:~zorba-coders/zorba/1025564 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256
--
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256
Your team
There are additional revisions which have not been approved in review. Please
seek review and approval of these new revisions.
--
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/1025564 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256
--
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256
Your team
The proposal to merge lp:~zorba-coders/zorba/1025564 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256
--
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256
Your team
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/1025564-2013-05-01T03-32-07.037Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job 1025564-2013-05-01T03-32-07.037Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
The proposal to merge lp:~zorba-coders/zorba/1025564 into lp:zorba has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256
--
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256
Your team Zorba
Comments fixed, please re-review.
--
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
Also, add a mention to the option changes to the ChangeLog.
--
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
The proposal to merge lp:~zorba-coders/zorba/1025564 into lp:zorba has been
updated.
Status: Merged = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/120024
--
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/120024
Your team
Review: Needs Fixing
Works great. Some minor issues:
- the --help documentation should mention that the argument is deprecated
- also, the --help documentation should mention the syntax to pass the file
- please respect coding guidelines. For example,
if(qBeforeF()){ = if (qBeforeF())
{
- remove
Agree about the --help doc; if I get a little time later I might put in a
suggested change myself.
Also agree about not leaving commented-out code.
To be fair to Luis, the coding guidelines do not mention anything about brace
positioning or spaces after if, etc.
--
The proposal to merge lp:~zorba-coders/zorba/1025564 into lp:zorba has been
updated.
Commit Message changed to:
Added changes for deprecating -f option.
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256
--
https://code.launchpad.net/~zorba-coders
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/1025564
into lp:zorba.
Requested reviews:
Chris Hillery (ceejatec)
Related bugs:
Bug #1025564 in Zorba: Deprecate -f argument to zorbacmd
https://bugs.launchpad.net/zorba/+bug/1025564
For more details, see:
21 matches
Mail list logo
