Review: Approve
The previous version of the soundex-key function had indeed a problem with the
string 3-D Adventure, returning a stack overflow since it as recursively
trying to produce a soundex key with just 4 characters. The new implementation
fixes this, and also seems to be correct.
The proposal to merge lp:~zorba-coders/zorba/fix-soundex_key into
lp:zorba/data-cleaning-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-soundex_key/+merge/164561
--
https://code.launchpad.net/~zorba-coders
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/fix-soundex_key-2013-05-21T14-25-30.124Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/fix-soundex_key/+merge/164561
Your team Zorba Coders is subscribed to branch
Validation queue job fix-soundex_key-2013-05-21T14-25-30.124Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/fix-soundex_key/+merge/164561
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/fix-soundex_key into
lp:zorba/data-cleaning-module has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-soundex_key/+merge/164561
--
https://code.launchpad.net/~zorba-coders/zorba
Matthias Brantner has proposed merging lp:~zorba-coders/zorba/fix-soundex_key
into lp:zorba/data-cleaning-module.
Commit message:
fix and tests for soundex-key function
Requested reviews:
Matthias Brantner (matthias-brantner)
For more details, see:
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fix-soundex_key/+merge/164561
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/fix-soundex_key into
lp:zorba/data-cleaning-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-soundex_key/+merge/164561
--
https://code.launchpad.net/~zorba-coders
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/fix-soundex_key-2013-05-18T00-44-28.084Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/fix-soundex_key/+merge/164561
Your team Zorba Coders is subscribed to branch
Validation queue job fix-soundex_key-2013-05-18T00-44-28.084Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/fix-soundex_key/+merge/164561
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1, Needs Information 1, Resubmit 1. Got: 1
Approve.
--
https://code.launchpad.net/~zorba-coders/zorba/fix-soundex_key/+merge/164561
Your team Zorba Coders is subscribed to branch
The proposal to merge lp:~zorba-coders/zorba/fix-soundex_key into
lp:zorba/data-cleaning-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-soundex_key/+merge/164561
--
https://code.launchpad.net/~zorba-coders
12 matches
Mail list logo
