Matthias, I did not look at those tests to see how important they are. But,
if they do test something important, rather than changing the expected result,
I think you should modify the tests to use an ordered collection, and add one
or two new tests for the error condition.
--
According to Launchpad, the change I suggested has not been made - why the new
Merge Proposal?
(Also confused by Launchpad's saying that the Approved Revision is no longer
in the source branch...)
Strange, I can see the following changes in the diff:
=== removed file
Review: Approve
Ah, I see the deleted files now. So, I'll approve the diff. However, I'm not
sure the remote queue will pick it up with the no longer in the source branch
message for Approved Revision. You may need to re-Approve the Merge Proposal.
--
According to Launchpad, the change I suggested has not been made - why the new
Merge Proposal?
(Also confused by Launchpad's saying that the Approved Revision is no longer
in the source branch...)
--
https://code.launchpad.net/~matthias-brantner/zorba/bug-863730/+merge/77784
Your team Zorba
The attempt to merge lp:~matthias-brantner/zorba/bug-863730 into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:231
(message):
Validation queue job bug-863730-2011-09-30T23-47-05.623Z is finished. The
5 matches
Mail list logo
