Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/parse-fragment into lp:zorba
Review: Approve -- https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/94419 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/compile_queryplan into lp:zorba
William Candillon has proposed merging lp:~zorba-coders/zorba/compile_queryplan
into lp:zorba.
Requested reviews:
William Candillon (wcandillon)
Matthias Brantner (matthias-brantner)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733
Remove conflicting shortcut -e for --execute-plan option.
--
https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'bin/zorbacmdproperties.txt'
--- bin/zorbacmdproperties.txt 2012-02-20 10:10:44 +
+++ bin/zorbacmdproperties.txt 2012-02-27 09:10:24 +
@@ -36,4 +36,4 @@
(stop-words, po::valuestd::vectorstd::string (), Mapping specifying a stop-words URI to another.)
(thesaurus, po::valuestd::vectorstd::string (), Mapping specifying a thesaurus URI to another.)
(compile-plan,c, Output the query plan as binary.)
-(execute-plan,e, Take a query plan as binary and execute it. Binary query plans can be generated using the --compile-plan option.)
+(execute-plan, Take a query plan as binary and execute it. Binary query plans can be generated using the --compile-plan option.)
=== modified file 'bin/zorbacmdproperties_base.h'
--- bin/zorbacmdproperties_base.h 2012-02-20 10:10:44 +
+++ bin/zorbacmdproperties_base.h 2012-02-27 09:10:24 +
@@ -308,7 +308,7 @@
else if (strcmp (*argv, --compile-plan) == 0 || strncmp (*argv, -c, 2) == 0) {
theCompilePlan = true;
}
- else if (strcmp (*argv, --execute-plan) == 0 || strncmp (*argv, -e, 2) == 0) {
+ else if (strcmp (*argv, --execute-plan) == 0) {
theExecutePlan = true;
}
else if (strcmp (*argv, --) == 0) {
@@ -365,7 +365,7 @@
--stop-words\nMapping specifying a stop-words URI to another.\n\n
--thesaurus\nMapping specifying a thesaurus URI to another.\n\n
--compile-plan, -c\nOutput the query plan as binary.\n\n
---execute-plan, -e\nTake a query plan as binary and execute it. Binary query plans can be generated using the --compile-plan option.\n\n
+--execute-plan\nTake a query plan as binary and execute it. Binary query plans can be generated using the --compile-plan option.\n\n
;
}
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/compile_queryplan into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/compile_queryplan into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/compile_queryplan into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 -- https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/pul-and-xdm-schemas into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/pul-and-xdm-schemas/+merge/94209 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/compile_queryplan into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/compile_queryplan into lp:zorba has been updated. Commit Message changed to: Remove conflicting shortcut -e for --execute-plan option. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 -- https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/compile_queryplan into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/compile_queryplan into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 -- https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/compile_queryplan into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/compile_queryplan into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 -- https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/compile_queryplan into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1. Got: 1 Approve, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/compile_queryplan into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/compile_queryplan into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 -- https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-scratch
into lp:zorba.
Requested reviews:
Markos Zaharioudakis (markos-za)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/94776
Fixed bug in codegen: do not create a materialize clause if one exists already
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/94776
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'ChangeLog'
--- ChangeLog 2012-02-24 05:07:01 +
+++ ChangeLog 2012-02-27 14:49:38 +
@@ -29,6 +29,7 @@
* Fixed bug #907872 (segfault when returning an input ItemSequence from an external function).
* Fixed bug #905050 (setting and getting the context item type via the c++ api).
* Added createDayTimeDuration, createYearMonthDuration, createDocumentNode, createCommentNode, createPiNode to api's ItemFactory.
+ * Fixed bug in codegen: do not create a materialize clause if one exists already
* Added split function to the string module that allows for streamable tokenization but doesn't have regular expression
support.
* Fixed bug involving positional var and groupby
=== modified file 'src/compiler/codegen/plan_visitor.cpp'
--- src/compiler/codegen/plan_visitor.cpp 2012-01-11 17:30:25 +
+++ src/compiler/codegen/plan_visitor.cpp 2012-02-27 14:49:38 +
@@ -875,7 +875,7 @@
bool isGeneral = v.is_general();
- ulong numClauses = v.num_clauses();
+ csize numClauses = v.num_clauses();
if (v.is_sequential())
{
@@ -883,9 +883,9 @@
{
if (v.has_sequential_clauses())
{
-ulong numForClauses = 0;
+csize numForClauses = 0;
-for (ulong i = 0; i numClauses; ++i)
+for (csize i = 0; i numClauses; ++i)
{
const flwor_clause* c = v[i];
@@ -921,8 +921,11 @@
}
}
+ // Note: a materialize clause may exist already in case plan serialization
+ // is on (see comment in materialize_clause::clone)
if (!isGeneral
v.get_return_expr()-is_sequential()
+ v.get_clause(numClauses-1)-get_kind() != flwor_clause::materialize_clause
(v.get_order_clause() != NULL || v.get_group_clause() == NULL))
{
materialize_clause* mat =
@@ -938,8 +941,8 @@
std::vectorOrderModifier modifiers;
std::vectorexpr_t orderingExprs;
- ulong numForClauses = 0;
- ulong i = 0;
+ csize numForClauses = 0;
+ csize i = 0;
while (i numClauses)
{
@@ -1038,7 +1041,7 @@
}
}
- for (ulong i = 0; i numClauses; ++i)
+ for (csize i = 0; i numClauses; ++i)
{
const flwor_clause* c = v[i];
=== modified file 'src/compiler/expression/expr_put.cpp'
--- src/compiler/expression/expr_put.cpp 2012-01-11 17:30:25 +
+++ src/compiler/expression/expr_put.cpp 2012-02-27 14:49:38 +
@@ -210,17 +210,19 @@
PUT_SUB(IN, theDomainExpr);
#else
- os indent FOR expr_addr(this) inc_indent;
+ os indent FOR expr_addr(this) ;
put_qname(theVarExpr-get_name(), os);
+
os expr_addr(theVarExpr.getp());
+
if (thePosVarExpr != NULL)
{
os AT ;
put_qname(thePosVarExpr-get_name(), os);
os expr_addr(thePosVarExpr.getp());
}
- os endl dec_indent indent [\n inc_indent;
+ os endl indent [\n inc_indent;
theDomainExpr-put(os);
#endif
@@ -241,8 +243,12 @@
#else
os indent LET expr_addr(this) ;
+
put_qname(theVarExpr-get_name(), os);
- os expr_addr(theVarExpr.getp()) [\n inc_indent;
+
+ os expr_addr(theVarExpr.getp());
+
+ os endl indent [\n inc_indent;
theDomainExpr-put(os);
#endif
@@ -313,9 +319,9 @@
//os indent ORDER BY ;
- unsigned numColumns = num_columns();
+ csize numColumns = num_columns();
- for (unsigned i = 0; i numColumns; i++)
+ for (csize i = 0; i numColumns; i++)
{
theOrderingExprs[i]-put(os);
}
@@ -348,39 +354,58 @@
{
BEGIN_PUT(flwor_expr);
- for (unsigned i = 0; i num_clauses(); i++)
+ for (csize i = 0; i num_clauses(); i++)
{
const flwor_clause c = *((*this)[i]);
-if (c.get_kind() == flwor_clause::where_clause)
+switch (c.get_kind())
+{
+case flwor_clause::where_clause:
{
PUT_SUB( WHERE, static_castconst where_clause *(c)-get_expr() );
+ break;
}
-else if (c.get_kind() == flwor_clause::count_clause)
+case flwor_clause::count_clause:
{
os indent COUNT $;
put_qname(static_castconst count_clause *(c)-get_var()-get_name(), os);
os endl;
+ break;
}
-else if (c.get_kind() == flwor_clause::for_clause)
+case flwor_clause::for_clause:
{
static_castconst for_clause *(c)-put(os);
+ break;
}
-else if (c.get_kind() == flwor_clause::let_clause)
+case flwor_clause::let_clause:
{
static_castconst let_clause *(c)-put(os);
+ break;
}
-else if (c.get_kind() ==
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/94776 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/94776 -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/94776 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2012-02-27T14-51-16.832Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/94776 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Validation queue job markos-scratch-2012-02-27T14-51-16.832Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/94776 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/compile_queryplan into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/compile_queryplan-2012-02-27T15-23-58.529Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/compile_queryplan into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 942011] [NEW] translator should flatten a tree of StringConcatExprs
Public bug reported: For example, a query like: foo || boo || ga || ga should generate a single fo_expr instead of three (and correspondigly, a sinlge ConcatStrIterator iterator). ** Affects: zorba Importance: High Assignee: William Candillon (wcandillon) Status: New -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/942011 Title: translator should flatten a tree of StringConcatExprs Status in Zorba - The XQuery Processor: New Bug description: For example, a query like: foo || boo || ga || ga should generate a single fo_expr instead of three (and correspondigly, a sinlge ConcatStrIterator iterator). To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/942011/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/compile_queryplan into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/compile_queryplan into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 -- https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/compile_queryplan into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/compile_queryplan into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 -- https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/compile_queryplan into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/compile_queryplan into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job compile_queryplan-2012-02-27T15-23-58.529Z is finished. The final status was: 1 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 934607] Re: eval + plan serializer + optimizer bug
Fixed in r10679 ** Changed in: zorba Status: New = Fix Committed -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/934607 Title: eval + plan serializer + optimizer bug Status in Zorba - The XQuery Processor: Fix Committed Bug description: Using eval + plan serializer + optimizer in a query that contains a materialize clause causes a segmentation fault when the deserialized query is executed. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/934607/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/serializer into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/serializer into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/serializer/+merge/94695 -- https://code.launchpad.net/~zorba-coders/zorba/serializer/+merge/94695 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/serializer into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/serializer-2012-02-27T17-46-12.004Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/serializer/+merge/94695 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/serializer into lp:zorba
Validation queue job serializer-2012-02-27T17-46-12.004Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/serializer/+merge/94695 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/serializer into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1. Got: 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/serializer/+merge/94695 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/serializer into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/serializer into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/serializer/+merge/94695 -- https://code.launchpad.net/~zorba-coders/zorba/serializer/+merge/94695 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba
I will make all those changes, Thanks. and answering your questions - you can check using transcode::is_necessary if a encoding is supported If I am not wrong I am using it that way. - What's the default encoding for unparsed-text? UTF-8 The thing with the encoding is that the encoding is defined in the call of the function unparsed-text and unparsed-text-available being initialized with UTF-8 as a default, should I change the default definition to be inside readDocument function so that you don't have to defined in each function? -- https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/compile_queryplan into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/compile_queryplan into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 -- https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/compile_queryplan into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/compile_queryplan-2012-02-27T18-40-06.124Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 942161] [NEW] serializer to support arbitrary encodings
Public bug reported: The Serializer currently supports UTF-8 and UTF-16 as output encodings. The transcode::stream that was recently pushed into Zorba allows for arbitrary encodings. With this feature, the serializer should make use of it to also allow for arbitrary encodings. However, this is a change that requires the API to change in a backwards incompatible way. Specifically, the way how a C++ api user can choose the encoding needs to be adapted. ** Affects: zorba Importance: Medium Assignee: Nicolae Brinza (nbrinza) Status: New -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/942161 Title: serializer to support arbitrary encodings Status in Zorba - The XQuery Processor: New Bug description: The Serializer currently supports UTF-8 and UTF-16 as output encodings. The transcode::stream that was recently pushed into Zorba allows for arbitrary encodings. With this feature, the serializer should make use of it to also allow for arbitrary encodings. However, this is a change that requires the API to change in a backwards incompatible way. Specifically, the way how a C++ api user can choose the encoding needs to be adapted. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/942161/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/compile_queryplan into lp:zorba
Validation queue job compile_queryplan-2012-02-27T18-40-06.124Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 942171] [NEW] file module to allow for arbitrary encodings
Public bug reported: The file module's read and write functions need to be able to read and write arbitrary encodings. Currently, only reading arbitrary encodings is supported. The write part requires API incompatible changes. Specifically, the file:write function should be removed and split into a file:write-text and file:write-binary function. The former accept the encoding as parameter. Non of the write functions should implicitly call fn:serialize. ** Affects: zorba Importance: Medium Assignee: Matthias Brantner (matthias-brantner) Status: New -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/942171 Title: file module to allow for arbitrary encodings Status in Zorba - The XQuery Processor: New Bug description: The file module's read and write functions need to be able to read and write arbitrary encodings. Currently, only reading arbitrary encodings is supported. The write part requires API incompatible changes. Specifically, the file:write function should be removed and split into a file:write-text and file :write-binary function. The former accept the encoding as parameter. Non of the write functions should implicitly call fn:serialize. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/942171/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/compile_queryplan into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/compile_queryplan into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 -- https://code.launchpad.net/~zorba-coders/zorba/compile_queryplan/+merge/94733 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug931580 into lp:zorba
Review: Needs Fixing The change provides a great extension to all of Zorba's language bindings. Two things: - it currently doesn't build on my machine (Ubuntu 11.04 with gcc 4.5.2) [ 97%] Building CXX object swig/python/CMakeFiles/_zorba_api_python.dir/zorba_apiPYTHON_wrap.cxx.o In file included from /usr/include/python2.7/Python.h:8:0, from /home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx:158: /usr/include/python2.7/pyconfig.h:1155:0: warning: _POSIX_C_SOURCE redefined /usr/include/features.h:163:0: note: this is the location of the previous definition /usr/include/python2.7/pyconfig.h:1177:0: warning: _XOPEN_SOURCE redefined /usr/include/features.h:165:0: note: this is the location of the previous definition /home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx: In function ‘PyTypeObject* _PySwigObject_type()’: /home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx:1855:7: warning: missing initializer for member ‘_typeobject::tp_version_tag’ /home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx: In function ‘PyTypeObject* _PySwigPacked_type()’: /home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx:2030:7: warning: missing initializer for member ‘_typeobject::tp_version_tag’ /home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx: In member function ‘int SAX2Attributes::getIndex(const char*, const char*) const’: /home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx:2894:14: warning: converting to non-pointer type ‘int’ from NULL /home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx: In member function ‘int SAX2Attributes::getIndex(const char*) const’: /home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx:2902:14: warning: converting to non-pointer type ‘int’ from NULL In file included from /home/mbrantner/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx:3471:0: /home/mbrantner/zorba/build/swig/python/StaticContext.h: At global scope: /home/mbrantner/zorba/build/swig/python/StaticContext.h:116:3: error: ‘TypeIdentifier’ does not name a type /home/mbrantner/zorba/build/swig/python/StaticContext.h:117:3: error: ‘TypeIdentifier’ does not name a type /home/mbrantner/zorba/build/swig/python/StaticContext.h:118:3: error: ‘TypeIdentifier’ does not name a type /home/mbrantner/zorba/build/swig/python/StaticContext.h:120:39: error: ‘TypeIdentifier’ does not name a type /home/mbrantner/zorba/build/swig/python/StaticContext.h:120:55: error: ISO C++ forbids declaration of ‘aType’ with no type - Also, I'm a little bit worried about the absence of tests for the language bindings other than Java. We should at least have some testing for them (e.g. PHP, Python, and Ruby). -- https://code.launchpad.net/~zorba-coders/zorba/bug931580/+merge/92818 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/bug931580 into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 867059] Re: Can not handle largest xs:unsignedLong values
** Changed in: zorba Milestone: None = 2.2 -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/867059 Title: Can not handle largest xs:unsignedLong values Status in Zorba - The XQuery Processor: In Progress Bug description: When ZORBA_WITH_BIG_INTEGER=OFF, the implementation of Integer used a long long for the representation. However, Zorba currently uses Integer for xs:unsignedLong. This can not handle the largest, unsigned, 64-bit value. A possible solution would be to templatize Integer with the representation type, e.g.: typedef IntegerImpllong long Integer; typedef IntegerImplunsigned long long UnsignedInteger; To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/867059/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867059 into lp:zorba
The change log should mention that the corresponding bug is fixed with this change. -- https://code.launchpad.net/~zorba-coders/zorba/bug-867059/+merge/83717 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867059 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-867059/+merge/83717 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba
I will make all those changes, Thanks. and answering your questions - you can check using transcode::is_necessary if a encoding is supported If I am not wrong I am using it that way. My bad, I meant transcode::is_supported should be used. - What's the default encoding for unparsed-text? UTF-8 OK, got it. It's fine as it is. -- https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental
The proposal to merge lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental has been updated. Commit Message changed to: msg For more details, see: https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94863 -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94863 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/module-schema-tools. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental
The proposal to merge lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94863 -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94863 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/module-schema-tools. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental
The attempt to merge lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental failed. Below is the output from the failed tests. experimental build started for lp:~zorba-coders/zorba/module-schema-tools. Check out http://module-schema-tools.zorba-xquery.com/ in half an hour or so. Logfile at http://zorbatest.lambda.nu:8080/remotequeue/experimental/module-schema-tools.log . -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94863 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/module-schema-tools. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/concat_operator into lp:zorba
William Candillon has proposed merging lp:~zorba-coders/zorba/concat_operator
into lp:zorba.
Requested reviews:
Markos Zaharioudakis (markos-za)
Matthias Brantner (matthias-brantner)
Related bugs:
Bug #937120 in Zorba: Improve error message for ||
https://bugs.launchpad.net/zorba/+bug/937120
Bug #942011 in Zorba: translator should flatten a tree of StringConcatExprs
https://bugs.launchpad.net/zorba/+bug/942011
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94869
Optimize iterator generation for the concat operator.
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94869
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/compiler/translator/translator.cpp'
--- src/compiler/translator/translator.cpp 2012-02-19 19:43:28 +
+++ src/compiler/translator/translator.cpp 2012-02-27 22:07:44 +
@@ -9401,7 +9401,26 @@
expr_t right = pop_nodestack();
expr_t left = pop_nodestack();
concat_args.push_back(left);
- concat_args.push_back(right);
+
+ //If the right leaf is the concat expr,
+ //we add directly its leafs to the new concat expr.
+ fo_expr* lFoExpr = dynamic_castfo_expr*(right.getp());
+ bool rightLeafIsConcatExpr = false;
+ if(lFoExpr != NULL) {
+if(lFoExpr-get_func() == GET_BUILTIN_FUNCTION(FN_CONCAT_N)) {
+ rightLeafIsConcatExpr = true;
+ csize i = 0;
+ for(i = 0; i lFoExpr-num_args(); ++i)
+ {
+concat_args.push_back(lFoExpr-get_arg(i));
+ }
+}
+ }
+
+ if(!rightLeafIsConcatExpr){
+concat_args.push_back(right);
+ }
+
rchandleexpr concat = new fo_expr(theRootSctx, loc, GET_BUILTIN_FUNCTION(FN_CONCAT_N), concat_args);
push_nodestack(concat);
}
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 942011] Re: translator should flatten a tree of StringConcatExprs
** Branch linked: lp:~zorba-coders/zorba/concat_operator -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/942011 Title: translator should flatten a tree of StringConcatExprs Status in Zorba - The XQuery Processor: In Progress Bug description: For example, a query like: foo || boo || ga || ga should generate a single fo_expr instead of three (and correspondigly, a sinlge ConcatStrIterator iterator). To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/942011/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/parse-fragment into lp:zorba
The proposal to merge lp:~nbrinza/zorba/parse-fragment into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/94419 -- https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/94419 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/parse-fragment into lp:zorba
The proposal to merge lp:~nbrinza/zorba/parse-fragment into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/94419 -- https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/94419 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/concat_operator into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94869 -- https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94869 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/concat_operator into lp:zorba
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94869 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 942011] Re: translator should flatten a tree of StringConcatExprs
** Changed in: zorba Status: New = In Progress -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/942011 Title: translator should flatten a tree of StringConcatExprs Status in Zorba - The XQuery Processor: In Progress Bug description: For example, a query like: foo || boo || ga || ga should generate a single fo_expr instead of three (and correspondigly, a sinlge ConcatStrIterator iterator). To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/942011/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental
The proposal to merge lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94863 -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94863 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/module-schema-tools. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94863 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/module-schema-tools. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/concat_operator into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94869 -- https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94869 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental
The proposal to merge lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental has been updated. Commit Message changed to: cmsg For more details, see: https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94880 -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94880 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/module-schema-tools. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental
Review: Approve g -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94880 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/module-schema-tools. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental
The proposal to merge lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94880 -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94880 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/module-schema-tools. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental
The attempt to merge lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental failed. Below is the output from the failed tests. experimental build started for lp:~zorba-coders/zorba/module-schema-tools. Check out http://module-schema-tools.zorba-xquery.com/ in half an hour or so. Logfile at http://zorbatest.lambda.nu:8080/remotequeue/experimental/module-schema-tools.log . -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94880 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/module-schema-tools. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental
The proposal to merge lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94880 -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94880 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/module-schema-tools. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental
The proposal to merge lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94880 -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94880 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/module-schema-tools. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental
The attempt to merge lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental failed. Below is the output from the failed tests. experimental build started for lp:~zorba-coders/zorba/module-schema-tools. Check out http://module-schema-tools.zorba-xquery.com/ in half an hour or so. Logfile at http://zorbatest.lambda.nu:8080/remotequeue/experimental/module-schema-tools.log . -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94880 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/module-schema-tools. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental
The proposal to merge lp:~zorba-coders/zorba/module-schema-tools into lp:~zorba-coders/zorba/zorba-experimental has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94880 -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/94880 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/module-schema-tools. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 938934] Re: collection dml:truncate function missing
** Branch linked: lp:~zorba-coders/zorba/bug-938934 -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/938934 Title: collection dml:truncate function missing Status in Zorba - The XQuery Processor: New Bug description: The Collection's dml module should provide a new function called truncate. This function should be backed by a new update primitive that can be efficiently implemented in a particular store. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/938934/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-938934 into lp:zorba
Matthias Brantner has proposed merging lp:~zorba-coders/zorba/bug-938934 into lp:zorba. Requested reviews: Matthias Brantner (matthias-brantner) Till Westmann (tillw) Related bugs: Bug #938934 in Zorba: collection dml:truncate function missing https://bugs.launchpad.net/zorba/+bug/938934 For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-938934/+merge/94897 -- https://code.launchpad.net/~zorba-coders/zorba/bug-938934/+merge/94897 Your team Zorba Coders is subscribed to branch lp:zorba. === modified file 'ChangeLog' --- ChangeLog 2012-02-27 15:17:53 + +++ ChangeLog 2012-02-28 02:00:28 + @@ -10,6 +10,7 @@ %ann:must-copy-input-nodes to be used by the no-copy optimization. * Caching of results for recursive functions with atomic parameter and return types. * Added %ann:cache and %ann:no-cache to enable or disable caching of results of functions with atomic parameter and return types. + * Added truncate function to the collection modules for efficient deletion of all nodes in a collection. * Fixed bug 917923 (bug in copying outer var values into the eval dynamic context) * Fixed bug 924063 (sentence is incorrectly incremented when token characters end without sentence terminator) * Optimization: change the implementation of the free-vars annotation and got rid === modified file 'modules/com/zorba-xquery/www/modules/store/dynamic/collections/dml.xq' --- modules/com/zorba-xquery/www/modules/store/dynamic/collections/dml.xq 2011-08-26 23:36:24 + +++ modules/com/zorba-xquery/www/modules/store/dynamic/collections/dml.xq 2012-02-28 02:00:28 + @@ -260,7 +260,7 @@ : @return The result of this function is an empty XDM instance and a pending update : list which, once applied, deletes the last node from the collection. : - : @error zerr:ZDDY0009 If available collections does not provide a mapping + : @error zerr:ZDDY0003 If available collections does not provide a mapping :for the expanded QName $name. : @error zerr:ZDDY0011 if the collection doesn't contain any node. : @@ -278,7 +278,7 @@ : @return The result of this function is an empty XDM instance and a pending update : list which, once applied, deletes the last n nodes. : - : @error zerr:ZDDY0009 If available collections does not provide a mapping + : @error zerr:ZDDY0003 If available collections does not provide a mapping :for the expanded QName $name. : @error zerr:ZDDY0011 if the collection doesn't contain the given number of nodes. : @@ -288,6 +288,21 @@ $number as xs:integer) external; (:~ + : The truncate function is an updating function that deletes the + : entire contents of collection. + : + : @param $name The name of the collection whose content to delete + : + : @return The result of this function is an empty XDM instance and a pending update + : list which, once applied, deletes the nodes. + : + : @error zerr:ZDDY0003 If available collections does not provide a mapping + :for the expanded QName $name. + : + :) +declare updating function cdml:truncate($name as xs:QName) external; + +(:~ : The index-of function return the index of the given node in the collection. : : @param $node The node to retrieve the index from. @@ -307,7 +322,7 @@ : : @return The sequence contained in the given collection. : - : @error zerr:ZDDY0009 If available collections does not provide a mapping + : @error zerr:ZDDY0003 If available collections does not provide a mapping :for the expanded QName $name. : :) === modified file 'modules/com/zorba-xquery/www/modules/store/static/collections/dml.xq' --- modules/com/zorba-xquery/www/modules/store/static/collections/dml.xq 2011-10-03 09:18:49 + +++ modules/com/zorba-xquery/www/modules/store/static/collections/dml.xq 2012-02-28 02:00:28 + @@ -409,6 +409,22 @@ $number as xs:integer) external; (:~ + : The truncate function is an updating function that deletes the + : entire contents of collection. + : + : @param $name The name of the collection whose content to delete + : + : @return The result of this function is an empty XDM instance and a pending update + : list which, once applied, deletes the nodes. + : + : @error zerr:ZDDY0001 if the collection identified by $name is not declared. + : @error zerr:ZDDY0003 if the collection identified by $name is not available. + : + :) + +declare updating function cdml:truncate($name as xs:QName) external; + +(:~ : The index-of function that returns the position of the node in its collection. : : @param $node The node to retrieve the index for. === modified file 'src/functions/func_collections_impl.cpp' --- src/functions/func_collections_impl.cpp 2012-02-16 12:48:17 + +++ src/functions/func_collections_impl.cpp 2012-02-28 02:00:28 + @@ -293,6 +293,21 @@ /***
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-938934 into lp:zorba
- fix bug #938934 collection dml:truncate function missing - fixes documentation bug: raise zerr:ZDDY0003 instead of zerr:ZDDY0009 -- https://code.launchpad.net/~zorba-coders/zorba/bug-938934/+merge/94897 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-938934 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-938934 into lp:zorba has been updated. Commit Message changed to: - fix bug #938934 collection dml:truncate function missing - fixes documentation bug: raise zerr:ZDDY0003 instead of zerr:ZDDY0009 For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-938934/+merge/94897 -- https://code.launchpad.net/~zorba-coders/zorba/bug-938934/+merge/94897 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-938934 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-938934 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-938934/+merge/94897 -- https://code.launchpad.net/~zorba-coders/zorba/bug-938934/+merge/94897 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-938934 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-938934-2012-02-28T02-03-09.189Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-938934/+merge/94897 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 935639] Re: Closing without releasing objects
** Branch linked: lp:~zorba-coders/zorba/bug935639 -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/935639 Title: Closing without releasing objects Status in Zorba - The XQuery Processor: New Bug description: Provide a better solution for any use case where Zorba is closed without releasing in-memory objects. This is very notorious on managed memory languages where you never expect a memory leak, like Java. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/935639/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug935639 into lp:zorba
Rodolfo Ochoa has proposed merging lp:~zorba-coders/zorba/bug935639 into
lp:zorba.
Requested reviews:
Cezar Andrei (cezar-andrei)
Matthias Brantner (matthias-brantner)
Related bugs:
Bug #935639 in Zorba: Closing without releasing objects
https://bugs.launchpad.net/zorba/+bug/935639
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug935639/+merge/94900
The problem can't be solved by technical means, the developer have to take care
of resource usage, as in C++ the user must release all objects before shutdown
the store, the same thing applies for XQJ.
So. the best workaround this problem is to show a more friendly message around
the Strings Pool and create documentation that explain this issue. At the end,
this issue affects every API usage from our clients.
Please check my changes and help me with English usage in the new document I
created.
--
https://code.launchpad.net/~zorba-coders/zorba/bug935639/+merge/94900
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'doc/zorba/indexpage.dox.in'
--- doc/zorba/indexpage.dox.in 2012-01-03 18:03:54 +
+++ doc/zorba/indexpage.dox.in 2012-02-28 02:26:20 +
@@ -29,6 +29,8 @@
- \ref ft_thesaurus
- \ref errors_warnings
- \ref impl_dep_features
+ - \ref memory_management
+ - \ref memory_leaks
\section xqlib XQuery Modules
- a href=../xqdoc/xhtml/index.htmlXQuery Module Library/a
=== added file 'doc/zorba/memory_leaks.dox'
--- doc/zorba/memory_leaks.dox 1970-01-01 00:00:00 +
+++ doc/zorba/memory_leaks.dox 2012-02-28 02:26:20 +
@@ -0,0 +1,146 @@
+/** \page memory_leaks Memory Leaks
+
+\section memory_leaks_intro Introduction
+
+The Zorba XQuery processor manage automatically its own memory, but still, there are cases where you may receive the following message:
+
+\code
+Zorba did not close properly, objects may still in memory while shutdown the store. For help avoiding this message please refer to http://www.zorba-xquery.com/memory_leaks.
+ID: 1 Referenced URI: [..uri...]
+...
+
+Zorba Internal Fatal Error in
+[n] referenced URIs remain in the string pool.
+\endcode
+
+
+This message means the store is being shutdown, but there are still URIs strings in the pool because
+there are still references (smart pointers) to those strings.
+The references may be somewhere in the zorba engine (which usually means there is a memory leak) or in the application.
+For the application, the rule is that before shutting down the store,
+all variables storing references to zorba objects must have gone out of scope, or explicitly set to NULL.
+
+So, strictly speaking, your program is leaking resources.
+
+There are several cases using Zorba's APIs in C++ or other languages where you can produce this error besides everything looks correct in your code, here is an example:
+
+
+\section memory_leaks_example_c Example in C++
+Here is a code example that shows how a StaticContext and a Query are pointing to the URI http://www.foo.com,
+and they are still in memory when the store is being shutdown.
+
+\code
+int main(int argc, char* argv[])
+{
+ void* lStore = zorba::StoreManager::getStore();
+ Zorba* lZorba = Zorba::getInstance(lStore);
+
+ StaticContext_t lContext = lZorba-createStaticContext();
+ lContext-addNamespace(foo, http://www.foo.com;);
+ XQuery_t lQuery = lZorba-compileQuery(foo:e/, lContext);
+ lQuery-execute();
+
+ lZorba-shutdown();
+ zorba::StoreManager::shutdownStore(lStore);
+ return 0;
+}
+\endcode
+
+So, for this scenario, the ideal way to solve the problem is through scopes,
+where you implement certain part of code in methods and release them when the objects loose their reference.
+Other way to do it, is to explicitely set the object to null, the autopointer automatically will free the object.
+
+Solution example:
+\code
+int main(int argc, char* argv[])
+{
+ void* lStore = zorba::StoreManager::getStore();
+ Zorba* lZorba = Zorba::getInstance(lStore);
+
+ { // Use a scope
+
+ StaticContext_t lContext = lZorba-createStaticContext();
+lContext-addNamespace(foo, http://www.foo.com;);
+XQuery_t lQuery = lZorba-compileQuery(foo:e/, lContext);
+lQuery-execute();
+lContext = NULL; // or explicitely free the resource
+lQuery = NULL;
+ }
+ lZorba-shutdown();
+ zorba::StoreManager::shutdownStore(lStore);
+ return 0;
+}
+\endcode
+
+
+\section memory_leaks_example_java Example in Java
+This particular error is specially notorious when a memory managed language
+shows the error because you expect the language frees all memory, here is an example:
+
+\code
+ public static void main ( String argv[] )
+ {
+InMemoryStore store = InMemoryStore.getInstance();
+Zorba zorba = Zorba.getInstance ( store );
+
+StaticContext context = zorba.createStaticContext();
+context.addNamespace(foo, http://www.foo.com;);
+XQuery query = zorba.compileQuery(foo:e/, context);
+String result = query.execute();
+
+
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-938934 into lp:zorba
Validation queue job bug-938934-2012-02-28T02-03-09.189Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-938934/+merge/94897 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-938934 into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1. Got: 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug-938934/+merge/94897 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-938934 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-938934 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-938934/+merge/94897 -- https://code.launchpad.net/~zorba-coders/zorba/bug-938934/+merge/94897 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-938934 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-938934/+merge/94897 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
