Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-windows-compile into lp:zorba

2012-09-06 Thread Sorin Marian Nasoi
Review: Approve Both NMAKE and VS projects now build fine on my machine. -- https://code.launchpad.net/~zorba-coders/zorba/fix-windows-compile/+merge/122976 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/paging_with_refs into lp:zorba

2012-09-06 Thread David Graf
There are a few small fixes that I've sent as a patch via email as I could not push them into this branch. Once this patch is applied this branch works for me. I patched you patch. Unfortunately, I needed to do it by hand. Did you create the patch with bzr diff? --

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/paging_with_refs into lp:zorba

2012-09-06 Thread David Graf
The patch looks great. As far as I can tell, the documentation should also mention the error zerr:ZAPI0028. done -- https://code.launchpad.net/~davidagraf/zorba/paging_with_refs/+merge/119553 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/lastmodifiedfix into lp:zorba

2012-09-06 Thread Ghislain Fourny
Review: Approve Nice catch! I would have used the constructor syntax rather than the assignment syntax for readability though (even though it has identical semantics - copy constructor call - in this case). But I leave the decision to you. --

[Zorba-coders] [Merge] lp:~davidagraf/zorba/lastmodifiedfix into lp:zorba

2012-09-06 Thread David Graf
The proposal to merge lp:~davidagraf/zorba/lastmodifiedfix into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~davidagraf/zorba/lastmodifiedfix/+merge/122712 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba

2012-09-06 Thread Ghislain Fourny
Hi Matthias, Actually, absolutely all items in a tree that is in a collection share a unique CollectionTreeInfo instance, so that the TreeId, position, etc, exist only once physically. JSON items point to it (as before), and node items have their XML tree point to it. JSON items only have a

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba

2012-09-06 Thread Ghislain Fourny
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548 --

Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/error-messages into lp:zorba

2012-09-06 Thread Nicolae Brinza
Matthias, this is a known issue -- all the error mesages in the parser are hard-coded. There is an open bug and even some work done in a branch to fix these. But this current bug needs to be merged for the 2.7 release, while that other one was not scheduled. So I think it should be approved. --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn-serialize-json into lp:zorba

2012-09-06 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/fn-serialize-json into lp:zorba has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fn-serialize-json/+merge/120569 --

Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/error-messages into lp:zorba

2012-09-06 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~nbrinza/zorba/error-messages/+merge/122401 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/error-messages into lp:zorba

2012-09-06 Thread William Candillon
Review: Approve -- https://code.launchpad.net/~nbrinza/zorba/error-messages/+merge/122401 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~nbrinza/zorba/error-messages into lp:zorba

2012-09-06 Thread Nicolae Brinza
The proposal to merge lp:~nbrinza/zorba/error-messages into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~nbrinza/zorba/error-messages/+merge/122401 -- https://code.launchpad.net/~nbrinza/zorba/error-messages/+merge/122401

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/gen-flwor-opt into lp:zorba

2012-09-06 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/gen-flwor-opt into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/gen-flwor-opt/+merge/87444 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/create-user-typed-atomic-item into lp:zorba

2012-09-06 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/create-user-typed-atomic-item/+merge/120560 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/1039576 into lp:zorba/archive-module

2012-09-06 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/1039576 into lp:zorba/archive-module. Requested reviews: Matthias Brantner (matthias-brantner) Related bugs: Bug #1039576 in Zorba: archive module doesnt create directory entries

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bang_operator into lp:zorba

2012-09-06 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bang_operator/+merge/121347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bang_operator into lp:zorba

2012-09-06 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/bang_operator into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bang_operator/+merge/121347 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba

2012-09-06 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: text conflict in src/store/naive/node_items.h -- https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba

2012-09-06 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548 --

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/paging_with_refs into lp:zorba

2012-09-06 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~davidagraf/zorba/paging_with_refs/+merge/119553 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba

2012-09-06 Thread Rodolfo Ochoa
Not doable with Swig 1.x Only Swig 2.x apply -- https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/error-messages into lp:zorba

2012-09-06 Thread Zorba Build Bot
The attempt to merge lp:~nbrinza/zorba/error-messages into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job error-messages-2012-09-06T22-02-02.164Z is finished. The final

[Zorba-coders] [Merge] lp:~nbrinza/zorba/error-messages into lp:zorba

2012-09-06 Thread Zorba Build Bot
The proposal to merge lp:~nbrinza/zorba/error-messages into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~nbrinza/zorba/error-messages/+merge/122401 -- https://code.launchpad.net/~nbrinza/zorba/error-messages/+merge/122401

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/1039576 into lp:zorba/archive-module

2012-09-06 Thread Juan Zacarias
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/1039576/+merge/123170 Your team Zorba Coders is subscribed to branch lp:zorba/archive-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bang_operator into lp:zorba

2012-09-06 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/bang_operator/+merge/121347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bang_operator into lp:zorba

2012-09-06 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bang_operator into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bang_operator/+merge/121347 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba

2012-09-06 Thread Rodolfo Ochoa
I was able to fix the SWIG problems, I'm still having issues with UTF conversion. -- https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bang_operator into lp:zorba

2012-09-06 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/bang_operator into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bang_operator/+merge/121347 --