Review: Needs Fixing
1. Error QNames should not be declared as public constants (see coding
guidelines). Declare them as private variables as follows:
declare %private variable $queue:NOT-EXISTS as xs:QName :=
fn:QName($queue:ERR-NS, queue:NOT-EXISTS);
2. The current XQDoc for those error
Review: Needs Fixing
Basically the same comments as the queue proposal:
1. Make the error QName variables %private;
2. Fix or eliminate the XQDoc for the error QNames;
3. Replace node with item in function XQDoc.
In addition:
4. You have a stray p at the beginning of the header XQDoc comment
Review: Needs Information
1. Do we need to promote this to version 2.0 of the EXpath module? Isn't the
public API exactly the same, as defined by EXpath? I understand the
implementation is different, but I don't believe that's relevant for module
versioning.
2. (Possibly the same question) Do
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
:
Votes: {'Approve': 2, 'Needs commit message': 1}
--
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
Your team Zorba
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
Stage CommitZorba failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/10/console to
view the results.
--
Review: Needs Fixing
1. Very sorry for the mis-information, but this module should NOT have been
moved into the zorba.io namespace. EXpath modules should remain in their
expath.org/ns namespace.
2. Remove the how to build the module information from the XQDoc; XQDoc
should only contain
Review: Needs Information
The changes as made seem fine. Two concerns:
1. Are there any errors raised by the module functions? If so, are they
documented?
2. Matthias: This seems like it is an ideal candidate for JSONify-ing; would
you agree? If so, what would you think is the priority? I'm
The proposal to merge lp:~zorba-coders/zorba/install_mysql_update into
lp:zorba/jdbc-module has been updated.
Commit Message changed to:
Update test-setup script to MySQL 5.6; don't download Connector jar; cleanup.
For more details, see:
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/update3.0_info-extraction-module/+merge/170463
Your team Zorba Coders is subscribed to branch lp:zorba/info-extraction-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_info-extraction-module/+merge/170463
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
The proposal to merge lp:~zorba-coders/zorba/install_mysql_update into
lp:zorba/jdbc-module has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
--
Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_info-extraction-module/+merge/170463
:
Votes: {'Approve': 1}
--
https://code.launchpad.net/~zorba-coders/zorba/update3.0_info-extraction-module/+merge/170463
Your team Zorba Coders
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/update3.0_info-extraction-module/+merge/170463
Stage CommitZorba failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/12/console to
view the results.
--
Review: Approve
I changed the module version declaration back to xquery version 1.0. It
seemed weird to have it claim to be jsoniq when the module is only dealing
with XML nodes. I also added a copyright notice to
modules/nodes/CMakeLists.txt. Other than that looked fine.
--
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_node-position-module/+merge/173105
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fix_examples_XQDoc/+merge/170878
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/fix_examples_XQDoc/+merge/170878
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/fix_examples_XQDoc/+merge/170878
Your
Review: Needs Fixing
--
https://code.launchpad.net/~zorba-coders/zorba/bug1151967/+merge/162905
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_node-position-module/+merge/173105
:
Votes: {'Approve': 1}
--
https://code.launchpad.net/~zorba-coders/zorba/update3.0_node-position-module/+merge/173105
Your team Zorba Coders is
Oops, forgot to comment:
1. Need to fix merge conflict.
2. There are some code changes in here as well. I assume they are the Removing
some warnings comment? If so, please mention that in the commit message for
this proposal, along with the main changes.
--
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/update3.0_node-position-module/+merge/173105
Stage CommitZorba failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/13/console to
view the results.
--
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/fix_examples_XQDoc/+merge/170878
Stage TestZorbaUbuntu failed.
4 tests failed (8345 total tests run).
Check test results at
http://jenkins.lambda.nu/job/TestZorbaUbuntu/58/testReport/ to view the results.
--
Review: Needs Fixing
1. OMG code duplication: the entire contents of http-client.xq.src is copied
(and modified?) from the original http-client module. That's nearly 3000 lines
of some of the ugliest and most error-filled code we've got. No way do we want
to maintain two copies of it. Also,
Thank you for your feedback.
3. The module error codes need to be changed to match the coding guidelines:
http://my.zorba.io/dokuwiki/doku.php?id=coding-guidelines#error_codes
I updated the error codes according to the guidelines
--
1. OMG code duplication: the entire contents of http-client.xq.src is copied
(and modified?) from the original http-client module. That's nearly 3000 lines
of some of the ugliest and most error-filled code we've got. No way do we want
to maintain two copies of it. Also, they both call
All the changes were addressed except for
-I know that it's unrelated to the change but the example using file:read-text
in the materialize function doesn't make sense anymore. Because read-text
returns a seekable string it can be consumed more than once. The http-client
would be the right
Changes done
--
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
The changes as made seem fine. Two concerns:
1. Are there any errors raised by the module functions? If so, are they
documented?
No errors are thrown by the module.
2. Matthias: This seems like it is an ideal candidate for JSONify-ing; would
you agree? If so, what would you think is the
1. Very sorry for the mis-information, but this module should NOT have been
moved into the zorba.io namespace. EXpath modules should remain in their
expath.org/ns namespace.
2. Remove the how to build the module information from the XQDoc; XQDoc
should only contain information on *using*
Discussed with Juan - the is-seekable() function should be easy enough to add,
so sure, let's do it.
--
https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213
Stage TestZorbaUbuntu failed.
2 tests failed (8345 total tests run).
Check test results at
http://jenkins.lambda.nu/job/TestZorbaUbuntu/59/testReport/ to view the results.
--
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
The proposal to merge lp:~zorba-coders/zorba/update3.0_data-cleaning-module
into lp:zorba/data-cleaning-module has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/install_couchbase_update/+merge/171023
Your team Zorba Coders is subscribed to branch lp:zorba/couchbase-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/install_couchbase_update/+merge/171023
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212
Your team Zorba Coders is subscribed to branch lp:zorba/geo-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
Approving the changes as they are. Matthias, let us know if you think it should
JSONified immediately or if we can come back to it.
--
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214
Your team Zorba Coders is subscribed to branch
Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/install_couchbase_update/+merge/171023
Your team Zorba Coders is subscribed to branch lp:zorba/couchbase-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
One note: we cannot JSONify the geo module [can we?], since it is an EXPath
module. There are no common APIs or schemas between geo and geoproj so far as I
know, but they might be used by similar people. So, might it be weird if one is
XML and one is JSON? Not really sure how to make that call.
46 matches
Mail list logo
