[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-ft_module into lp:~zorba-coders/zorba/zorba-experimental

2011-11-04 Thread Zorba Build Bot
The proposal to merge lp:~paul-lucas/zorba/feature-ft_module into 
lp:~zorba-coders/zorba/zorba-experimental has been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-ft_module/+merge/81317
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-ft_module/+merge/81317
Your team Zorba Coders is requested to review the proposed merge of 
lp:~paul-lucas/zorba/feature-ft_module into 
lp:~zorba-coders/zorba/zorba-experimental.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-ft_module into lp:~zorba-coders/zorba/zorba-experimental

2011-11-04 Thread Zorba Build Bot
The attempt to merge lp:~paul-lucas/zorba/feature-ft_module into 
lp:~zorba-coders/zorba/zorba-experimental failed. Below is the output from the 
failed tests.

experimental build started for lp:~paul-lucas/zorba/feature-ft_module. Check 
out http://feature-ft_module.zorba-xquery.com/ in half an hour or so. Logfile 
at 
http://zorbatest.lambda.nu:8080/remotequeue/experimental/feature-ft_module.log .


-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-ft_module/+merge/81317
Your team Zorba Coders is requested to review the proposed merge of 
lp:~paul-lucas/zorba/feature-ft_module into 
lp:~zorba-coders/zorba/zorba-experimental.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-ft_module into lp:~zorba-coders/zorba/zorba-experimental

2011-11-04 Thread Matthias Brantner
The proposal to merge lp:~paul-lucas/zorba/feature-ft_module into 
lp:~zorba-coders/zorba/zorba-experimental has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-ft_module/+merge/81317
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-ft_module/+merge/81317
Your team Zorba Coders is requested to review the proposed merge of 
lp:~paul-lucas/zorba/feature-ft_module into 
lp:~zorba-coders/zorba/zorba-experimental.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-ft_module into lp:~zorba-coders/zorba/zorba-experimental

2011-11-04 Thread Matthias Brantner
The proposal to merge lp:~paul-lucas/zorba/feature-ft_module into 
lp:~zorba-coders/zorba/zorba-experimental has been updated.

Commit Message changed to:

Create experimental sandbox

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-ft_module/+merge/81317
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-ft_module/+merge/81317
Your team Zorba Coders is requested to review the proposed merge of 
lp:~paul-lucas/zorba/feature-ft_module into 
lp:~zorba-coders/zorba/zorba-experimental.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~matthias-brantner/zorba/caching into lp:zorba

2011-11-04 Thread Zorba Build Bot
The proposal to merge lp:~matthias-brantner/zorba/caching into lp:zorba has 
been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~matthias-brantner/zorba/caching/+merge/81304
-- 
https://code.launchpad.net/~matthias-brantner/zorba/caching/+merge/81304
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~matthias-brantner/zorba/caching into lp:zorba

2011-11-04 Thread Zorba Build Bot
The attempt to merge lp:~matthias-brantner/zorba/caching into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:272 
(message):
  Validation queue job caching-2011-11-04T17-29-08.827Z is finished.  The
  final status was:

  

  31 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~matthias-brantner/zorba/caching/+merge/81304
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~matthias-brantner/zorba/caching into lp:zorba

2011-11-04 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/caching-2011-11-04T17-29-08.827Z/log.html
-- 
https://code.launchpad.net/~matthias-brantner/zorba/caching/+merge/81304
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~matthias-brantner/zorba/caching into lp:zorba

2011-11-04 Thread Matthias Brantner
The proposal to merge lp:~matthias-brantner/zorba/caching into lp:zorba has 
been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~matthias-brantner/zorba/caching/+merge/81304
-- 
https://code.launchpad.net/~matthias-brantner/zorba/caching/+merge/81304
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~matthias-brantner/zorba/caching into lp:zorba

2011-11-04 Thread Matthias Brantner
Matthias Brantner has proposed merging lp:~matthias-brantner/zorba/caching into 
lp:zorba.

Requested reviews:
  Matthias Brantner (matthias-brantner)
  Markos Zaharioudakis (markos-za)

For more details, see:
https://code.launchpad.net/~matthias-brantner/zorba/caching/+merge/81304

- automatic caching of recursive, non-sequential, and deterministic functions 
with atomic parameter and return types
- %ann:cache and %ann:no-cache for controlling function result caching
-- 
https://code.launchpad.net/~matthias-brantner/zorba/caching/+merge/81304
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'ChangeLog'
--- ChangeLog	2011-11-04 11:40:20 +
+++ ChangeLog	2011-11-04 17:27:25 +
@@ -54,6 +54,8 @@
 xs:anyAtomicType or xs:untypedAtomic.
   * Added undo for node revalidation
   * Optimization for count(collection()) expressions
+  * Caching of results for recursive functions with atomic parameter and return types.
+  * Added %ann:cache and %ann:no-cache to enable or disable caching of results of functions with atomic parameter and return types.
   * Fixed bug #872796  (validate-in-place can interfere with other update primitives)
   * Fixed bug #872799 (validate-in-place can set incorrect types)
   * Fixed bug #855715 (Invalid escaped characters in regex not caught)

=== modified file 'doc/zorba/options.dox'
--- doc/zorba/options.dox	2011-09-14 06:15:19 +
+++ doc/zorba/options.dox	2011-11-04 17:27:25 +
@@ -278,6 +278,27 @@
 In order to be able to use the value twice, the string:materialize function must be used to materialize the entire contents of the file myfile.txt in memory.
 Otherwise, the error zerr:ZSTR0055 is raised.
 
+\paragraph caching_annotation Caching Results of Functions
+Caching of function results might improve the performance if computational expensive functions are invoked multiple times with the same arguments.
+
+Zorba automatically caches results of recursive, deterministic, and non-sequential functions whose parameter and return types are subtypes of xs:anyAtomicType.
+Specifically, if such a function is called twice with the same arguments, the result of the second call will return the same value without re-evaluating the function.
+
+For example, in the following recursive function computing a fibonacci number, each result is automatically cached and, hence, dramatically improves the performance.
+
+\include zorba/udf/udf-fib-rec.xq
+
+Specifically, this optimization reduces the complexity of the function from O(1.6^n) to O(n).
+
+In order to explicitly disable function caching, the user can specify the %ann:no-cache annotation.
+
+In addition, the user can use the %ann:cache annotation to cache the results of functions other than the ones that are automatically cached.
+However, this will only work if the function is not updating and its parameter and return types are subtypes of xs:anyAtomicType.
+Zorba will raise a warning if caching is explicitly enabled but the function does not meet this criteria (zwarn:ZWST0005).
+
+Please note, that explicitly enforcing caching for sequential or nondeterministic functions might not give the intended result.
+In such cases, Zorba will raise a warning (zwarn:ZWST0006).
+
 \paragraph collection_index_annotations Annotations on Collections and Indexes
 
 The \ref xqddf uses annotations to assign properties to collections and indexes.

=== modified file 'include/zorba/pregenerated/diagnostic_list.h'
--- include/zorba/pregenerated/diagnostic_list.h	2011-10-30 08:04:47 +
+++ include/zorba/pregenerated/diagnostic_list.h	2011-11-04 17:27:25 +
@@ -598,6 +598,8 @@
 
 extern ZORBA_DLL_PUBLIC ZorbaErrorCode ZDDY0034_INDEX_RANGE_VALUE_PROBE_BAD_KEY_TYPES;
 
+extern ZORBA_DLL_PUBLIC ZorbaErrorCode ZDDY0035_INDEX_GENERAL_INSERT;
+
 extern ZORBA_DLL_PUBLIC ZorbaErrorCode ZDDY0031_IC_NOT_DECLARED;
 
 extern ZORBA_DLL_PUBLIC ZorbaErrorCode ZDDY0032_IC_NOT_ACTIVATED;
@@ -750,6 +752,10 @@
 
 extern ZORBA_DLL_PUBLIC ZorbaWarningCode ZWST0004_AMBIGUOUS_SEQUENTIAL_FLWOR;
 
+extern ZORBA_DLL_PUBLIC ZorbaWarningCode ZWST0005_CACHING_NOT_POSSIBLE;
+
+extern ZORBA_DLL_PUBLIC ZorbaWarningCode ZWST0006_CACHING_MIGHT_NOT_BE_INTENDED;
+
 } // namespace zwarn
 } // namespace zorba
 #endif /* ZORBA_DIAGNOSTIC_LIST_API_H */

=== modified file 'modules/com/zorba-xquery/www/modules/pregenerated/errors.xq'
--- modules/com/zorba-xquery/www/modules/pregenerated/errors.xq	2011-10-30 08:04:47 +
+++ modules/com/zorba-xquery/www/modules/pregenerated/errors.xq	2011-11-04 17:27:25 +
@@ -497,6 +497,10 @@
 
 (:~
 :)
+declare variable $zerr:ZDDY0035 as xs:QName := fn:QName($zerr:NS, "zerr:ZDDY0035");
+
+(:~
+:)
 declare variable $zerr:ZDDY0031 as xs:QName := fn:QName($zerr:NS, "zerr:ZDDY0031");
 
 (:~

=== modified file 'modules/com/zorba-xquery/www/modules/pregenerated/warnings.xq'
--- modules/com/zorba-xquery/www/modules/pregenerated/warnings.xq	2011-10-19 15:28:51 +
+++ modules/com/zorba-xquery/www/modules/pregenerated/warnings.

[Zorba-coders] [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba

2011-11-04 Thread noreply
The proposal to merge lp:~ceejatec/zorba/feature-module-installation into 
lp:zorba has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
-- 
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Bug 862089] Re: Split binary/xq install directories for modules

2011-11-04 Thread Zorba Build Bot
** Changed in: zorba
   Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Zorba
Coders, which is the registrant for Zorba.
https://bugs.launchpad.net/bugs/862089

Title:
  Split binary/xq install directories for modules

Status in Zorba - The XQuery Processor:
  Fix Committed

Bug description:
  This is at the request of the Fedora package maintainer.

  Currently Zorba installs the .xq (and .xsd) files for schemas and the
  .so/.dll files for module external functions into the same directory,
  by default share/zorba-VERSION/modules. This does not meet Fedora
  packaging requirements, which state that any platform-dependent files
  such as .so files must go into lib/lib64 directories. Ideally, non-
  platform dependent files such as .xq and .xsd should be filed in
  share.

  There is another problem with the above scheme: since this directory
  is where non-core modules will install themselves also (and the only
  place Zorba will look for them), they are implicitly tied to Zorba's
  version number even though they should have independent versioning.

  The proposal is to split this into a total of four directories:
  platform-dependent/platform-independent, and Zorba-version-specific
  /non-Zorba-version-specific (ie, core modules vs. non-core modules).
  So, for instance:

  CMAKE_INSTALL_PREFIX/
   share/
modules/
core-modules/
 2.1/
   lib64/
modules/
core-modules/
 2.1/

  where "2.1" is the Zorba version.

  The easy way to do this would be to simply put all of the above on the
  default module-path, and change the install process to put everything
  in the right places. One downside to this is that it means Zorba will
  look in many wrong places when doing any URI resolution and when
  loading .so files - it knows it is looking for (say) an .xq file, but
  it will look in the two lib/ directories as well because they're all
  on the same module path.

  A better way to do this would be to separate the concepts inside Zorba
  as well, and have a "URI Path" for all URI resolution which is
  separate from the "module path" which is used for loading external
  function libraries. Zorba could do that for itself easily enough. The
  only issue is what would be the interpretation of --module-path (and
  the corresponding C++ API function) - would that be a backward-
  incompatible change?

To manage notifications about this bug go to:
https://bugs.launchpad.net/zorba/+bug/862089/+subscriptions

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba

2011-11-04 Thread Zorba Build Bot
Validation queue job feature-module-installation-2011-11-04T14-42-02.106Z is 
finished. The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-ft_module into lp:~zorba-coders/zorba/zorba-experimental

2011-11-04 Thread Zorba Build Bot
The proposal to merge lp:~paul-lucas/zorba/feature-ft_module into 
lp:~zorba-coders/zorba/zorba-experimental has been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-ft_module/+merge/81283
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-ft_module/+merge/81283
Your team Zorba Coders is requested to review the proposed merge of 
lp:~paul-lucas/zorba/feature-ft_module into 
lp:~zorba-coders/zorba/zorba-experimental.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-ft_module into lp:~zorba-coders/zorba/zorba-experimental

2011-11-04 Thread Zorba Build Bot
The attempt to merge lp:~paul-lucas/zorba/feature-ft_module into 
lp:~zorba-coders/zorba/zorba-experimental failed. Below is the output from the 
failed tests.

experimental build started for lp:~paul-lucas/zorba/feature-ft_module. Check 
out http://feature-ft_module.zorba-xquery.com/ in half an hour or so. Logfile 
at 
http://zorbatest.lambda.nu:8080/remotequeue/experimental/feature-ft_module.log .


-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-ft_module/+merge/81283
Your team Zorba Coders is requested to review the proposed merge of 
lp:~paul-lucas/zorba/feature-ft_module into 
lp:~zorba-coders/zorba/zorba-experimental.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-ft_module into lp:~zorba-coders/zorba/zorba-experimental

2011-11-04 Thread Matthias Brantner
The proposal to merge lp:~paul-lucas/zorba/feature-ft_module into 
lp:~zorba-coders/zorba/zorba-experimental has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-ft_module/+merge/81283
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-ft_module/+merge/81283
Your team Zorba Coders is requested to review the proposed merge of 
lp:~paul-lucas/zorba/feature-ft_module into 
lp:~zorba-coders/zorba/zorba-experimental.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba

2011-11-04 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/feature-module-installation-2011-11-04T14-42-02.106Z/log.html
-- 
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba

2011-11-04 Thread Matthias Brantner
The proposal to merge lp:~ceejatec/zorba/feature-module-installation into 
lp:zorba has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
-- 
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba

2011-11-04 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba

2011-11-04 Thread Zorba Build Bot
The proposal to merge lp:~ceejatec/zorba/feature-module-installation into 
lp:zorba has been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
-- 
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba

2011-11-04 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1. 
Got: 1 Approve, 1 Needs Information.
-- 
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba

2011-11-04 Thread Zorba Build Bot
Validation queue job feature-module-installation-2011-11-04T11-45-05.497Z is 
finished. The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba

2011-11-04 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/feature-module-installation-2011-11-04T11-45-05.497Z/log.html
-- 
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba

2011-11-04 Thread Chris Hillery
The proposal to merge lp:~ceejatec/zorba/feature-module-installation into 
lp:zorba has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
-- 
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba

2011-11-04 Thread Chris Hillery
>Looks good in general. Only tried compiling so far but didn't install. I would 
>suggest that at
> least somebody with Windows also tries it.

I built and tested (and even debugged) it on Windows, and at least my own test 
cases worked fine.
 
> Minor comments:
> - theURIPath (good name?); theXQPath?

It's used for all URIs, not just .xq files, so I think --uri-path / theURIPath 
is more accurate.
 
> - setLibPath or setLibPaths in the public api?

IMHO, a "path" is "a list of directories." See $PATH in shell, $CLASSPATH in 
Java, etc. So I consistently used "path" for the URI path and Library path. I 
couldn't change setModulePaths(), but actually that's kind of accurate because 
what that function now does is set both the URI and Library paths 
simultaneously.

I spelled out that "path" == "list of directories" in comments and the --help 
output, so hopefully it's not confusing.
 
> - should we really remove -module-path from zorbacmd but keep it in the 
> public sctx (backwards
> incompatible?)

I don't think so. I left --module-path there because I assumed people were 
using it. It is sometimes convenient as well. I originally considered marking 
it as "deprecated" and I'm still not sure that it shouldn't be...
 
> - same for ZORBA_MODULES_INSTALL_DIR

Hm. The variable is only for CMake. I didn't think that "backwards 
compatibility" extended all the way to build configuration variables. I don't 
think it's possible to maintain that variable even as a "convenience wrapper", 
because it would break the core/non-core split.
 
> Will you add documentation & change log before merging?

That is now done.

-- 
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Bug 862089] Re: Split binary/xq install directories for modules

2011-11-04 Thread Chris Hillery
** Branch linked: lp:~ceejatec/zorba/feature-module-installation

-- 
You received this bug notification because you are a member of Zorba
Coders, which is the registrant for Zorba.
https://bugs.launchpad.net/bugs/862089

Title:
  Split binary/xq install directories for modules

Status in Zorba - The XQuery Processor:
  New

Bug description:
  This is at the request of the Fedora package maintainer.

  Currently Zorba installs the .xq (and .xsd) files for schemas and the
  .so/.dll files for module external functions into the same directory,
  by default share/zorba-VERSION/modules. This does not meet Fedora
  packaging requirements, which state that any platform-dependent files
  such as .so files must go into lib/lib64 directories. Ideally, non-
  platform dependent files such as .xq and .xsd should be filed in
  share.

  There is another problem with the above scheme: since this directory
  is where non-core modules will install themselves also (and the only
  place Zorba will look for them), they are implicitly tied to Zorba's
  version number even though they should have independent versioning.

  The proposal is to split this into a total of four directories:
  platform-dependent/platform-independent, and Zorba-version-specific
  /non-Zorba-version-specific (ie, core modules vs. non-core modules).
  So, for instance:

  CMAKE_INSTALL_PREFIX/
   share/
modules/
core-modules/
 2.1/
   lib64/
modules/
core-modules/
 2.1/

  where "2.1" is the Zorba version.

  The easy way to do this would be to simply put all of the above on the
  default module-path, and change the install process to put everything
  in the right places. One downside to this is that it means Zorba will
  look in many wrong places when doing any URI resolution and when
  loading .so files - it knows it is looking for (say) an .xq file, but
  it will look in the two lib/ directories as well because they're all
  on the same module path.

  A better way to do this would be to separate the concepts inside Zorba
  as well, and have a "URI Path" for all URI resolution which is
  separate from the "module path" which is used for loading external
  function libraries. Zorba could do that for itself easily enough. The
  only issue is what would be the interpretation of --module-path (and
  the corresponding C++ API function) - would that be a backward-
  incompatible change?

To manage notifications about this bug go to:
https://bugs.launchpad.net/zorba/+bug/862089/+subscriptions

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp