Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-28 Thread Chris Hillery
FYI, Daniel/Matthias - this proposal will need a commit message in order to get 
merged...
-- 
https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86959
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba

2011-12-28 Thread Chris Hillery
Review: Needs Fixing

- Please put a very prominent comment around the SKIP_TEST block identifying 
why the test is skipped and listing the bug number.

- Likewise, please add comment referring to the bug number next to the 
commented-out EXPECTED_FAILURE() for the link1 test.

- If the external1/external2 tests are working now, you should just remove the 
EXPECTED_FAILURE() lines rather than commenting them out.

FYI, for relatively trivial changes like this, I would have just made the 
corrections myself, but since the branch is owned by ~danielturcanu I couldn't 
do that...
-- 
https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86994
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~danielturcanu/zorba/xqueryx_fulltext into lp:zorba

2011-12-28 Thread Zorba Build Bot
The proposal to merge lp:~danielturcanu/zorba/xqueryx_fulltext into lp:zorba 
has been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/xqueryx_fulltext/+merge/87018
-- 
https://code.launchpad.net/~danielturcanu/zorba/xqueryx_fulltext/+merge/87018
Your team Zorba Coders is requested to review the proposed merge of 
lp:~danielturcanu/zorba/xqueryx_fulltext into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/xqueryx_fulltext into lp:zorba

2011-12-28 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1. 
Got: 1 Pending.
-- 
https://code.launchpad.net/~danielturcanu/zorba/xqueryx_fulltext/+merge/87018
Your team Zorba Coders is requested to review the proposed merge of 
lp:~danielturcanu/zorba/xqueryx_fulltext into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~danielturcanu/zorba/xqueryx_fulltext into lp:zorba

2011-12-28 Thread Zorba Build Bot
Validation queue job xqueryx_fulltext-2011-12-28T14-48-07.181Z is finished. The 
final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~danielturcanu/zorba/xqueryx_fulltext/+merge/87018
Your team Zorba Coders is requested to review the proposed merge of 
lp:~danielturcanu/zorba/xqueryx_fulltext into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~danielturcanu/zorba/xqueryx_fulltext into lp:zorba

2011-12-28 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/xqueryx_fulltext-2011-12-28T14-48-07.181Z/log.html
-- 
https://code.launchpad.net/~danielturcanu/zorba/xqueryx_fulltext/+merge/87018
Your team Zorba Coders is requested to review the proposed merge of 
lp:~danielturcanu/zorba/xqueryx_fulltext into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~danielturcanu/zorba/xqueryx_fulltext into lp:zorba

2011-12-28 Thread Daniel Turcanu
The proposal to merge lp:~danielturcanu/zorba/xqueryx_fulltext into lp:zorba 
has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/xqueryx_fulltext/+merge/87018
-- 
https://code.launchpad.net/~danielturcanu/zorba/xqueryx_fulltext/+merge/87018
Your team Zorba Coders is requested to review the proposed merge of 
lp:~danielturcanu/zorba/xqueryx_fulltext into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~danielturcanu/zorba/xqueryx_fulltext into lp:zorba

2011-12-28 Thread Daniel Turcanu
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/xqueryx_fulltext 
into lp:zorba.

Requested reviews:
  Zorba Coders (zorba-coders)

For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/xqueryx_fulltext/+merge/87018

Fixed XQueryX for full text.
Plus some other fixes for XQueryX.
-- 
https://code.launchpad.net/~danielturcanu/zorba/xqueryx_fulltext/+merge/87018
Your team Zorba Coders is requested to review the proposed merge of 
lp:~danielturcanu/zorba/xqueryx_fulltext into lp:zorba.
=== modified file 'src/compiler/xqueryx/xqueryx_to_xquery.cpp'
--- src/compiler/xqueryx/xqueryx_to_xquery.cpp	2011-09-05 20:08:30 +
+++ src/compiler/xqueryx/xqueryx_to_xquery.cpp	2011-12-28 14:47:28 +
@@ -53,7 +53,10 @@
   if(!inited)
   {
 xmlDocPtr doc;
-doc = xmlParseDoc((xmlChar*)xqueryx_update_xslt);
+std::string xqueryx_full_xslt;
+xqueryx_full_xslt += xqueryx3_0_update_xslt;
+xqueryx_full_xslt += xqueryx_fulltext_xslt;
+doc = xmlParseDoc((xmlChar*)xqueryx_full_xslt.c_str());
 
 xqueryx_xslt = (xsltStylesheet*)xsltParseStylesheetDoc(doc);
   //	xmlFreeDoc(doc);

=== modified file 'src/compiler/xqueryx/xqueryx_xslt.cpp'
--- src/compiler/xqueryx/xqueryx_xslt.cpp	2011-07-07 07:20:10 +
+++ src/compiler/xqueryx/xqueryx_xslt.cpp	2011-12-28 14:47:28 +
@@ -23,9 +23,11 @@
 
 namespace zorba {
 
-//XQueryX 3.0 (draft 14 june 2011)  http://www.w3.org/TR/xqueryx-30/#Stylesheet
+//XQueryX 3.0 (draft 13 december 2011)  http://www.w3.org/TR/xqueryx-30/#Stylesheet
+//XQueryX update 1.0
+//XQueryX full text http://www.w3.org/TR/xpath-full-text-10/#id-xqft-xqueryx
 
-const char xqueryx_update_xslt[] = 
+const char xqueryx3_0_update_xslt[] = 
 ""
 ""
 ""
@@ -75,13 +77,22 @@
 ""
 ""
 ""
+""
+""
+""
+""
+""
+""
+""
 ""
 "http://www.w3.org/1999/XSL/Transform\"";
 " xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"";
 " xmlns:xqx=\"http://www.w3.org/2005/XQueryX\"";
-" xmlns:xqxuf=\"http://www.w3.org/2007/xquery-update-10\";>"
-""
+" "
 " "
 " "
-" ,"
-""
-" '"
-" \""
+" "
+" ,"
+""
+" "
+" "
+" '"
+" "
+" "
+" \""
+" "
 " "
 " "
 " "
@@ -121,11 +140,13 @@
 " "
 " "
 " "
+" "
 " "
 " "
 " "
 " "
 " "
+" "
 " "
 " "
 " "
@@ -134,12 +155,12 @@
 " "
 " "
 " "
-"  "
+" "
 " "
-"  "
+" "
 " "
 " "
-"  "
+" "
 " "
 " "
 " "
@@ -199,8 +220,12 @@
 " 
"
 " "
 " "
-" \""
-" \"\""
+" "
+" \""
+" "
+" "
+" \"\""
+" "
 " "
 " "
 " "
@@ -280,7 +305,7 @@
 " "
 " "
 " "
-""
+" "
 " "
 " "
 " "
@@ -293,13 +318,13 @@
 " rootExpr is a stepExpr, then the parens must be"
 " omitted. -->"
 " "
-" "
+" "
 " "
 " "
 " "
 " "
 " "
-" "
+" "
 " "
 " "
 " "
@@ -333,8 +358,8 @@
 " "
 " "
 " "
-""
-""
+" "
+" "
 " "
 " "
-" Incorrect XQueryX: function calls must not use unqualified \"reserved\" name \"\""
-" "
+" "
+" Incorrect XQueryX: function calls must not use unqualified \"reserved\" name \""
+" "
+" \""
+" "
+" "
+" "
+" "
 " "
 " "
 " "
@@ -380,8 +411,12 @@
 " "
 " "
 " "
-" "
-" "
+" "
+" "
+" "
+" "
+" "
+" "
 " "
 " "
 " "
@@ -391,27 +426,60 @@
 " "
 " "
 " "
-" "
-"   "
-" "
-"  div "
-"  idiv "
-"  mod "
+" "
+" "
+" "
+" "
+"  "
+" "
+"  "
+" "
+" "
+" "
+" "
+" "
+"  div "
+" "
+" "
+"  idiv "
+" "
+" "
+"  mod "
+" "
 " "
 " "
 " "
 " "
+" "
+" "
+" "
+" "
+" "
+" "
+" "
 " "
 " "
 " "
 " "
-"  eq "
-"  ne "
-"  lt "
-"  gt "
-"  le "
-"  ge "
+" "
+"  eq "
+" "
+" "
+"  ne "
+" "
+" "
+"  lt "
+" "
+" "
+"  gt "
+" "
+" "
+"  le "
+" "
+" "
+"  ge "
+" "
 " "
 " "
 " "
@@ -422,24 +490,36 @@
 " "
 " "
 " "
-"   "
+"  "
+" "
+"  "
 " "
 " "
-"  ! "
+"  !"
+" "
+"  "
 " "
 " "
-"   "
+"  "
+" "
+"  "
 " "
 " "
-"   "
+"  "
+" "
+"  "
 " "
 " "
-"  "
-"  "
+"  "
+" "
+" "
+"  "
 " "
 " "
-"  "
-"  "
+"  "
+" "
+" "
+"  "
 " "
 " "
 " "
@@ -449,13 +529,21 @@
 " "
 " "
 " "
-"  is "
-"  "
-" "
-"  "
-"  "
-" "
-"  "
+" "
+"  is "
+" "
+" "
+"  "
+" "
+" "
+"  "
+" "
+" "
+"  "
+" "
+" "
+"  "
+" "
 " "
 " "
 " "
@@ -464,8 +552,12 @@
 " "
 " "
 " "
-"  and "
-"  or "
+" "
+"  and "
+" "
+" "
+"  or "
+" "
 " "
 " "
 " "
@@ -474,9 +566,15 @@
 " "
 " "
 " "
-"  union "
-"  intersect "
-"  except "
+" "
+"  union "
+" "
+" "
+"  intersect "
+" "
+" "
+"  except "
+" "
 " "
 " "
 " "
@@ -520,7 +618,9 @@
 " "
 " "
 " "
+" "
 " "
+" "
 " "
 " "
 " "
@@ -609,6 +709,16 @@
 " "
 " "
 " "
+" "
+" "
+" "
+" "
+" "
+" "
+" "
+" "
+" "
+" "
 " "
 "  collation "
 " "
@@ -650,7 +760,7 @@
 " "
 " "
 " "
-""
+" "
 " "
 " "
 " "
@@ -758,10 +868,11 @@
 " "
 " "
 " "
+" "
 " "
 "  case "
 " "
-" "
+" "
 "  return "
 " "
 " "
@@ -898,7 +1009,7 @@
 " "
 " "
 " "
-""
+" "
 " "
 " "
 " "
@@ -927,7 +1038,7 @@
 " "
 " "
 " "
-""
+" "
 " "
 " "
 " "
@@ -991,19 +1102,28 @@
 "  ) "
 " "
 " "
+" "
 " "
-" "
+" "
 " "
 " "
 " "
 " "
+" "
+" "
+" "
+" "
+" "
+" "
+" "
 " "
 " "
 " "
 " "
 " "
 " "
-" "
+" "
+" "
 " "
-" Incorrect XQueryX: function calls must not use unqualified \"reserved\" name \"\""
-" "
+" "
+" Incorrect XQueryX: function calls must not use unqualified \"reserved\" name \""
+" "
+" \""
+" "

[Zorba-coders] [Bug 909375] [NEW] some XQueryX full text test fail because of wrong spec file

2011-12-28 Thread Daniel Turcanu
Public bug reported:

Some XQueryX test from w3c_full_text_testsuite fail because their spec file is 
not generated as the XQuery analog.
All those tests use a stop word list from a URL which should be redirected to a 
local file. The spec file for the XQueryX test does not contain that 
redirection.
The tests that fail are:

22310:test/rbkt/w3c_full_text_testsuite/XQueryX/Examples/3.4.7-StopWordOption/ft-5.2.11-examples-q4
22311:test/rbkt/w3c_full_text_testsuite/XQueryX/Examples/3.4.7-StopWordOption/ft-5.2.11-examples-q5
22608:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-3.4.7-expressions-q4
22609:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-3.4.7-expressions-q5
22610:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-3.4.7-expressions-q6
22612:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-3.4.7-expressions-q8
22613:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-3.4.7-expressions-q9
22615:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-5.2.11-expressions-q2
22617:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-5.2.11-expressions-q4
22618:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-5.2.11-expressions-q5
22619:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-5.2.11-expressions-q6
22620:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-5.2.11-expressions-q7
22621:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-5.2.11-expressions-q8
22622:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-5.2.11-expressions-q9
22898:test/rbkt/w3c_full_text_testsuite/XQueryX/UseCase/UseCase-STOP-WORD/stop-word-queries-results-q1
22899:test/rbkt/w3c_full_text_testsuite/XQueryX/UseCase/UseCase-STOP-WORD/stop-word-queries-results-q1b
22902:test/rbkt/w3c_full_text_testsuite/XQueryX/UseCase/UseCase-STOP-WORD/stop-word-queries-results-q3
22903:test/rbkt/w3c_full_text_testsuite/XQueryX/UseCase/UseCase-STOP-WORD/stop-word-queries-results-q3b

** Affects: zorba
 Importance: Medium
 Assignee: Sorin Marian Nasoi (sorin.marian.nasoi)
 Status: New

-- 
You received this bug notification because you are a member of Zorba
Coders, which is the registrant for Zorba.
https://bugs.launchpad.net/bugs/909375

Title:
  some XQueryX full text test fail because of wrong spec file

Status in Zorba - The XQuery Processor:
  New

Bug description:
  Some XQueryX test from w3c_full_text_testsuite fail because their spec file 
is not generated as the XQuery analog.
  All those tests use a stop word list from a URL which should be redirected to 
a local file. The spec file for the XQueryX test does not contain that 
redirection.
  The tests that fail are:

  
22310:test/rbkt/w3c_full_text_testsuite/XQueryX/Examples/3.4.7-StopWordOption/ft-5.2.11-examples-q4
  
22311:test/rbkt/w3c_full_text_testsuite/XQueryX/Examples/3.4.7-StopWordOption/ft-5.2.11-examples-q5
  
22608:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-3.4.7-expressions-q4
  
22609:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-3.4.7-expressions-q5
  
22610:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-3.4.7-expressions-q6
  
22612:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-3.4.7-expressions-q8
  
22613:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-3.4.7-expressions-q9
  
22615:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-5.2.11-expressions-q2
  
22617:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-5.2.11-expressions-q4
  
22618:test/rbkt/w3c_full_text_testsuite/XQueryX/Expressions/Operators/CompExpr/FTContainsExpr/FTSelection/MatchOptions/FTStopWord/ft-5.2.11-expressions-q5
  
22619:test/r

[Zorba-coders] [Bug 909303] Re: test w3c_testsuite/XQueryX/Construct/DirectConElem/DirectConElemContent/K2-DirectConElemContent-27.xqx fails

2011-12-28 Thread Daniel Turcanu
In the same category of failure is the test 
w3c_testsuite/XQueryX/Construct/DirectConElem/DirectConElemWhitespace/K2-DirectConElemWhitespace-25.xqx
Again there are strange duplicates of text nodes in the element string value.

-- 
You received this bug notification because you are a member of Zorba
Coders, which is the registrant for Zorba.
https://bugs.launchpad.net/bugs/909303

Title:
  test
  
w3c_testsuite/XQueryX/Construct/DirectConElem/DirectConElemContent/K2-DirectConElemContent-27.xqx
  fails

Status in Zorba - The XQuery Processor:
  New

Bug description:
  The XQueryX version of the test K2-DirectConElemContent-27 fails, because the 
result is different than expected.
  The code is translated to xquery as:

  (string({  text {"str" } }{ "str" }{  text {"str" } }{  text {"str" } }{
  text {"str" } }{ "strstr" }{ ("str","str","strstr","str") }{ "strstr" }{  
text {
  "str" } }{ "s" }{  processing-instruction target{"str"} }{ "tr" }) eq 
"st
  rstrstrstrstrstrstrstr str strstr strstrstrstrstr")

  which is equivalent to the XQuery test, but the result is different.
  The first word of the result contains 10 "str" instead of 8 "str", so 
probably there is a bug in the text node constructor.

To manage notifications about this bug go to:
https://bugs.launchpad.net/zorba/+bug/909303/+subscriptions

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Bug 909303] [NEW] test w3c_testsuite/XQueryX/Construct/DirectConElem/DirectConElemContent/K2-DirectConElemContent-27.xqx fails

2011-12-28 Thread Daniel Turcanu
Public bug reported:

The XQueryX version of the test K2-DirectConElemContent-27 fails, because the 
result is different than expected.
The code is translated to xquery as:

(string({  text {"str" } }{ "str" }{  text {"str" } }{  text {"str" } }{
text {"str" } }{ "strstr" }{ ("str","str","strstr","str") }{ "strstr" }{  text {
"str" } }{ "s" }{  processing-instruction target{"str"} }{ "tr" }) eq "st
rstrstrstrstrstrstrstr str strstr strstrstrstrstr")

which is equivalent to the XQuery test, but the result is different.
The first word of the result contains 10 "str" instead of 8 "str", so probably 
there is a bug in the text node constructor.

** Affects: zorba
 Importance: High
 Assignee: Markos Zaharioudakis (markos-za)
 Status: New

-- 
You received this bug notification because you are a member of Zorba
Coders, which is the registrant for Zorba.
https://bugs.launchpad.net/bugs/909303

Title:
  test
  
w3c_testsuite/XQueryX/Construct/DirectConElem/DirectConElemContent/K2-DirectConElemContent-27.xqx
  fails

Status in Zorba - The XQuery Processor:
  New

Bug description:
  The XQueryX version of the test K2-DirectConElemContent-27 fails, because the 
result is different than expected.
  The code is translated to xquery as:

  (string({  text {"str" } }{ "str" }{  text {"str" } }{  text {"str" } }{
  text {"str" } }{ "strstr" }{ ("str","str","strstr","str") }{ "strstr" }{  
text {
  "str" } }{ "s" }{  processing-instruction target{"str"} }{ "tr" }) eq 
"st
  rstrstrstrstrstrstrstr str strstr strstrstrstrstr")

  which is equivalent to the XQuery test, but the result is different.
  The first word of the result contains 10 "str" instead of 8 "str", so 
probably there is a bug in the text node constructor.

To manage notifications about this bug go to:
https://bugs.launchpad.net/zorba/+bug/909303/+subscriptions

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-28 Thread Daniel Turcanu
Review: Approve

+one
-- 
https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86959
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba

2011-12-28 Thread Daniel Turcanu
The proposal to merge lp:~danielturcanu/zorba/link1_fix into lp:zorba has been 
updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86994
-- 
https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86994
Your team Zorba Coders is requested to review the proposed merge of 
lp:~danielturcanu/zorba/link1_fix into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba

2011-12-28 Thread Daniel Turcanu
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/link1_fix into 
lp:zorba.

Requested reviews:
  Zorba Coders (zorba-coders)

For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86994

Removed test versioning/link1 to avoid bug 908062 on Windows
-- 
https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86994
Your team Zorba Coders is requested to review the proposed merge of 
lp:~danielturcanu/zorba/link1_fix into lp:zorba.
=== modified file 'test/rbkt/Queries/CMakeLists.txt'
--- test/rbkt/Queries/CMakeLists.txt	2011-12-22 20:34:53 +
+++ test/rbkt/Queries/CMakeLists.txt	2011-12-28 09:05:31 +
@@ -168,6 +168,11 @@
   SET (SKIP_TEST 1)
 ENDIF (NEEDS_FULL_TEXT)
   ENDIF (ZORBA_NO_FULL_TEXT)
+  IF(WIN32)
+IF(${TESTNAME} MATCHES "test/rbkt/zorba/versioning/link1")
+  SET(SKIP_TEST 1)
+ENDIF(${TESTNAME} MATCHES "test/rbkt/zorba/versioning/link1")
+  ENDIF(WIN32)
 
   # If WordNet thesaurus not found, skip ft-thesaurus-true tests
   IF (NOT ZORBA_WORDNET_FOUND)
@@ -260,10 +265,11 @@
 ENDIF(XVERMAJ EQUAL 2)
 
 IF(WIN32)
-  EXPECTED_FAILURE(test/rbkt/zorba/versioning/external1 870991)
-  EXPECTED_FAILURE(test/rbkt/zorba/versioning/external2 870991)
+  #these tests now work on Windows
+  #EXPECTED_FAILURE(test/rbkt/zorba/versioning/external1 870991)
+  #EXPECTED_FAILURE(test/rbkt/zorba/versioning/external2 870991)
 
-  EXPECTED_FAILURE(test/rbkt/zorba/versioning/link1 871061)
+  #EXPECTED_FAILURE(test/rbkt/zorba/versioning/link1 871061)
 
   # this is still an expected failure but has been commented out since the
   # test is now completely disabled because of bug 871335

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba

2011-12-28 Thread Zorba Build Bot
The proposal to merge lp:~danielturcanu/zorba/link1_fix into lp:zorba has been 
updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86960
-- 
https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86960
Your team Zorba Coders is requested to review the proposed merge of 
lp:~danielturcanu/zorba/link1_fix into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba

2011-12-28 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please 
seek review and approval of these new revisions.
-- 
https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86960
Your team Zorba Coders is requested to review the proposed merge of 
lp:~danielturcanu/zorba/link1_fix into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp