[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba

2013-07-17 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-csv/+merge/175208 https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-archive/+merge/175215 https://code.launchp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-nosql into lp:zorba/oracle-nosql-db-module

2013-07-17 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-nosql/+merge/175214 Your team Zorba Coders is subscribed to branch lp:zorba/oracle-nosql-db-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : ht

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-nosql into lp:zorba/oracle-nosql-db-module

2013-07-17 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1189785-nosql into lp:zorba/oracle-nosql-db-module. Commit message: Updated for new base64 module namespace URI. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba

2013-07-17 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-csv/+merge/175208 https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-archive/+merge/175212 For more details,

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-archive into lp:zorba

2013-07-17 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-archive/+merge/175212 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-csv into lp:zorba/csv-module

2013-07-17 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-csv/+merge/175208 Your team Zorba Coders is subscribed to branch lp:zorba/csv-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpa

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba

2013-07-17 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-csv/+merge/175208 For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-core/+merge/175204

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-csv into lp:zorba/csv-module

2013-07-17 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189785-csv into lp:zorba/csv-module has been updated. Commit Message changed to: Updated to new base64 module URI. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-csv/+merge/175208 -- https://code.launchpad.net

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-csv into lp:zorba/csv-module

2013-07-17 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1189785-csv into lp:zorba/csv-module. Commit message: Updated to new base64 module URI. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-csv/+merge

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba

2013-07-17 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-core/+merge/175204 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zor

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba

2013-07-17 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/csv-module/+merge/175205 For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-core/+merge/175204 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba

2013-07-17 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba. Commit message: Update base64 module to Zorba 3.0 standards. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-core/+merge

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba

2013-07-17 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.n

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module

2013-07-16 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module has been updated. Description changed to: Might as well bring in https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553 too. For more details, see: https://code.launchpad.net/~zorba-coders/zor

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module

2013-07-16 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module has been updated. Description changed to: Depends on https://code.launchpad.net/~zorba-coders/zorba/xqdoc-private-variables/+merge/175166, and might as well bring in https://code.launchpad.net/~zorba-coders/zo

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188061 into lp:zorba/stack-module

2013-07-16 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1188061 into lp:zorba/stack-module has been updated. Commit Message changed to: Update to 3.0 module guidelines; make JSON-ready. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553 -- https://code.lau

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module

2013-07-16 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module has been updated. Commit Message changed to: Update to 3.0 module guidelines; make JSON-ready. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1188062/+merge/169946 -- https://code.lau

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqdoc-private-variables into lp:zorba

2013-07-16 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/xqdoc-private-variables into lp:zorba has been updated. Commit Message changed to: Don't check %private variables. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/xqdoc-private-variables/+merge/175166 -- https://code.launchpad.

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module

2013-07-16 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/xqdoc-private-variables/+merge/175166 For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1188062/+m

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module

2013-07-16 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1188062/+merge/169946 Your team Zorba Coders is subscribed to branch lp:zorba/queue-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188061 into lp:zorba/stack-module

2013-07-16 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553 Your team Zorba Coders is subscribed to branch lp:zorba/stack-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqdoc-private-variables into lp:zorba

2013-07-16 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/xqdoc-private-variables/+merge/175166 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.n

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqdoc-private-variables into lp:zorba

2013-07-16 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/xqdoc-private-variables into lp:zorba. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/xqdoc-private-variables/+merge/175166 Don't check %private vari

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/win64-build into lp:zorba

2013-07-15 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/win64-build/+merge/174890 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/win64-build into lp:zorba

2013-07-15 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/win64-build into lp:zorba. Requested reviews: Zorba Coders (zorba-coders) Related bugs: Bug #1151966 in Zorba: "64-bit support on Windows" https://bugs.launchpad.net/zorba/+bug/1151966 For more details,

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1187813 into lp:zorba

2013-07-12 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1187813/+merge/174359 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump_QT_snapshot into lp:zorba

2013-07-12 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bump_QT_snapshot/+merge/174341 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zor

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-2.9 into lp:zorba

2013-07-11 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/zorba-2.9 into lp:zorba. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/zorba-2.9/+merge/174123 -- https://code.launchpad.net/~zorba-coders/zorba/zorba-2.9/+merge

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-test-iterplan into lp:zorba

2013-07-11 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/move-test-iterplan into lp:zorba has been updated. Commit Message changed to: Moved iterplan tests and tools under test/iterplan. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/move-test-iterplan/+merge/174120 -- https://code.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-test-iterplan into lp:zorba

2013-07-11 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/move-test-iterplan/+merge/174120 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~z

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-test-iterplan into lp:zorba

2013-07-10 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/move-test-iterplan into lp:zorba. Commit message: Moved iterplan tests and tools under test/iterplan. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/move-test-iterplan

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-basename-tests into lp:zorba

2013-07-10 Thread Chris Hillery
Juan - please verify that this doesn't break things on Windows; just build and run "ctest -R dirname_basename". -- https://code.launchpad.net/~zorba-coders/zorba/fix-basename-tests/+merge/174117 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zor

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-basename-tests into lp:zorba

2013-07-10 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix-basename-tests into lp:zorba has been updated. Commit Message changed to: Remove "system" module dependency from core tests. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-basename-tests/+merge/174117 -- https://code.l

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-basename-tests into lp:zorba

2013-07-10 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-basename-tests/+merge/174117 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~z

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-basename-tests into lp:zorba

2013-07-10 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/fix-basename-tests into lp:zorba. Commit message: Remove "system" module dependency from core tests. Requested reviews: Juan Zacarias (juan457) Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zo

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189786-json-update into lp:zorba

2013-07-10 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189786-json-update into lp:zorba has been updated. Commit Message changed to: Update "JSON" module: now known as "json-xml", function names changed, namespace changed to zorba.io, moved out of unnecessary subdirectories. For more details, see:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189786-json-update into lp:zorba

2013-07-10 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189786-json-update/+merge/174085 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.n

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188052-oauth-update into lp:zorba/oauth-module

2013-07-10 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1188052-oauth-update into lp:zorba/oauth-module. Requested reviews: Zorba Coders (zorba-coders) Related bugs: Bug #1188052 in Zorba: "Update non-core module "oauth"" https://bugs.launchpad.net/zorba/+b

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module

2013-07-09 Thread Chris Hillery
One note: we cannot JSONify the geo module [can we?], since it is an EXPath module. There are no common APIs or schemas between geo and geoproj so far as I know, but they might be used by similar people. So, might it be weird if one is XML and one is JSON? Not really sure how to make that call.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module

2013-07-09 Thread Chris Hillery
Review: Approve Approving the changes as they are. Matthias, let us know if you think it should JSONified immediately or if we can come back to it. -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214 Your team Zorba Coders is subscribed to branch lp:zorba/geo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geo-module into lp:zorba/geo-module

2013-07-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212 Your team Zorba Coders is subscribed to branch lp:zorba/geo-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://lau

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_data-cleaning-module into lp:zorba/data-cleaning-module

2013-07-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsub

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba

2013-07-09 Thread Chris Hillery
Discussed with Juan - the is-seekable() function should be easy enough to add, so sure, let's do it. -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-cod

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-07-09 Thread Chris Hillery
Review: Needs Fixing 1. OMG code duplication: the entire contents of http-client.xq.src is copied (and modified?) from the original http-client module. That's nearly 3000 lines of some of the ugliest and most error-filled code we've got. No way do we want to maintain two copies of it. Also, the

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1151967 into lp:zorba

2013-07-09 Thread Chris Hillery
Oops, forgot to comment: 1. Need to fix merge conflict. 2. There are some code changes in here as well. I assume they are the "Removing some warnings" comment? If so, please mention that in the commit message for this proposal, along with the main changes. -- https://code.launchpad.net/~zorba-

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1151967 into lp:zorba

2013-07-09 Thread Chris Hillery
Review: Needs Fixing -- https://code.launchpad.net/~zorba-coders/zorba/bug1151967/+merge/162905 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_examples_XQDoc into lp:zorba

2013-07-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_examples_XQDoc/+merge/170878 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~z

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_node-position-module into lp:zorba

2013-07-09 Thread Chris Hillery
Review: Approve I changed the module version declaration back to "xquery version "1.0"". It seemed weird to have it claim to be "jsoniq" when the module is only dealing with XML nodes. I also added a copyright notice to modules/nodes/CMakeLists.txt. Other than that looked fine. -- https://code

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_info-extraction-module into lp:zorba/info-extraction-module

2013-07-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_info-extraction-module/+merge/170463 Your team Zorba Coders is subscribed to branch lp:zorba/info-extraction-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net U

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install_mysql_update into lp:zorba/jdbc-module

2013-07-09 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/install_mysql_update into lp:zorba/jdbc-module has been updated. Commit Message changed to: Update test-setup script to MySQL 5.6; don't download Connector jar; cleanup. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/install_my

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module

2013-07-09 Thread Chris Hillery
Review: Needs Information The changes as made seem fine. Two concerns: 1. Are there any errors raised by the module functions? If so, are they documented? 2. Matthias: This seems like it is an ideal candidate for JSONify-ing; would you agree? If so, what would you think is the priority? I'm te

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geo-module into lp:zorba/geo-module

2013-07-09 Thread Chris Hillery
Review: Needs Fixing 1. Very sorry for the mis-information, but this module should NOT have been moved into the zorba.io namespace. EXpath modules should remain in their expath.org/ns namespace. 2. Remove the "how to build the module" information from the XQDoc; XQDoc should only contain infor

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/http-client-based-on-json-http-client into lp:zorba/http-client-module

2013-07-09 Thread Chris Hillery
Review: Needs Information 1. Do we need to promote this to version 2.0 of the EXpath module? Isn't the public API exactly the same, as defined by EXpath? I understand the implementation is different, but I don't believe that's relevant for module versioning. 2. (Possibly the same question) Do

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188061 into lp:zorba/stack-module

2013-07-09 Thread Chris Hillery
Review: Needs Fixing Basically the same comments as the queue proposal: 1. Make the error QName variables %private; 2. Fix or eliminate the XQDoc for the error QNames; 3. Replace "node" with "item" in function XQDoc. In addition: 4. You have a stray at the beginning of the header XQDoc comment

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module

2013-07-09 Thread Chris Hillery
Review: Needs Fixing 1. Error QNames should not be declared as public constants (see coding guidelines). Declare them as private variables as follows: declare %private variable $queue:NOT-EXISTS as xs:QName := fn:QName($queue:ERR-NS, "queue:NOT-EXISTS"); 2. The current XQDoc for those error QN

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_datetime-module into lp:zorba

2013-07-02 Thread Chris Hillery
Review: Needs Fixing Error codes need updating. Rest of the changes look good. -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_datetime-module/+merge/172685 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zo

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-trunk into lp:zorba

2013-07-01 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/dummy-trunk into lp:zorba has been updated. Description changed to: This change depends on https://code.launchpad.net/~zorba-coders/zorba/dummy-security-module/+merge/172448. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/dumm

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-trunk into lp:zorba

2013-07-01 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/dummy-trunk/+merge/172447 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-security-module into lp:zorba/security-module

2013-07-01 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/dummy-security-module/+merge/172448 Your team Zorba Coders is subscribed to branch lp:zorba/security-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-security-module into lp:zorba/security-module

2013-07-01 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/dummy-security-module into lp:zorba/security-module. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/dummy-security-module/+merge/172448 -- https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-trunk into lp:zorba

2013-07-01 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/dummy-trunk into lp:zorba. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/dummy-trunk/+merge/172447 This change depends on https://code.launchpad.net/~zorba-coders

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/broken-security-test into lp:zorba/security-module

2013-07-01 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/broken-security-test into lp:zorba/security-module. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/broken-security-test/+merge/172439 -- https://code.launchpad.net

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/broken-test into lp:zorba

2013-07-01 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/broken-test into lp:zorba has been updated. Description changed to: This change depends on https://code.launchpad.net/~zorba-coders/zorba/broken-security-test/+merge/172439. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/broke

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/broken-code into lp:zorba

2013-07-01 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/broken-code into lp:zorba has been updated. Description changed to: For more details, see: https://code.launchpad.net/~zorba-coders/zorba/broken-code/+merge/172435 -- https://code.launchpad.net/~zorba-coders/zorba/broken-code/+merge/172435 Your tea

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/broken-code into lp:zorba

2013-07-01 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/broken-code into lp:zorba has been updated. Description changed to: This commit also requires merging https://code.launchpad.net/~zorba-coders/zorba/broken-test/+merge/172436. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bro

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/broken-code into lp:zorba

2013-07-01 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/broken-code into lp:zorba has been updated. Description changed to: This commit also requires merging https://code.launchpad.net/~zorba-coders/zorba/broken-test/+merge/172436 . For more details, see: https://code.launchpad.net/~zorba-coders/zorba/br

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/broken-test into lp:zorba

2013-07-01 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/broken-test into lp:zorba. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/broken-test/+merge/172436 -- https://code.launchpad.net/~zorba-coders/zorba/broken-test

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/broken-code into lp:zorba

2013-07-01 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/broken-code into lp:zorba. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/broken-code/+merge/172435 This commit also requires merging https://code.launchpad.net

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fake-change into lp:zorba

2013-06-30 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fake-change into lp:zorba has been updated. Status: Approved => Work in progress For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fake-change/+merge/172254 -- https://code.launchpad.net/~zorba-coders/zorba/fake-change/+merge/

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fake-change into lp:zorba

2013-06-30 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fake-change into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fake-change/+merge/172254 -- https://code.launchpad.net/~zorba-coders/zorba/fake-change/+merge/1722

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fake-change into lp:zorba

2013-06-30 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fake-change into lp:zorba has been updated. Commit Message changed to: Fake For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fake-change/+merge/172254 -- https://code.launchpad.net/~zorba-coders/zorba/fake-change/+merge/172254 Y

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fake-change into lp:zorba

2013-06-30 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/fake-change into lp:zorba. Commit message: Fake Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fake-change/+merge/172254 -- https://code.launchpad.net/~zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-read-pdf into lp:zorba/read-pdf-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-read-pdf/+merge/170949 Your team Zorba Coders is subscribed to branch lp:zorba/read-pdf-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-archive into lp:zorba/archive-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-archive/+merge/170943 Your team Zorba Coders is subscribed to branch lp:zorba/archive-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-data-formatting into lp:zorba/data-formatting-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-data-formatting/+merge/170944 Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubs

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-oracle-nosql-db into lp:zorba/oracle-nosql-db-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-oracle-nosql-db/+merge/170948 Your team Zorba Coders is subscribed to branch lp:zorba/oracle-nosql-db-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubs

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-geo into lp:zorba/geo-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-geo/+merge/170945 Your team Zorba Coders is subscribed to branch lp:zorba/geo-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpa

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-security into lp:zorba/security-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-security/+merge/170950 Your team Zorba Coders is subscribed to branch lp:zorba/security-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-couchbase into lp:zorba/couchbase-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-couchbase/+merge/170951 Your team Zorba Coders is subscribed to branch lp:zorba/couchbase-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : http

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-sqlite into lp:zorba/sqlite-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-sqlite/+merge/170953 Your team Zorba Coders is subscribed to branch lp:zorba/sqlite-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://la

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-jdbc into lp:zorba/jdbc-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-jdbc/+merge/170947 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launch

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-image into lp:zorba/image-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-image/+merge/170946 Your team Zorba Coders is subscribed to branch lp:zorba/image-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://laun

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052 into lp:zorba

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1158052 into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-read-pdf/+merge/170949 https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-oracle-nosql-db/+merge/170948 https://code

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052 into lp:zorba

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052/+merge/170725 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052 into lp:zorba

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1158052 into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-read-pdf/+merge/170949 https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-oracle-nosql-db/+merge/170948 https://

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:zorba

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/new-rq-fots into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171053 -- https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/1710

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189798-queue into lp:zorba/queue-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189798-queue/+merge/171309 Your team Zorba Coders is subscribed to branch lp:zorba/queue-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://laun

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189798 into lp:zorba

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189798/+merge/171183 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189798 into lp:zorba

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189798 into lp:zorba has been updated. Description changed to: Relocated and renamed Zorba errors & warnings "modules." This merge must be performed at the same time as https://code.launchpad.net/~zorba-coders/zorba/bug-1189798-stack/+merge/171

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189798-stack into lp:zorba/stack-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189798-stack/+merge/171308 Your team Zorba Coders is subscribed to branch lp:zorba/stack-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://laun

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:zorba

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/new-rq-fots into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171053 -- https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/1710

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:zorba/data-cleaning-module

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:zorba/data-cleaning-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/data-cleaning-missing-functions/+merge/171040 -- https://c

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:zorba/info-extraction-module

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:zorba/info-extraction-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/info-extraction-yahoo-broken/+merge/171046 -- https://code.

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:zorba/info-extraction-module

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:zorba/info-extraction-module has been updated. Commit Message changed to: Added EXPECTED_FAILURE() for test broken by missing Yahoo functionality. For more details, see: https://code.launchpad.net/~zorba-coders/zo

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:zorba/data-cleaning-module

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:zorba/data-cleaning-module has been updated. Commit Message changed to: Added EXPECTED_FAILURE()s for tests that appear to depend on webservices that no longer exist. For more details, see: https://code.launch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:zorba

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/new-rq-fots into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171053 -- https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/1710

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:~zorba-coders/zorba/test-trunk

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/new-rq-fots into lp:~zorba-coders/zorba/test-trunk has been updated. Status: Merged => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171250 -- https://code.launchpad.net/~zorba-coders/zorba/

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:~zorba-coders/zorba/test-trunk

2013-06-26 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171250 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/test-trunk. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:~zorba-coders/zorba/test-info-extraction-module

2013-06-26 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/info-extraction-yahoo-broken/+merge/171248 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/test-info-extraction-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:~zorba-coders/zorba/test-data-cleaning-module

2013-06-26 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/data-cleaning-missing-functions/+merge/171249 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/test-data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@list

<    1   2   3   4   5   6   7   8   9   10   >