Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_data-cleaning-module into lp:zorba/data-cleaning-module

2013-07-17 Thread Bruno Martins
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-soundex_key into lp:zorba/data-cleaning-module

2013-05-21 Thread Bruno Martins
Review: Approve The previous version of the soundex-key function had indeed a problem with the string 3-D Adventure, returning a stack overflow since it as recursively trying to produce a soundex key with just 4 characters. The new implementation fixes this, and also seems to be correct.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-info-extraction-module into lp:zorba

2012-12-28 Thread Bruno Martins
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/add-info-extraction-module/+merge/141245 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-info-extraction-module into lp:zorba

2012-12-26 Thread Bruno Martins
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/add-info-extraction-module/+merge/141245 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~diogo-simoes89/zorba/DC-documentation into lp:zorba/data-cleaning-module

2012-04-29 Thread Bruno Martins
Review: Approve -- https://code.launchpad.net/~diogo-simoes89/zorba/DC-documentation/+merge/103902 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~diogo-simoes89/zorba/data-cleaning-thesaurus into lp:zorba/data-cleaning-module

2012-04-18 Thread Bruno Martins
The proposal to merge lp:~diogo-simoes89/zorba/data-cleaning-thesaurus into lp:zorba/data-cleaning-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~diogo-simoes89/zorba/data-cleaning-thesaurus/+merge/100683 --

[Zorba-coders] [Merge] lp:~diogo-simoes89/zorba/data-cleaning-thesaurus into lp:zorba/data-cleaning-module

2012-04-16 Thread Bruno Martins
The proposal to merge lp:~diogo-simoes89/zorba/data-cleaning-thesaurus into lp:zorba/data-cleaning-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~diogo-simoes89/zorba/data-cleaning-thesaurus/+merge/100683 --

[Zorba-coders] [Merge] lp:~diogo-simoes89/zorba/data-cleaning-thesaurus into lp:zorba/data-cleaning-module

2012-04-11 Thread Bruno Martins
The proposal to merge lp:~diogo-simoes89/zorba/data-cleaning-thesaurus into lp:zorba/data-cleaning-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~diogo-simoes89/zorba/data-cleaning-thesaurus/+merge/100683 --

[Zorba-coders] [Merge] lp:~diogo-simoes89/zorba/data-cleaning-thesaurus into lp:zorba/data-cleaning-module

2012-04-04 Thread Bruno Martins
The proposal to merge lp:~diogo-simoes89/zorba/data-cleaning-thesaurus into lp:zorba/data-cleaning-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~diogo-simoes89/zorba/data-cleaning-thesaurus/+merge/100683 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/data-cleaning-release into lp:zorba

2012-02-23 Thread Bruno Martins
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/data-cleaning-release/+merge/94461 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~diogo-simoes89/zorba/DC-conversion-tests into lp:zorba/data-cleaning-module

2012-02-22 Thread Bruno Martins
Review: Approve -- https://code.launchpad.net/~diogo-simoes89/zorba/DC-conversion-tests/+merge/91599 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~diogo-simoes89/zorba/data-cleaning into lp:zorba/data-cleaning-module

2011-11-24 Thread Bruno Martins
The proposal to merge lp:~diogo-simoes89/zorba/data-cleaning into lp:zorba/data-cleaning-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~diogo-simoes89/zorba/data-cleaning/+merge/79530 --

Re: [Zorba-coders] [Merge] lp:~diogo-simoes89/zorba/data-cleaning into lp:zorba/data-cleaning-module

2011-11-10 Thread Bruno Martins
Review: Approve Checked the latest revisions from Diogo and they seem ok. -- https://code.launchpad.net/~diogo-simoes89/zorba/data-cleaning/+merge/79530 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to

Re: [Zorba-coders] [Merge] lp:~diogo-simoes89/zorba/data-cleaning into lp:zorba/data-cleaning-module

2011-10-24 Thread Bruno Martins
Review: Needs Fixing Some minor things that should be changed before approving the merge: * The documentation for functions like conversion:address-from-phone, conversion:user-from-phone and conversion:address-from-user should be revised, in order to keep just one example (i.e., the one from