Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1100471-2013-04-24T17-04-59.855Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job bug1100471-2013-04-24T17-04-59.855Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Line 73 in the diff is not a logically equivalent change. You should seek
approval from whoever's code that is. I'll approve if that person approves.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
Rodolfo Ochoa has proposed merging lp:~zorba-coders/zorba/bug1100471 into
lp:zorba.
Commit message:
Solving windows warnings
Requested reviews:
Paul J. Lucas (paul-lucas)
Related bugs:
Bug #1100471 in Zorba: Warnings on Windows
https://bugs.launchpad.net/zorba/+bug/1100471
For more
I corrected all size_types
only one warning couldn't solve, I don't know how to solve this:
1c:\dev\bug1100471\src\zorbatypes\integer.h(916): warning C4146: unary minus
operator applied to unsigned type, result still unsigned
(..\..\src\zorbatypes\integer.cpp)
1
The proposal to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba has been
updated.
Commit Message changed to:
Solving windows warnings
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239
--
https://code.launchpad.net/~zorba-coders/zorba
Review: Needs Fixing
You don't hack the parser.cpp or lexer.cpp files directly. Please revert ALL
changes to those files and modify the .y or .l files ONLY. If the warnings
still persist in those files due to generated code, it's simply too bad.
In general, you don't need to fully qualify
Done!
I have made all the changes you observed.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
213,222,231,240,243,252: should be cast to Members::size_type.
296,297: Should be vectorchar::size_type (why are you obsessing over
std::string::size_type?)
310,319,332: Should be cast to checked_vectorstore::Item_t::size_type not
size_t.
358,367,393,403,404,417: Cast to wrong type.
It seems
Review: Needs Fixing
In several cases where you added casts, you cast to the wrong type, e.g., the
wrong size_type or something that should have been size_t. The only reason it
got rid of the warnings in those cases is because the wrong type and the
correct type just so happened to be the
The proposal to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Attempt to merge into lp:zorba failed due to conflicts:
text conflict in src/store/naive/simple_store.cpp
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
The proposal to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
The proposal to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1100471-2013-01-24T23-20-44.442Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job bug1100471-2013-01-24T23-20-44.442Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
I'd actually prefer Paul to look at these, since he's the C++ guru and can
hopefully say if there are any gotchas.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Fixed the RQ problems, trying again.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The attempt to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug1100471-2013-01-21T09-24-43.929Z is finished. The
final
The proposal to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Rodolfo Ochoa has proposed merging lp:~zorba-coders/zorba/bug1100471 into
lp:zorba.
Requested reviews:
Rodolfo Ochoa (rodolfo-ochoa)
Related bugs:
Bug #1100471 in Zorba: Warnings on Windows
https://bugs.launchpad.net/zorba/+bug/1100471
For more details, see:
The proposal to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba has been
updated.
Commit Message changed to:
Lots of warnings from windows fixed
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
--
https://code.launchpad.net/~zorba-coders
The proposal to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1100471-2013-01-20T21-18-47.689Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The attempt to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug1100471-2013-01-20T21-18-47.689Z is finished. The
final
The proposal to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Rodolfo Ochoa has proposed merging lp:~zorba-coders/zorba/bug1100471 into
lp:zorba.
Requested reviews:
Rodolfo Ochoa (rodolfo-ochoa)
Related bugs:
Bug #1100471 in Zorba: Warnings on Windows
https://bugs.launchpad.net/zorba/+bug/1100471
For more details, see:
The proposal to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/143997
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/143997
The proposal to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba has been
updated.
Commit Message changed to:
Fix for Windows bugs and locale compilation error
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/143997
--
https://code.launchpad.net
The proposal to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/143997
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/143997
The proposal to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/143997
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/143997
The attempt to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug1100471-2013-01-20T00-03-03.437Z is finished. The
final
The proposal to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/143997
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/143997
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1100471-2013-01-20T00-03-03.437Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/143997
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
40 matches
Mail list logo
