Review: Approve
--
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.ne
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1.
Got: 1 Approve, 1 Needs Information.
--
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad
>Looks good in general. Only tried compiling so far but didn't install. I would
>suggest that at
> least somebody with Windows also tries it.
I built and tested (and even debugged) it on Windows, and at least my own test
cases worked fine.
> Minor comments:
> - theURIPath (good name?); theXQPa
Review: Needs Information
Looks good in general. Only tried compiling so far but didn't install. I would
suggest that at least somebody with Windows also tries it.
Minor comments:
- theURIPath (good name?); theXQPath?
- setLibPath or setLibPaths in the public api?
- should we really remove -modu
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1.
Got: 1 Approve, 1 Pending.
--
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorb
I realize this needs Changelog and doc updates.
--
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsu
Review: Approve
--
https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.ne
7 matches
Mail list logo