Re: [Zorba-coders] [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba

2011-11-04 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.ne

Re: [Zorba-coders] [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba

2011-11-04 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1. Got: 1 Approve, 1 Needs Information. -- https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad

Re: [Zorba-coders] [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba

2011-11-04 Thread Chris Hillery
>Looks good in general. Only tried compiling so far but didn't install. I would >suggest that at > least somebody with Windows also tries it. I built and tested (and even debugged) it on Windows, and at least my own test cases worked fine. > Minor comments: > - theURIPath (good name?); theXQPa

Re: [Zorba-coders] [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba

2011-10-21 Thread Matthias Brantner
Review: Needs Information Looks good in general. Only tried compiling so far but didn't install. I would suggest that at least somebody with Windows also tries it. Minor comments: - theURIPath (good name?); theXQPath? - setLibPath or setLibPaths in the public api? - should we really remove -modu

Re: [Zorba-coders] [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba

2011-10-21 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1. Got: 1 Approve, 1 Pending. -- https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorb

Re: [Zorba-coders] [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba

2011-10-21 Thread Chris Hillery
I realize this needs Changelog and doc updates. -- https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsu

Re: [Zorba-coders] [Merge] lp:~ceejatec/zorba/feature-module-installation into lp:zorba

2011-10-21 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~ceejatec/zorba/feature-module-installation/+merge/80040 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.ne