The proposal to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into
lp:zorba has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
--
https://code.launchpad.net/~zorba-coders/zorba/b
Validation queue job bug1082740_fn_subsequence-2013-04-24T06-13-54.41Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: htt
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1082740_fn_subsequence-2013-04-24T06-13-54.41Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
Your team Zorba Coders is subscribed to branch lp:
The proposal to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into
lp:zorba has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
--
https://code.launchpad.net/~zorba-coders/z
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad
The proposal to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into
lp:zorba has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
--
https://code.launchpad.net/~zorba-coders/z
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1, Needs Information < 1, Resubmit < 1. Got: 1
Approve, 1 Needs Fixing.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
Your team Zorba Coders is
Validation queue job bug1082740_fn_subsequence-2013-04-18T17-05-54.809Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: ht
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1082740_fn_subsequence-2013-04-18T17-05-54.809Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
Your team Zorba Coders is subscribed to branch lp
The proposal to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into
lp:zorba has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
--
https://code.launchpad.net/~zorba-coders/z
Review: Approve
I agree with your logic, Juan; thanks for spelling it out. I hadn't realized
that your new flag were not checked in the inner loop of fn:subsequence(), but
looking at the implementation it appears that is the case. So I have no problem
with it.
Voting Approve now, although clea
The proposal to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into
lp:zorba has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
--
https://code.launchpad.net/~zorba-coders/z
The attempt to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into
lp:zorba failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug1082740_fn_subsequence-2013-04-15T21-01-08.051
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1082740_fn_subsequence-2013-04-15T21-01-08.051Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
Your team Zorba Coders is subscribed to branch lp
The proposal to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into
lp:zorba has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
--
https://code.launchpad.net/~zorba-coders/z
I apologize I made a mistake the numeric Value for INF and -INF is the same
-9223372036854775808 (0x8000) which would make solving this issue
with flags more complex than what I described.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
Your
I made some modifications and the current solution uses 1 less check which will
make it 3 and 4 and the numeric solution would have 0 extra flag checks but it
still has the problem that with INF values it will do extra operations.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_s
Hi regarding the issue of not using the flag for INF values.
The thing is the following whenever you ask for the value of a INF or -INF
number you will get the highest positive or negative number available
9223372036854775807 or -9223372036854775807 being the case for 32 bits.
So I though of u
The proposal to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into
lp:zorba has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
--
https://code.launchpad.net/~zorba-coders/z
The attempt to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into
lp:zorba failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug1082740_fn_subsequence-2013-04-15T16-55-56.486
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1082740_fn_subsequence-2013-04-15T16-55-56.486Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
Your team Zorba Coders is subscribed to branch lp
The proposal to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into
lp:zorba has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
--
https://code.launchpad.net/~zorba-coders/z
Also it seems that the expected failures in the FOTS need to be updated.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-cod
The proposal to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into
lp:zorba has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
--
https://code.launchpad.net/~zorba-coders/z
The attempt to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into
lp:zorba failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug1082740_fn_subsequence-2013-04-10T00-23-52.125
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1082740_fn_subsequence-2013-04-10T00-23-52.125Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
Your team Zorba Coders is subscribed to branch lp
The proposal to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into
lp:zorba has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
--
https://code.launchpad.net/~zorba-coders/z
Review: Needs Fixing
Oh, actually, two quick things:
1. Add a test case that would have failed before and succeeds now
2. Add a note about the fixed bug to the Changelog.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
Your team Zorba Coders is subscribe
Review: Approve
Other than Till's comment, I approve. I'm still a bit wary about having to add
a new flag and test logic to fn:subsequence(), since that's used a lot, so if
you happen to think of a way to do this without such checks that would be
ideal. But, if this flag is necessary, then so b
Review: Needs Fixing
Looks good, but I think that it would be nice to factor out the (virtual) calls
to getDoubleValue().
Not sure if that's measurable, but I don't think that it hurts to give the
compiler a hint :)
--
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+me
Juan Zacarias has proposed merging
lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba.
Commit message:
Added support for INF and -INF values in fn:subsequence function.
Requested reviews:
Chris Hillery (ceejatec)
Related bugs:
Bug #1082740 in Zorba: "subsequence"
https://bugs.l
31 matches
Mail list logo
