[Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
The proposal to merge lp:~danielturcanu/zorba/link1_fix into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063 -- https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
Validation queue job link1_fix-2012-01-11T01-47-04.43Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/link1_fix-2012-01-11T01-47-04.43Z/log.html -- https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
The proposal to merge lp:~danielturcanu/zorba/link1_fix into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063 -- https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
Review: Approve +one -- https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
The proposal to merge lp:~danielturcanu/zorba/link1_fix into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063 -- https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1. Got: 1 Approve. -- https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
Validation queue job link1_fix-2011-12-29T08-41-04.925Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
Review: Approve -- https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/link1_fix-2011-12-29T08-41-04.925Z/log.html -- https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
The proposal to merge lp:~danielturcanu/zorba/link1_fix into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063 -- https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
The proposal to merge lp:~danielturcanu/zorba/link1_fix into lp:zorba has been updated. Commit Message changed to: Removed test versioning/link1 to avoid bug 908062 on Windows For more details, see: https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063 -- https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/link1_fix into
lp:zorba.
Requested reviews:
Chris Hillery (ceejatec)
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063
Removed test versioning/link1 to avoid bug 908062 on Windows
--
https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/87063
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'test/rbkt/Queries/CMakeLists.txt'
--- test/rbkt/Queries/CMakeLists.txt 2011-12-29 08:31:53 +
+++ test/rbkt/Queries/CMakeLists.txt 2011-12-29 08:40:46 +
@@ -168,6 +168,13 @@
SET (SKIP_TEST 1)
ENDIF (NEEDS_FULL_TEXT)
ENDIF (ZORBA_NO_FULL_TEXT)
+ IF(WIN32)
+#this test fails on Windows because cannot find ourlib.dll
+#bug 908062
+IF(${TESTNAME} MATCHES "test/rbkt/zorba/versioning/link1")
+ SET(SKIP_TEST 1)
+ENDIF(${TESTNAME} MATCHES "test/rbkt/zorba/versioning/link1")
+ ENDIF(WIN32)
# If WordNet thesaurus not found, skip ft-thesaurus-true tests
IF (NOT ZORBA_WORDNET_FOUND)
@@ -260,15 +267,6 @@
ENDIF(XVERMAJ EQUAL 2)
IF(WIN32)
- EXPECTED_FAILURE(test/rbkt/zorba/versioning/external1 870991)
- EXPECTED_FAILURE(test/rbkt/zorba/versioning/external2 870991)
-
- EXPECTED_FAILURE(test/rbkt/zorba/versioning/link1 871061)
-
- # this is still an expected failure but has been commented out since the
- # test is now completely disabled because of bug 871335
- #EXPECTED_FAILURE(test/rbkt/zorba/xqdoc/moduleDocumentation 871062)
-
EXPECTED_FAILURE(test/rbkt/zorba/file/createWriteReadDeleteSeries 866969)
ENDIF(WIN32)
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
Review: Needs Fixing - Please put a very prominent comment around the SKIP_TEST block identifying why the test is skipped and listing the bug number. - Likewise, please add comment referring to the bug number next to the commented-out EXPECTED_FAILURE() for the link1 test. - If the external1/external2 tests are working now, you should just remove the EXPECTED_FAILURE() lines rather than commenting them out. FYI, for relatively trivial changes like this, I would have just made the corrections myself, but since the branch is owned by ~danielturcanu I couldn't do that... -- https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86994 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
The proposal to merge lp:~danielturcanu/zorba/link1_fix into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86994 -- https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86994 Your team Zorba Coders is requested to review the proposed merge of lp:~danielturcanu/zorba/link1_fix into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/link1_fix into
lp:zorba.
Requested reviews:
Zorba Coders (zorba-coders)
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86994
Removed test versioning/link1 to avoid bug 908062 on Windows
--
https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86994
Your team Zorba Coders is requested to review the proposed merge of
lp:~danielturcanu/zorba/link1_fix into lp:zorba.
=== modified file 'test/rbkt/Queries/CMakeLists.txt'
--- test/rbkt/Queries/CMakeLists.txt 2011-12-22 20:34:53 +
+++ test/rbkt/Queries/CMakeLists.txt 2011-12-28 09:05:31 +
@@ -168,6 +168,11 @@
SET (SKIP_TEST 1)
ENDIF (NEEDS_FULL_TEXT)
ENDIF (ZORBA_NO_FULL_TEXT)
+ IF(WIN32)
+IF(${TESTNAME} MATCHES "test/rbkt/zorba/versioning/link1")
+ SET(SKIP_TEST 1)
+ENDIF(${TESTNAME} MATCHES "test/rbkt/zorba/versioning/link1")
+ ENDIF(WIN32)
# If WordNet thesaurus not found, skip ft-thesaurus-true tests
IF (NOT ZORBA_WORDNET_FOUND)
@@ -260,10 +265,11 @@
ENDIF(XVERMAJ EQUAL 2)
IF(WIN32)
- EXPECTED_FAILURE(test/rbkt/zorba/versioning/external1 870991)
- EXPECTED_FAILURE(test/rbkt/zorba/versioning/external2 870991)
+ #these tests now work on Windows
+ #EXPECTED_FAILURE(test/rbkt/zorba/versioning/external1 870991)
+ #EXPECTED_FAILURE(test/rbkt/zorba/versioning/external2 870991)
- EXPECTED_FAILURE(test/rbkt/zorba/versioning/link1 871061)
+ #EXPECTED_FAILURE(test/rbkt/zorba/versioning/link1 871061)
# this is still an expected failure but has been commented out since the
# test is now completely disabled because of bug 871335
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
The proposal to merge lp:~danielturcanu/zorba/link1_fix into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86960 -- https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86960 Your team Zorba Coders is requested to review the proposed merge of lp:~danielturcanu/zorba/link1_fix into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86960 Your team Zorba Coders is requested to review the proposed merge of lp:~danielturcanu/zorba/link1_fix into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
The proposal to merge lp:~danielturcanu/zorba/link1_fix into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86960 -- https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86960 Your team Zorba Coders is requested to review the proposed merge of lp:~danielturcanu/zorba/link1_fix into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/link1_fix into lp:zorba
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/link1_fix into lp:zorba. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86960 Removed test versioning/link1 to avoid bug 908062 on Windows -- https://code.launchpad.net/~danielturcanu/zorba/link1_fix/+merge/86960 Your team Zorba Coders is requested to review the proposed merge of lp:~danielturcanu/zorba/link1_fix into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
