The proposal to merge lp:~paul-lucas/zorba/bug-1002867 into lp:zorba has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team
Validation queue job bug-1002867-2012-05-23T13-42-01.572Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-cod
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-1002867-2012-05-23T13-42-01.572Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: htt
The proposal to merge lp:~paul-lucas/zorba/bug-1002867 into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
You
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-code
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-code
> If no override-media-type is given, then the default charset is still ISO
> 8859-1 (see line 76 in http_response_parser.cpp).
>
> However, if the user gives an override-media-type, then there is no charset
> unless the user explicitly includes a "; charset=..." as part of the override-
> media-t
If no override-media-type is given, then the default charset is still ISO
8859-1 (see line 76 in http_response_parser.cpp).
However, if the user gives an override-media-type, then there is no charset
unless the user explicitly includes a "; charset=..." as part of the
override-media-type; hence
Review: Needs Information
Does you change imply that the default if no charset is given isn't ISO-8859-1
anymore.
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-cod
If the content is non-textual, then they shouldn't be giving a charset="...".
So I don't see the problem.
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post
Review: Needs Fixing
It seems your investigation makes sense. However, I think that the solution
should be to not do any transcoding for any non-textual content (even if the
user gives one).
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team Zorba Coders is subs
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/bug-1002867 into
lp:zorba.
Requested reviews:
David Graf (davidagraf)
Related bugs:
Bug #1002867 in Zorba: "resulting base64 in http-client is wrong"
https://bugs.launchpad.net/zorba/+bug/1002867
For more details, see:
https://code.la
12 matches
Mail list logo