Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1002867 into lp:zorba

2012-05-23 Thread David Graf 
Review: Approve


-- 
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1002867 into lp:zorba

2012-05-23 Thread Paul J. Lucas 
The proposal to merge lp:~paul-lucas/zorba/bug-1002867 into lp:zorba has been 
updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
-- 
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1002867 into lp:zorba

2012-05-23 Thread Zorba Build Bot 
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/bug-1002867-2012-05-23T13-42-01.572Z/log.html
-- 
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1002867 into lp:zorba

2012-05-23 Thread Zorba Build Bot 
Validation queue job bug-1002867-2012-05-23T13-42-01.572Z is finished. The 
final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1002867 into lp:zorba

2012-05-23 Thread noreply 
The proposal to merge lp:~paul-lucas/zorba/bug-1002867 into lp:zorba has been 
updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
-- 
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1002867 into lp:zorba

2012-05-22 Thread Paul J. Lucas 
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/bug-1002867 into 
lp:zorba.

Requested reviews:
  David Graf (davidagraf)
Related bugs:
  Bug #1002867 in Zorba: resulting base64 in http-client is wrong
  https://bugs.launchpad.net/zorba/+bug/1002867

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855

No longer setting the charset of an overridden media type to a default value.
-- 
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'modules/com/zorba-xquery/www/modules/http-client.xq.src/http_response_parser.cpp'
--- modules/com/zorba-xquery/www/modules/http-client.xq.src/http_response_parser.cpp	2012-05-10 04:12:09 +
+++ modules/com/zorba-xquery/www/modules/http-client.xq.src/http_response_parser.cpp	2012-05-22 16:46:23 +
@@ -41,8 +41,7 @@
   std::string::size_type pos = s.find( ';' );
   *mime_type = s.substr( 0, pos );
 
-  // The HTTP/1.1 spec says that the default charset is ISO-8859-1.
-  *charset = ISO-8859-1;
+  charset-clear();
 
   if ( pos != std::string::npos ) {
 //
@@ -109,7 +108,8 @@
 
   std::auto_ptrstd::istream lStream;
   try {
-if ( transcode::is_necessary( theCurrentCharset.c_str() ) ) {
+if ( !theCurrentCharset.empty() 
+ transcode::is_necessary( theCurrentCharset.c_str() ) ) {
   lStream.reset(
 new transcode::streamstd::istream(
   theCurrentCharset.c_str(), theStreamBuffer

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1002867 into lp:zorba

2012-05-22 Thread Paul J. Lucas 
If the content is non-textual, then they shouldn't be giving a charset=  
So I don't see the problem.
-- 
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1002867 into lp:zorba

2012-05-22 Thread Matthias Brantner 
Review: Needs Information

Does you change imply that the default if no charset is given isn't ISO-8859-1 
anymore.
-- 
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1002867 into lp:zorba

2012-05-22 Thread Paul J. Lucas 
If no override-media-type is given, then the default charset is still ISO 
8859-1 (see line 76 in http_response_parser.cpp).

However, if the user gives an override-media-type, then there is no charset 
unless the user explicitly includes a ; charset=... as part of the 
override-media-type; hence, the bytes will pass through unchanged.

I can't think of anything else that's sensible to do.
-- 
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1002867 into lp:zorba

2012-05-22 Thread Matthias Brantner 
 If no override-media-type is given, then the default charset is still ISO
 8859-1 (see line 76 in http_response_parser.cpp).
 
 However, if the user gives an override-media-type, then there is no charset
 unless the user explicitly includes a ; charset=... as part of the override-
 media-type; hence, the bytes will pass through unchanged.
 
 I can't think of anything else that's sensible to do.
If the user overrides the media-type, the behavior should be no different then 
if the server returned one. That is, if the media type is overwritten to be a 
text content-type, the default encoding ISO-8859-1 should still be used. Of 
course, unless otherwise given by the user.
-- 
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1002867 into lp:zorba

2012-05-22 Thread Matthias Brantner 
Review: Approve


-- 
https://code.launchpad.net/~paul-lucas/zorba/bug-1002867/+merge/106855
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp