Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq-update into lp:zorba
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-up
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Your te
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq-update into lp:zorba
has been updated.
Commit Message changed to:
Introducing new update syntax in the JSONiq parser.
- Made json keyword mandatory to avoid conflicts.
- Turned "replace json value of" into "replace value of json" to make
c
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Your te
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Stage "TestZorbaUbuntu" failed.
1 tests failed (8490 total tests run).
Check test results at
http://jenkins.lambda.nu/job/TestZorbaUbuntu/298/testReport/ to view the
results.
--
https://
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Your te
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Stage "TestZorbaUbuntu" failed.
2 tests failed (8490 total tests run).
Check test results at
http://jenkins.lambda.nu/job/TestZorbaUbuntu/297/testReport/ to view the
results.
--
https://
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Your te
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Stage "TestZorbaUbuntu" failed.
1 tests failed (8490 total tests run).
Check test results at
http://jenkins.lambda.nu/job/TestZorbaUbuntu/296/testReport/ to view the
results.
--
https://
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Your te
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Stage "CommitZorba" failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/178/console to
view the results.
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295 :
Votes: {'Approve': 2, 'Needs commit message': 1}
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Your team Zorba Coders is s
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zo
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Your te
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Stage "BuildZorbaUbuntu" failed.
Check compiler output at
http://jenkins.lambda.nu/job/BuildZorbaUbuntu/336/parsed_console to view the
results.
--
https://code.launchpad.net/~zorba-coder
After looking more in depth, I realized that there is an inconsistency across
parsenodes. Some of them have const exprnode* pointers on their children (like
JSONObjectLookup had), some others regular exprnode* pointers (like
JSONObjectLookup has now). The latter seem to correspond to places that
Hi Matthias,
I am not sure I understand what you are suggesting.
The reason for non-const is that temporary parse nodes (in that case a lookup
expression node) use regular pointers that they own to child parse nodes, i.e.,
the destructor deletes the object pointed to at the end. However, these
Review: Approve
Looks great. I'll approve and let you decide on one question:
Is it really necessary to make the expressions in the parsenodes non-const?
Couldn't you use a unique pointer or auto_ptr in the parser that is passed
to convert_postfix_to_target_and_selector and only released when th
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295 :
Votes: {'Pending': 1, 'Needs commit message': 1}
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Your team Zorba Coders is s
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Your te
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Stage "CommitZorba" failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/177/console to
view the results.
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-
22 matches
Mail list logo
