Review: Needs Fixing
I just realized that the set of options for canonicalization (as proposed by
Matthias) are overlapping with the options that already exist for XML parsing.
But the current implementation adds an entirely new set of options. This looks
pretty silly, and is a waste of code.
My proposal:
1. Add a new method: int store::LoadProperties::toLibXmlOptions()
The implementation of this method should be copied from
zorba::simplestore::XmlLoader::applyLoadOptions() (minus the final call to
xmlCtxtUseOptions() ), and applyLoadOptions() should of course be refactored to
call
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-scratch
into lp:zorba.
Commit message:
fixed warning in index_join_rule (bug #1142337)
Requested reviews:
Markos Zaharioudakis (markos-za)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scrat
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/151810
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/151810
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+m
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2013-03-05T17-26-50.333Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/151810
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing l
Validation queue job markos-scratch-2013-03-05T17-26-50.333Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/151810
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~z
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has
been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/151810
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/1
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/pjl-misc into lp:zorba.
Commit message:
Clean-up of file class and file module; added file:is-symlink().
Requested reviews:
Paul J. Lucas (paul-lucas)
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151861
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151861
Your team Zo
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/pjl-misc-2013-03-06T03-00-50.867Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151861
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://l
The attempt to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba failed. Below
is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job pjl-misc-2013-03-06T03-00-50.867Z is finished. The
final status w
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151861
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151861
Your team Zo
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151861
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151861
Your team Zo
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/pjl-misc-2013-03-06T04-07-49.675Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151861
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://l
Validation queue job pjl-misc-2013-03-06T04-07-49.675Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151861
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Po
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 1 Pending.
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151861
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151861
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151861
Your team Zo
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151861
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
19 matches
Mail list logo
