The Xerces doc doesn't say what happens with the buffer, but I checked the
source and they both (setSystemId and setPublicId) do make copies of the buffer.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
Your team Zorba Coders is subscribed to branch lp:zor
The proposal to merge lp:~zorba-coders/zorba/bug1023120-schemaImport into
lp:zorba has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
--
https://code.launchpad.net/~zorba-coders/zorba/bug10
Validation queue job bug1023120-schemaImport-2012-07-14T01-48-00.078Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https:
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1023120-schemaImport-2012-07-14T01-48-00.078Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
Your team Zorba Coders is subscribed to branch lp:zor
The proposal to merge lp:~zorba-coders/zorba/bug1023120-schemaImport into
lp:zorba has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
--
https://code.launchpad.net/~zorba-coders/zorba
Review: Approve
I wish Xerces' doc confirmed that setPublicId() and setSystemId() made local
copies of those parameters, but valgrind reports no leaks so clearly they do!
--
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
Your team Zorba Coders is subscribed
Fixed. Please check.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpa
Review: Approve
Change looks good to me. I also tested it with a bigger schema and with
valgrind. I don't see a memory problem.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: http
Review: Needs Fixing
Interesting! However, XMLString::transcode() returns a memory buffer that the
caller must free by calling XMLString::release(), so I believe this change
introduces a memory leak (unless InputSource will free them, which I don't
think it does). I'm actually not 100% sure how
The proposal to merge lp:~zorba-coders/zorba/bug1023120-schemaImport into
lp:zorba has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
--
https://code.launchpad.net/~zorba-coders/zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
Your team Zorba Coders is requested to review the proposed merge of
lp:~zorba-cod
Validation queue job bug1023120-schemaImport-2012-07-12T19-35-14.795Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
Your team Zorba Coders is requested to review the proposed merge of
lp:~zorba-cod
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1023120-schemaImport-2012-07-12T19-35-14.795Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
Your team Zorba Coders is requested to review the pro
The proposal to merge lp:~zorba-coders/zorba/bug1023120-schemaImport into
lp:zorba has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
--
https://code.launchpad.net/~zorba-coders/zorba
The proposal to merge lp:~zorba-coders/zorba/bug1023120-schemaImport into
lp:zorba has been updated.
Commit Message changed to:
Integrate:
Fix for bug 1023120 xs:include ignored in schemas.
Added a new test for this case.
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba
Cezar Andrei has proposed merging
lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba.
Requested reviews:
Zorba Coders (zorba-coders)
Related bugs:
Bug #1023120 in Zorba: "xs:include ignored in schemas"
https://bugs.launchpad.net/zorba/+bug/1023120
For more details, see:
https://c
16 matches
Mail list logo
