Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-16 Thread Cezar Andrei
The Xerces doc doesn't say what happens with the buffer, but I checked the source and they both (setSystemId and setPublicId) do make copies of the buffer. -- https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712 Your team Zorba Coders is subscribed to branch

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-13 Thread David Graf
Review: Approve Change looks good to me. I also tested it with a bigger schema and with valgrind. I don't see a memory problem. -- https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-13 Thread Cezar Andrei
Fixed. Please check. -- https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-13 Thread Chris Hillery
Review: Approve I wish Xerces' doc confirmed that setPublicId() and setSystemId() made local copies of those parameters, but valgrind reports no leaks so clearly they do! -- https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712 Your team Zorba Coders is subscribed

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-13 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-13 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug1023120-schemaImport-2012-07-14T01-48-00.078Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712 Your team Zorba Coders is subscribed to branch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-13 Thread Zorba Build Bot
Validation queue job bug1023120-schemaImport-2012-07-14T01-48-00.078Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-13 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-12 Thread Cezar Andrei
the proposed merge of lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba. === modified file 'src/types/schema/schema.cpp' --- src/types/schema/schema.cpp 2012-07-12 17:29:55 + +++ src/types/schema/schema.cpp 2012-07-12 19:33:21 + @@ -115,13 +115,14 @@ // QQQ

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-12 Thread Cezar Andrei
The proposal to merge lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba has been updated. Commit Message changed to: Integrate: Fix for bug 1023120 xs:include ignored in schemas. Added a new test for this case. For more details, see: https://code.launchpad.net/~zorba-coders

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-12 Thread Zorba Build Bot
the proposed merge of lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-12 Thread Zorba Build Bot
-coders/zorba/bug1023120-schemaImport into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-12 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-12 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712 -- https://code.launchpad.net/~zorba-coders/zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-12 Thread Chris Hillery
Review: Needs Fixing Interesting! However, XMLString::transcode() returns a memory buffer that the caller must free by calling XMLString::release(), so I believe this change introduces a memory leak (unless InputSource will free them, which I don't think it does). I'm actually not 100% sure