Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba
This is addressed in proposal: https://code.launchpad.net/~zorba-coders/zorba/bug857842-textWithComment/+merge/103367 -- https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba
Review: Needs Fixing There are already plenty of definitions for the XMLSchema URI. I think it would make sense to reuse the one from src/zorbamisc/ns_consts.h. -- https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103169 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172 -- https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba
Validation queue job bug867156-importsegfaults-2012-04-23T21-34-13.402Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug867156-importsegfaults-2012-04-23T21-34-13.402Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172 -- https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172 -- https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba has been updated. Commit Message changed to: According to Xerces-C++ team( http://issues.apache.org/jira/browse/XERCESC-1980 ) XMLSchema.xsd i.e. schema4schema should be avoided to be imported. This fix avoids importing this schema file. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172 -- https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172 -- https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba
Review: Approve Done. -- https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba
Cezar Andrei has proposed merging
lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba.
Requested reviews:
Cezar Andrei (cezar-andrei)
Chris Hillery (ceejatec)
Related bugs:
Bug #867156 in Zorba: "Import schema segfaults"
https://bugs.launchpad.net/zorba/+bug/867156
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172
According to Xerces-C++ team( http://issues.apache.org/jira/browse/XERCESC-1980
) XMLSchema.xsd i.e. schema4schema should be avoided to be imported. This fix
avoids importing this schema file.
--
https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103172
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/compiler/translator/translator.cpp'
--- src/compiler/translator/translator.cpp 2012-04-23 10:46:38 +
+++ src/compiler/translator/translator.cpp 2012-04-23 21:12:21 +
@@ -105,7 +105,7 @@
#define NODE_SORT_OPT
-
+#define XS_URI "http://www.w3.org/2001/XMLSchema";
namespace zorba
{
@@ -2011,6 +2011,14 @@
theSctx->bind_ns(pfx, targetNS, loc, err::XQST0033);
}
+ zstring xsdTNS = zstring(XS_URI);
+ if ( xsdTNS.compare(targetNS)==0 )
+ {
+// Xerces doesn't like importing XMLSchema.xsd schema4schema, so we skip it
+// see Xerces-C++ bug: https://issues.apache.org/jira/browse/XERCESC-1980
+return no_state;
+ }
+
store::Item_t targetNSItem = NULL;
zstring tmp = targetNS;
ITEM_FACTORY->createAnyURI(targetNSItem, tmp);
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba
Could you add a URL in the code comment pointing to a Xerces mailing list discussion or other page where it is mentioned that you shouldn't import schema for schema? I suspect that is something that will surprise anyone who looks at the Zorba source code later, so it would be good to have third-party confirmation. Ceej aka Chris Hillery On Apr 23, 2012 1:48 PM, "Cezar Andrei" wrote: > The proposal to merge lp:~zorba-coders/zorba/bug867156-importsegfaults > into lp:zorba has been updated. > >Status: Needs review => Approved > > For more details, see: > > https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103169 > -- > > https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103169 > You are requested to review the proposed merge of > lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba. > -- https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103169 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103169 -- https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103169 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103169 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba
Cezar Andrei has proposed merging
lp:~zorba-coders/zorba/bug867156-importsegfaults into lp:zorba.
Requested reviews:
Cezar Andrei (cezar-andrei)
Chris Hillery (ceejatec)
Related bugs:
Bug #867156 in Zorba: "Import schema segfaults"
https://bugs.launchpad.net/zorba/+bug/867156
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103169
According to Xerces-C++ team( http://issues.apache.org/jira/browse/XERCESC-1980
) XMLSchema.xsd i.e. schema4schema should be avoided to be imported. This fix
avoids importing this schema file.
--
https://code.launchpad.net/~zorba-coders/zorba/bug867156-importsegfaults/+merge/103169
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/compiler/translator/translator.cpp'
--- src/compiler/translator/translator.cpp 2012-04-23 10:46:38 +
+++ src/compiler/translator/translator.cpp 2012-04-23 20:45:24 +
@@ -105,7 +105,7 @@
#define NODE_SORT_OPT
-
+#define XS_URI "http://www.w3.org/2001/XMLSchema";
namespace zorba
{
@@ -2011,6 +2011,13 @@
theSctx->bind_ns(pfx, targetNS, loc, err::XQST0033);
}
+ zstring xsdTNS = zstring(XS_URI);
+ if ( xsdTNS.compare(targetNS)==0 )
+ {
+// Xerces doesn't like importing XMLSchema.xsd schema4schema, so we skip it
+return no_state;
+ }
+
store::Item_t targetNSItem = NULL;
zstring tmp = targetNS;
ITEM_FACTORY->createAnyURI(targetNSItem, tmp);
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
