Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Markos Zaharioudakis
Review: Needs Fixing -- https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Markos Zaharioudakis
Why is the processPragma method defined only for static_collections_dml_apply_insert_nodes_last. Should it be defined for the other collection-insert functions as well? ChangeLog needs updating Tiny optimization: if you want to erase the last N entries in a vector, you can just use resize().

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Matthias Brantner
Why is the processPragma method defined only for static_collections_dml_apply_insert_nodes_last. Should it be defined for the other collection-insert functions as well? ChangeLog needs updating Tiny optimization: if you want to erase the last N entries in a vector, you can just use

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 -- https://code.launchpad.net/~zorba-coders/zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 -- https://code.launchpad.net/~zorba-coders/zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Markos Zaharioudakis
I am going to approve, but it would be nice if you added an iter test to make sure that the optimization is applied and we won't loose it somehow in the future. To do so, you must first make PrinterVisitor print theNeedToCpy data member of the various ZorbaInsertNodesXXX iterators. This will

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 -- https://code.launchpad.net/~zorba-coders/zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Matthias Brantner
I am going to approve, but it would be nice if you added an iter test to make sure that the optimization is applied and we won't loose it somehow in the future. To do so, you must first make PrinterVisitor print theNeedToCpy data member of the various ZorbaInsertNodesXXX iterators. This will

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-pragma_no_copy-2012-09-19T21-42-49.059Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 Your team Zorba Coders is subscribed to branch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Zorba Build Bot
Validation queue job feature-pragma_no_copy-2012-09-19T21-42-49.059Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 -- https://code.launchpad.net/~zorba-coders/zorba/feature

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-pragma_no_copy-2012-09-12T17-51-55.158Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 Your team Zorba Coders is subscribed to branch

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job feature-pragma_no_copy-2012-09-12T17-51-55.158Z

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
Validation queue job feature-pragma_no_copy-2012-09-12T18-22-49.866Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Approve, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-pragma_no_copy-2012-09-12T21-32-49.698Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 Your team Zorba Coders is subscribed to branch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
Validation queue job feature-pragma_no_copy-2012-09-12T21-32-49.698Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Approve, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Matthias Brantner
Matthias Brantner has proposed merging lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba. Requested reviews: Matthias Brantner (matthias-brantner) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 pragma for preventing

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-pragma_no_copy-2012-06-29T17-23-58.019Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 Your team Zorba Coders is subscribed to branch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Zorba Build Bot
Validation queue job feature-pragma_no_copy-2012-06-29T17-23-58.019Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 -- https://code.launchpad.net/~zorba-coders/zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-pragma_no_copy-2012-06-29T21-33-59.318Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 Your team Zorba Coders is subscribed to branch

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job feature-pragma_no_copy-2012-06-29T21-33-59.318Z

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 -- https://code.launchpad.net/~zorba-coders/zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816 -- https://code.launchpad.net/~zorba-coders/zorba