[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fixes_FOTS_driver_29_MAR-2013-04-02T08-36-45.465Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job fixes_FOTS_driver_29_MAR-2013-04-02T08-36-45.465Z is finished. The final status was: 2 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fixes_FOTS_driver_29_MAR-2013-04-02T18-06-54.471Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
Validation queue job fixes_FOTS_driver_29_MAR-2013-04-02T18-06-54.471Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
Sorin Marian Nasoi has proposed merging lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba. Commit message: - updated FOTS snapshot to March 29th. Updated expected failures accordingly. - if a test did not pass, we further check if the reason it failed is an environment dependency on setting of a default COLLECTION or COLLATION URI (other that Unicode Codepoint Collation). If so, we report the test case as notRun otherwise we report it as fail. We first try running the test case because 130 test case actually PASS although their used environment requires setting a default COLECTION or COLLATION URI. This change decreased the number of failing test cases by 34 (and increased the number of test cases notRun by the same amount). Requested reviews: Sorin Marian Nasoi (sorin.marian.nasoi) Related bugs: Bug #1160111 in Zorba: xqxq: add collection support (at least 39 test cases) https://bugs.launchpad.net/zorba/+bug/1160111 Bug #1161475 in Zorba: FOTS driver does not handle collation URI's https://bugs.launchpad.net/zorba/+bug/1161475 For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 - updated FOTS snapshot to March 29th. Updated expected failures accordingly. - if a test did not pass, we further check if the reason it failed is an environment dependency on setting of a default COLLECTION or COLLATION URI (other that Unicode Codepoint Collation). If so, we report the test case as notRun otherwise we report it as fail. We first try running the test case because 130 test case actually PASS although their used environment requires setting a default COLECTION or COLLATION URI. This change decreased the number of failing test cases by 34 (and increased the number of test cases notRun by the same amount). -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. === modified file 'test/fots/CMakeLists.txt' --- test/fots/CMakeLists.txt 2013-03-27 17:11:24 + +++ test/fots/CMakeLists.txt 2013-03-29 06:26:29 + @@ -135,31 +135,12 @@ EXPECTED_FOTS_FAILURE (fn-available-environment-variables fn-available-environment-variables-011 0) EXPECTED_FOTS_FAILURE (fn-avg cbcl-avg-002 0) EXPECTED_FOTS_FAILURE (fn-avg cbcl-avg-003 0) -EXPECTED_FOTS_FAILURE (fn-collection fn-collection-4 0) -EXPECTED_FOTS_FAILURE (fn-collection fn-collection-4d 0) -EXPECTED_FOTS_FAILURE (fn-collection fn-collection-5 0) -EXPECTED_FOTS_FAILURE (fn-collection fn-collection-5d 0) -EXPECTED_FOTS_FAILURE (fn-collection fn-collection-6 0) -EXPECTED_FOTS_FAILURE (fn-collection fn-collection-8 0) -EXPECTED_FOTS_FAILURE (fn-collection fn-collection-9 0) -EXPECTED_FOTS_FAILURE (fn-collection fn-collection-10 0) -EXPECTED_FOTS_FAILURE (fn-collection fn-collection-10d 0) -EXPECTED_FOTS_FAILURE (fn-compare compare-010 0) -EXPECTED_FOTS_FAILURE (fn-deep-equal K-SeqDeepEqualFunc-56 0) -EXPECTED_FOTS_FAILURE (fn-deep-equal K-SeqDeepEqualFunc-57 0) -EXPECTED_FOTS_FAILURE (fn-deep-equal K-SeqDeepEqualFunc-58 0) -EXPECTED_FOTS_FAILURE (fn-deep-equal K-SeqDeepEqualFunc-59 0) -EXPECTED_FOTS_FAILURE (fn-deep-equal K-SeqDeepEqualFunc-60 0) -EXPECTED_FOTS_FAILURE (fn-deep-equal K-SeqDeepEqualFunc-61 0) -EXPECTED_FOTS_FAILURE (fn-deep-equal K-SeqDeepEqualFunc-62 0) -EXPECTED_FOTS_FAILURE (fn-deep-equal K-SeqDeepEqualFunc-63 0) EXPECTED_FOTS_FAILURE (fn-deep-equal K2-SeqDeepEqualFunc-36 0) EXPECTED_FOTS_FAILURE (fn-deep-equal K2-SeqDeepEqualFunc-37 0) EXPECTED_FOTS_FAILURE (fn-deep-equal K2-SeqDeepEqualFunc-38 0) EXPECTED_FOTS_FAILURE (fn-deep-equal K2-SeqDeepEqualFunc-39 0) EXPECTED_FOTS_FAILURE (fn-distinct-values cbcl-distinct-values-002 0) EXPECTED_FOTS_FAILURE (fn-distinct-values cbcl-distinct-values-002b 0) -EXPECTED_FOTS_FAILURE (fn-distinct-values cbcl-distinct-values-003 0) EXPECTED_FOTS_FAILURE (fn-environment-variable environment-variable-005 0) EXPECTED_FOTS_FAILURE (fn-environment-variable environment-variable-006 0) EXPECTED_FOTS_FAILURE (fn-environment-variable environment-variable-007 0) @@ -218,8 +199,6 @@ EXPECTED_FOTS_FAILURE (fn-generate-id generate-id-004 0) EXPECTED_FOTS_FAILURE (fn-generate-id generate-id-005 0) EXPECTED_FOTS_FAILURE (fn-generate-id generate-id-006 0) -EXPECTED_FOTS_FAILURE (fn-generate-id generate-id-012 0) -EXPECTED_FOTS_FAILURE (fn-generate-id generate-id-013 0) EXPECTED_FOTS_FAILURE (fn-generate-id generate-id-014 0) EXPECTED_FOTS_FAILURE (fn-generate-id generate-id-015 0) EXPECTED_FOTS_FAILURE (fn-generate-id generate-id-017 0) @@ -285,8 +264,6 @@ EXPECTED_FOTS_FAILURE (fn-subsequence cbcl-subsequence-017 0) EXPECTED_FOTS_FAILURE (fn-subsequence cbcl-subsequence-018 0) EXPECTED_FOTS_FAILURE (fn-subsequence cbcl-subsequence-024 0) -EXPECTED_FOTS_FAILURE (fn-substring-after fn-substring-after-24 0) -EXPECTED_FOTS_FAILURE (fn-substring-before fn-substring-before-24 0) EXPECTED_FOTS_FAILURE (fn-tokenize fn-tokenize-31 0)
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fixes_FOTS_driver_29_MAR-2013-03-29T06-29-40.76Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
Validation queue job fixes_FOTS_driver_29_MAR-2013-03-29T06-29-40.76Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1, Needs Information 1, Resubmit 1. Got: 1 Approve. -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba has been updated. Commit Message changed to: - updated FOTS snapshot to March 29th. Updated expected failures accordingly. - if a test did not pass, we further check if the reason it failed is an environment dependency on setting of a default COLLECTION or COLLATION URI (other that Unicode Codepoint Collation). If so, we report the test case as notRun otherwise we report it as fail. This change decreased the number of failing test cases by 34 (and increased the number of test cases notRun by the same amount). For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
Review: Approve The changes seem OK for now; however, they don't actually *fix* the two related bugs, do they? -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
The changes seem OK for now; however, they don't actually *fix* the two related bugs, do they? They do actually because they correctly marked some bugs as notRun instead of fail (which according to W3C is OK). If we decide we want to increase the number of test cases that PASS, additional work needs to be done in XQXQ for both of those bugs. -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
Please also see: https://bugs.launchpad.net/zorba/+bug/1160111/comments/2 My understanding of the comment is this: Step 1) minimise the number of failing test cases as much as possible Step 2) maximize the number of passing test cases as much as possible What is your opinion? -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
One more thing: even Mike Kay says that these 2 let's call them features (ability to define COLLECTIONS and to set COLLATION URI's) is like implicit dependency [...] An implementation that cannot set the context as required should behave in the same way as if a dependency has not been satisfied, ideally reporting the test as notRun with a reason. taken from http://dev.w3.org/2011/QT3-test-suite/guide/running.html So the proposed changed implement the ideal case where Zorba report's the test cases as notRun with information about the reason it did not run them. -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba has been updated. Commit Message changed to: - updated FOTS snapshot to March 29th. Updated expected failures accordingly. - if a test did not pass, we further check if the reason it failed is an environment dependency on setting of a default COLLECTION or COLLATION URI (other that Unicode Codepoint Collation). If so, we report the test case as notRun otherwise we report it as fail. This change decreased the number of failing test cases by 34 (and increased the number of test cases notRun by the same amount). - corrected errors in FOTSZorbaManifest.xml - modified 'tools/dependencies.xq' to scan FOTS for all dependencies that are not appearing in FOTSZorbaManifest.xml and report them. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp