The proposal to merge lp:~markos-za/zorba/bugs2 into lp:zorba has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~markos-za/zorba/bugs2/+merge/78834
--
https://code.launchpad.net/~markos-za/zorba/bugs2/+merge/78834
Your team Zorba Coders is subscri
Validation queue job bugs2-2011-10-11T20-03-57.953Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~markos-za/zorba/bugs2/+merge/78834
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bugs2-2011-10-11T20-03-57.953Z/log.html
--
https://code.launchpad.net/~markos-za/zorba/bugs2/+merge/78834
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad
The proposal to merge lp:~markos-za/zorba/bugs2 into lp:zorba has been updated.
Status: Approved => Work in progress
For more details, see:
https://code.launchpad.net/~markos-za/zorba/bugs2/+merge/78834
--
https://code.launchpad.net/~markos-za/zorba/bugs2/+merge/78834
Your team Zorba Coders
Review: Approve
--
https://code.launchpad.net/~markos-za/zorba/bugs2/+merge/78834
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More
> No reason to reject but why do we rename functions in the store api? It will
> cause 28msec some effort when merging the changes.
Because getNodeReference is more descriptive and more consistent/symmetric with
the node-reference function, and the getNodeByReference method.
But if you think it
No reason to reject but why do we rename functions in the store api? It will
cause 28msec some effort when merging the changes.
--
https://code.launchpad.net/~markos-za/zorba/bugs2/+merge/78834
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorb
The proposal to merge lp:~markos-za/zorba/bugs2 into lp:zorba has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~markos-za/zorba/bugs2/+merge/78834
--
https://code.launchpad.net/~markos-za/zorba/bugs2/+merge/78834
Your team Zorba Coders is s
Review: Approve
--
https://code.launchpad.net/~markos-za/zorba/bugs2/+merge/78834
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More
Approved. I am not sure if you also need another vote for starting the merge
--
https://code.launchpad.net/~markos-za/zorba/bugs2/+merge/78834
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.
> Hi Markos,
>
> i think that the flag "haveListType" is not reset correctly if the element
> passes from
>
> haveTypedValue && haveTypedTypedValue && haveListType
> to
> haveTypedValue && haveTypedTypedValue && !haveListType
>
> I would add:
> else
>textChild->resetHaveListValue();
> near l
Review: Needs Information
Hi Markos,
i think that the flag "haveListType" is not reset correctly if the element
passes from
haveTypedValue && haveTypedTypedValue && haveListType
to
haveTypedValue && haveTypedTypedValue && !haveListType
I would add:
else
textChild->resetHaveListValue();
near
Markos Zaharioudakis has proposed merging lp:~markos-za/zorba/bugs2 into
lp:zorba.
Requested reviews:
Federico Cavalieri (fcavalieri)
For more details, see:
https://code.launchpad.net/~markos-za/zorba/bugs2/+merge/78834
--
https://code.launchpad.net/~markos-za/zorba/bugs2/+merge/78834
Your te
13 matches
Mail list logo
