Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-16 Thread Cezar Andrei 
The Xerces doc doesn't say what happens with the buffer, but I checked the 
source and they both (setSystemId and setPublicId) do make copies of the buffer.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-13 Thread Chris Hillery 
Review: Approve

I wish Xerces' doc confirmed that setPublicId() and setSystemId() made local 
copies of those parameters, but valgrind reports no leaks so clearly they do!
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-13 Thread Cezar Andrei 
Fixed. Please check.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-13 Thread David Graf 
Review: Approve

Change looks good to me. I also tested it with a bigger schema and with 
valgrind. I don't see a memory problem.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-12 Thread Chris Hillery 
Review: Needs Fixing

Interesting! However, XMLString::transcode() returns a memory buffer that the 
caller must free by calling XMLString::release(), so I believe this change 
introduces a memory leak (unless InputSource will free them, which I don't 
think it does). I'm actually not 100% sure how to solve this - I guess 
IstreamInputSource could free them in its destructor, if it can tell that it 
needs to do so?
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba

2012-07-12 Thread Zorba Build Bot 
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, 
Needs Fixing < 1, Pending < 1. Got: 1 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1023120-schemaImport/+merge/114712
Your team Zorba Coders is requested to review the proposed merge of 
lp:~zorba-coders/zorba/bug1023120-schemaImport into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp