> I am going to approve, but it would be nice if you added an "iter" test to
> make sure that the optimization is applied and we won't loose it somehow in
> the future. To do so, you must first make PrinterVisitor print theNeedToCpy
> data member of the various ZorbaInsertNodesXXX iterators. This w
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.ne
I am going to approve, but it would be nice if you added an "iter" test to make
sure that the optimization is applied and we won't loose it somehow in the
future. To do so, you must first make PrinterVisitor print theNeedToCpy data
member of the various ZorbaInsertNodesXXX iterators. This will p
There are additional revisions which have not been approved in review. Please
seek review and approval of these new revisions.
--
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https:/
> Why is the processPragma method defined only for
> static_collections_dml_apply_insert_nodes_last. Should it be defined for the
> other collection-insert functions as well?
>
> ChangeLog needs updating
>
> Tiny optimization: if you want to erase the last N entries in a vector, you
> can just us
Why is the processPragma method defined only for
static_collections_dml_apply_insert_nodes_last. Should it be defined for the
other collection-insert functions as well?
ChangeLog needs updating
Tiny optimization: if you want to erase the last N entries in a vector, you can
just use resize(). T
Review: Needs Fixing
--
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchp
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 1 Approve, 2 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing li
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 1 Approve, 2 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing li
The attempt to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into
lp:zorba failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job feature-pragma_no_copy-2012-09-12T17-51-55.158Z is
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 1 Approve, 2 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing li
There are additional revisions which have not been approved in review. Please
seek review and approval of these new revisions.
--
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https:/
The attempt to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into
lp:zorba failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job feature-pragma_no_copy-2012-06-29T21-33-59.318Z is
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.ne
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https:/
15 matches
Mail list logo