Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-thesaurus-uriresolver into lp:zorba

2011-11-09 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-thesaurus-uriresolver/+merge/80979 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launch

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-thesaurus-uriresolver into lp:zorba

2011-11-09 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1. Got: 1 Approve. -- https://code.launchpad.net/~zorba-coders/zorba/feature-thesaurus-uriresolver/+merge/80979 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-cod

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-thesaurus-uriresolver into lp:zorba

2011-11-09 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-thesaurus-uriresolver/+merge/80979 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launch

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-thesaurus-uriresolver into lp:zorba

2011-11-09 Thread Matthias Brantner
Review: Needs Fixing > > - Is the error FTST0018 raised at compile time or runtime. > > Run-time. The spec says: "During the dynamic evaluation phase, only dynamic errors or type errors may be raised." Hence, FTST0018 should be raise during compile time. -- https://code.launchpad.net/~zorba-co

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-thesaurus-uriresolver into lp:zorba

2011-11-08 Thread Paul J. Lucas
> - Is the error FTST0018 raised at compile time or runtime. Run-time. > Also, the error doesn't seem to include a error location. The exception is caught farther up the call stack, the location is added, and the exception is re-thrown. -- https://code.launchpad.net/~zorba-coders/zorba/feature

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-thesaurus-uriresolver into lp:zorba

2011-11-08 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/feature-thesaurus-uriresolver into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/pilot/tester/TarmacLander.cmake:21 (message): Provide path to Zorba svn enlistment as ctest script arg Error in read script: /home/p

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-thesaurus-uriresolver into lp:zorba

2011-11-02 Thread Chris Hillery
> - QQQ doc for registerURIMapper and registerURLResolver That needs to be fixed, but it's not part of this change... > - I would have expected the ThesaurusURLResolver::resolveURL to be defined in > default_url_resolvers.cpp Speaking for Paul: He felt that it was better to keep the full-text

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-thesaurus-uriresolver into lp:zorba

2011-11-02 Thread Matthias Brantner
Review: Needs Information -- https://code.launchpad.net/~zorba-coders/zorba/feature-thesaurus-uriresolver/+merge/80979 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : http

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-thesaurus-uriresolver into lp:zorba

2011-11-02 Thread Matthias Brantner
- QQQ doc for registerURIMapper and registerURLResolver - I would have expected the ThesaurusURLResolver::resolveURL to be defined in default_url_resolvers.cpp - Why isn't the WordNet Thesaurus loaded using the file module (analog to all other file accesses) instead of the ZORBA_WITH_FILE_ACCES

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-thesaurus-uriresolver into lp:zorba

2011-11-02 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 10, Disapprove < 1. Got: 5 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/feature-thesaurus-uriresolver/+merge/80979 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-co

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-thesaurus-uriresolver into lp:zorba

2011-11-02 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 10, Disapprove < 1. Got: 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/feature-thesaurus-uriresolver/+merge/80979 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-co

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-thesaurus-uriresolver into lp:zorba

2011-11-02 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 10, Disapprove < 1. Got: 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/feature-thesaurus-uriresolver/+merge/80979 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-co

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-thesaurus-uriresolver into lp:zorba

2011-11-02 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1. Got: 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/feature-thesaurus-uriresolver/+merge/80979 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-cod

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-thesaurus-uriresolver into lp:zorba

2011-11-01 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/feature-thesaurus-uriresolver into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:272 (message): Validation queue job feature-thesaurus-uriresolver-2011-11-02T06-1

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-thesaurus-uriresolver into lp:zorba

2011-11-01 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: text conflict in src/system/globalenv.cpp -- https://code.launchpad.net/~zorba-coders/zorba/feature-thesaurus-uriresolver/+merge/80979 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-