Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/opt-count-index-probe into lp:zorba
Review: Approve The change looks good. Only 2 general comments: 1) func_sequences_impl.cpp It seems wasteful to first codegen the underlying probe iterators and then to re-create them here. It would be nice to parameterize the codeine on the way down - but I guess that there's no easy way of doing that … 2) index_dll.h/.cpp There is a lot of redundancy in the ProbeIndex Iterators. This is obviously independent of this merge proposal, but this merge proposal makes it very clear. -- https://code.launchpad.net/~zorba-coders/zorba/opt-count-index-probe/+merge/105528 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/opt-count-index-probe into lp:zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 1 Approve, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/opt-count-index-probe/+merge/105528 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/opt-count-index-probe into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/opt-count-index-probe/+merge/105528 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/opt-count-index-probe into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/opt-count-index-probe into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job opt-count-index-probe-2012-05-11T20-43-01.129Z is finished. The final status was: 40 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/opt-count-index-probe/+merge/105528 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp