Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-11-02 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/structuralrelationships2/+merge/81053 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-11-02 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/structuralrelationships2/+merge/81053 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-24 Thread Federico Cavalieri
Second, when you say that you rely on it, does it mean that you may need to compare 2 node positions that were obtained in different snapshots? And if so, do you expect that the result of such a comparison says anything about the positional relationship of the two corresponding nodes at any

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-20 Thread Federico Cavalieri
Connection dropped... Do you know why document nodes have a component less than any other kind of node when they are the root of their tree? I finally found out what you meant (the code is in the OrdPathNode ctor, not the OrdPath ctor). I think the reason why element node as root

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-19 Thread Markos Zaharioudakis
Connection dropped... Do you know why document nodes have a component less than any other kind of node when they are the root of their tree? I finally found out what you meant (the code is in the OrdPathNode ctor, not the OrdPath ctor). I think the reason why element node as root has an

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-19 Thread Markos Zaharioudakis
Federico, I think the documentation in node-position.xq needs some more work. I can do this, but first we must agree on what is exactly the functionality and the assumptions about node positions that you rely on. For example, in the documentation of the np:node-position() function, you write:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-17 Thread Markos Zaharioudakis
Hi Markos, i noticed that the parse uri function now uses strtoul without checking errno with the following effects: A missing component is considered 0: np:in-same-tree-of(xs:anyURI(zorba:..1.50),xs:anyURI(zorba:0.0.1.50)) -true Out of ulong value-space == ULONG_MAX

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-17 Thread Federico Cavalieri
Hi Markos, i noticed that the parse uri function now uses strtoul without checking errno with the following effects: A missing component is considered 0: np:in-same-tree-of(xs:anyURI(zorba:..1.50),xs:anyURI(zorba:0.0.1.50)) -true Out of ulong value-space == ULONG_MAX

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-14 Thread Markos Zaharioudakis
Federico, I don't think it is necessary to put the position uris into the uri pool because they are not likely to be shared by multiple data items so you won't really be saving much space (you may be actually end-up wasting space because the uri pool storage has some overhead by itself). Do you

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-14 Thread Markos Zaharioudakis
Should StructuralAnyUriItem::isDescendant() check that the other node is not an attribute? -- https://code.launchpad.net/~zorba-coders/zorba/structuralrelationships2/+merge/78395 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-14 Thread Federico Cavalieri
Should StructuralAnyUriItem::isDescendant() check that the other node is not an attribute? Yes, you are right! Descendant doesn't include attributes. May I add a in-subtree-of function with the same semantics as the current descendant? Thanks Federico --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-14 Thread Federico Cavalieri
Federico, I don't think it is necessary to put the position uris into the uri pool because they are not likely to be shared by multiple data items so you won't really be saving much space (you may be actually end-up wasting space because the uri pool storage has some overhead by itself). Do

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-14 Thread Markos Zaharioudakis
Should StructuralAnyUriItem::isDescendant() check that the other node is not an attribute? Yes, you are right! Descendant doesn't include attributes. May I add a in-subtree-of function with the same semantics as the current descendant? Thanks Federico It's ok with me, if it is