Review: Approve
Confirmed that this fixes both outstanding Fedora bugs (tested on Fedora) as
well as the infinite-loop bug (tested on Ubuntu). Yay!
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/144007
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
I've fixed the RQ problem that caused the JDBC and Oracle NoSQL failures.
However, the 4 XQXQ failures I don't understand yet.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/144007
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Think I've fixed it; trying again.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/144007
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Yeah, there were some weird failures in the RQ -- the JDBC ones and around 3
URI tests that did not fail on my machine.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/144007
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Approve, 1 Pending.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/144007
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The attempt to merge lp:~nbrinza/zorba/parse-fragment into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job parse-fragment-2013-01-20T14-06-13.72Z is finished.
The final
I can confirm that all parse and parse-xml-fragment tests pass on my Fedora
x64 bit machine.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/144007
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/144007
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The attempt to merge lp:~nbrinza/zorba/parse-fragment into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job parse-fragment-2013-01-20T01-35-16.016Z is finished.
The final
The attempt to merge lp:~nbrinza/zorba/parse-fragment into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job parse-fragment-2013-01-20T02-23-09.94Z is finished.
The final
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Pending.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/143519
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/143519
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/121884
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
Could you please add the changes to the ChangeLog?
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/117814
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Updated the Changelog. (And re-merged with the trunk, to make sure there are no
conflicts).
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/121884
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/121884
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Pending.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/115344
Your team Zorba Coders is requested to review the proposed merge of
Review: Needs Fixing
ChangeLog should mention the fix of bug
https://bugs.launchpad.net/zorba/+bug/1016606. In fact, the patch fixes a bug
and is not a new feature. ;-)
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/115344
Your team Zorba Coders is subscribed to branch
Actually it is a new feature, as the XML spec does not allow for DOCTYPE
declarations in external parsed entities, and the implementation in the trunk
is conformant to the spec. The bug merely registers the request from the user.
I've mentioned the change in both sections of the Changelog, just
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/115377
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Approve.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/115377
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/115377
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The attempt to merge lp:~nbrinza/zorba/parse-fragment into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job parse-fragment-2012-05-16T14-32-13.325Z is finished.
The final
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/106000
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/106000
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/105841
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/105387
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/105387
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The attempt to merge lp:~nbrinza/zorba/parse-fragment into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job parse-fragment-2012-05-10T20-43-02.464Z is finished.
The final
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/103624
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Approve.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/103624
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Approve.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/103624
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Approve.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/103624
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/103624
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/103453
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Approve, 2 Pending.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/97701
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/97701
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 2 Approve, 1 Pending.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/97701
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 2 Approve, 1 Pending.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/97701
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
I have fixed the failing test, which apparently fails only in the Release build.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/97292
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
There are additional revisions which have not been approved in review. Please
seek review and approval of these new revisions.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/97292
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/97681
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/97681
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
It seems the remote queue is stuck again, probably because I have approved it
before anyone else. I'll resubmit.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/97681
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/97701
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/97292
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Attempt to merge into lp:zorba failed due to conflicts:
text conflict in ChangeLog
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/97292
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
The attempt to merge lp:~nbrinza/zorba/parse-fragment into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job parse-fragment-2012-03-14T15-37-11.771Z is finished.
The final
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/97292
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/97251
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/97251
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
I have fixed the formatting of the code examples.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/97251
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
I have merged Matthias' example and added another one. Resubmitting.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/96380
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
I have added the backwards-compatible parse-xml:parse-xml-fragment() function
and now the link crawler test passes ok. Resubmitting for mergeing into the
trunk.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/95152
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Review: Needs Fixing
I won't pass the remote queue because not all of the parameters of the old
functions are documented.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/96380
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Approve
Which parameters of the old functions are not documented?
Sorry, I got confused by the diff. Everything seems to be fine.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/96380
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Needs Fixing
The module works nicely but the documentation needs more example:
- In the introduction
- For each function
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/96380
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/95152
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
I have fixed the regressions and the conflicts. Resubmitting.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/94419
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/95150
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/95152
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/95152
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The attempt to merge lp:~nbrinza/zorba/parse-fragment into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job parse-fragment-2012-02-29T15-41-14.921Z is finished.
The final
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/94419
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
I've fixed the conflict in the Changelog. Resubmitting for merging into the
trunk.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/91657
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/94419
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/94419
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The attempt to merge lp:~nbrinza/zorba/parse-fragment into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job parse-fragment-2012-02-23T17-50-09.456Z is finished.
The final
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/91657
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Adding David to the review, I think he found a bug.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/91657
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
I tried it and it looks like just the best.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/91657
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
All pending issues have been fixed. Resubmitting the proposal for merging.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/89038
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Approve
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/89038
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The Elsevier copyright came from the xqdoc.xsd, which I think I used as a base
for the options file. I fixed it together with the other issues Matthias has
raised. I've also fixed a couple of other cases where malformed XMLs where
handled incorrectly. Resubmitting for merging.
--
Would xmldoc be a good prefix?
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/89038
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
It certainly is the closest allowed alternative...
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/89038
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
It seems to be a problem with the diff:
- bool isLangAttr(const store::Item_t aAttr) const;
- bool matchesReqLang(const store::Item_t aLangAttr, const zstring
aRequestLang) const;
+ bool isLangAttr(const store::Item_t#38; aAttr) const;
+ bool matchesReqLang(const
Yes, indeed, this is a strange corruption that I sometimes get after a merge.
I've fixed the issue, resubmitting.
--
https://code.launchpad.net/~nbrinza/zorba/parse-fragment/+merge/88238
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Needs Information
Also, the branch doesn't build without schema support (i.e.
ZORBA_NO_XMLSCHEMA:BOOL=ON)
[ 1%] Building CXX object
src/CMakeFiles/zorba_simplestore.dir/runtime/parsing_and_serializing/parse_fragment_impl.cpp.o
79 matches
Mail list logo