Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1176038 into lp:zorba

2013-05-08 Thread Paul J. Lucas
Review: Needs Fixing


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1176038/+merge/162953
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1176038 into lp:zorba

2013-05-08 Thread Nicolae Brinza
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1176038/+merge/162996
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1176038 into lp:zorba

2013-05-08 Thread Paul J. Lucas
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1176038/+merge/162996
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1176038 into lp:zorba

2013-05-08 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, 
Needs Fixing < 1, Pending < 1, Needs Information < 1, Resubmit < 1. Got: 1 
Approve, 1 Needs Fixing.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1176038/+merge/162953
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1176038 into lp:zorba

2013-05-08 Thread Paul J. Lucas
Review: Approve

Approved for now, warnings and all. A separate bug could be opened to address 
the warnings.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1176038/+merge/162953
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1176038 into lp:zorba

2013-05-08 Thread Nicolae Brinza
The 2.5.35 version is that of flex. Your flex is 2.5.35 as well, but again it 
seems to be a customized Apple branch -- "flex 2.5.35 Apple(flex-31)". 
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1176038/+merge/162953
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1176038 into lp:zorba

2013-05-08 Thread Nicolae Brinza
I have the 2.7 bison and the 2.5.35 which are the same as you have and yet I do 
not get the warnings. I do have a different gcc -- 4.7, but I'm not really sure 
how to downgrade it to 4.2 which is what you have -- "gcc version 4.2.1 (Based 
on Apple Inc. build 5658) (LLVM build 2336.11.00)". And that seems to be a 
customized Mac gcc anyway. It is really weird they've bothered to update their 
Bison to 2.7 when no one else did, yet they're stuck with a 6-years old GCC. 

I did not say you should fix them, I asked if you could. That's because you're 
the only one getting them. The locations are correct relative to the generated 
.l files (e.g. build/src/compiler/parser/jsoniq_scanner.l). It is not difficult 
to trace back the line in the scanner.l file. 
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1176038/+merge/162953
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1176038 into lp:zorba

2013-05-08 Thread Paul J. Lucas
You probably don't get the warnings because the RQ isn't running the same 
version(s) of flex/bison/g++.

I don't recall all those warnings being there before, so it's not clear to me 
why I should be the one to take my time to fix them.  It's also not easy 
because the line numbers given in the warnings are wrong.  They're probably 
wrong because of the way in which the scanner is built.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1176038/+merge/162953
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1176038 into lp:zorba

2013-05-08 Thread Nicolae Brinza
I get absolutely no warnings whatsoever in the scanner, and neither does the 
remote queue, e.g. 
http://zorbatest.lambda.nu:8080/remotequeue/bug-1176038-2013-05-08T11-41-52.814Z/ctest.txt
 . If you get them with your compiler, can't you fix them?
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1176038/+merge/162953
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1176038 into lp:zorba

2013-05-08 Thread Paul J. Lucas
Review: Needs Fixing

There are many, many warnings like:

/Users/pjl/src/flwor/zorba/repo/bug-1176038/zorba/build/src/compiler/parser/jsoniq_scanner.l:513:1:
 warning: comparison between signed and unsigned integer expressions 
[-Wsign-compare]
/Users/pjl/src/flwor/zorba/repo/bug-1176038/zorba/build/src/compiler/parser/xquery_scanner.l:659:1:
 warning: comparison between signed and unsigned integer expressions 
[-Wsign-compare]
/Users/pjl/src/flwor/zorba/repo/bug-1176038/zorba/build/src/compiler/parser/jsoniq_scanner.l:514:1:
 warning: comparison between signed and unsigned integer expressions 
[-Wsign-compare]
/Users/pjl/src/flwor/zorba/repo/bug-1176038/zorba/build/src/compiler/parser/xquery_scanner.l:659:1:
 warning: comparison between signed and unsigned integer expressions 
[-Wsign-compare]
/Users/pjl/src/flwor/zorba/repo/bug-1176038/zorba/build/src/compiler/parser/xquery_scanner.l:661:1:
 warning: comparison between signed and unsigned integer expressions 
[-Wsign-compare]
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1176038/+merge/162953
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1176038 into lp:zorba

2013-05-08 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, 
Needs Fixing < 1, Pending < 1, Needs Information < 1, Resubmit < 1. Got: 1 
Approve, 1 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1176038/+merge/162953
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1176038 into lp:zorba

2013-05-08 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/bug-1176038 into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job bug-1176038-2013-05-08T10-59-08.787Z is finished.  The
  final status was:

  

  1 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1176038/+merge/162953
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1176038 into lp:zorba

2013-05-08 Thread Nicolae Brinza
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1176038/+merge/162953
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp