Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba
Not doable with Swig 1.x Only Swig 2.x apply -- https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba
I was able to fix the SWIG problems, I'm still having issues with UTF conversion. -- https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba
on jaStream definition you may have this line: jstring jaStream ; this error is generated by swig, I have the same error on my Linux Box, but I realize that I'm using SWIG 1.3, this version may have this bug. -- https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba
Review: Approve Thanks! -- https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug938320 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job bug938320-2012-08-31T20-26-56.205Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba
I fixed the first compilation problem; in three places there was code like this: std::istream stream = std::istream(streamBuffer); which is illegal (at least according to gcc) because it implicitly uses a private copy-constructor on ios_base. Changing it to this: std::istream stream(streamBuffer); fixed the compilation error and is slightly more efficient anyway. I have committed this change. The next compilation error involved the class org.zorbaxquery.api.intArray. As far as I could make out this class wasn't actually used anyway, so I removed the import from java/ZorbaInputWrapper.java and the %array_class() declaration in zorba_api.i. I did not commit these changes, though, because I wasn't sure they were good. However, even with that the branch still doesn't build. On the RQ machine I get /home/ceej/zo/testing/zorbatest/tester/remotequeue/bug938320-2012-08-31T20-26-56.205Z/bzr/zorba/build/swig/java/zorba_apiJAVA_wrap.cxx: In member function ‘virtual void SwigDirector_ZorbaIOStream::write(const char*, size_t)’: /home/ceej/zo/testing/zorbatest/tester/remotequeue/bug938320-2012-08-31T20-26-56.205Z/bzr/zorba/build/swig/java/zorba_apiJAVA_wrap.cxx:2440: error: cannot convert ‘_jbyteArray*’ to ‘_jstring*’ in assignment On my own machine, I don't get that, but it is failing when trying to compile the .java files for zorba_xqj.jar - it can't find the symbols for classes like XQuery, DynamicContext, and others. I haven't previously tried compiling the swig stuff on my machine so it's possible I'm missing some dependency there, but for now I can't debug any further. -- https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba
The changes look OK to me, but the branch doesn't compile on my machine (DynamicContextImpl is pure abstract, but xqueryimpl.cpp line 1016 tries to instantiate one). I'm kicking off the queue to see if the same problem occurs there. -- https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba
Review: Needs Fixing However, there are two things to fix regardless: 1. A number of files have been committed with Windows newlines - all the new .h, .i, and .java files under swig/, I believe. You need to have the appropriate rules file in your Bazaar home directory, as described in the working_with_launchpad page of the Wiki, in order for bzr to add files correctly. Now that they are committed on your branch, I'm not sure how to fix it, though... if you can't figure out a way, then I can re-commit them correctly from here, which will just be a bit wasteful. 2. Doc comment problem: You have @stream twice, instead of @param stream. -- https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug938320 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job bug938320-2012-08-30T08-33-45.881Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba
Yep, same compilation error: [ 42%] Building CXX object src/CMakeFiles/zorba_simplestore.dir/api/dynamiccontextimpl.cpp.o ../../src/api/xqueryimpl.cpp: In member function 'virtual zorba::DynamicContext* zorba::XQueryImpl::getDynamicContext() const': ../../src/api/xqueryimpl.cpp:1040: error: cannot allocate an object of abstract type 'zorba::DynamicContextImpl' ../../src/api/dynamiccontextimpl.h:54: note: because the following virtual functions are pure within 'zorba::DynamicContextImpl': ../../include/zorba/dynamic_context.h:286: note:virtual bool zorba::DynamicContext::getContextSize(zorba::Item) const ../../include/zorba/dynamic_context.h:289: note:virtual bool zorba::DynamicContext::getContextPosition(zorba::Item) const -- https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba
Review: Needs Fixing
Isn't the following method wrong? You need to check that the strings are the
same not just a subset one of another. Just say:
return (test == null query.result == null) || test.equals(queryRTesult);
2068+ static boolean checkResult(String test, String queryResult) {
2069+ System.out.println(Result:);
2070+ System.out.println(queryResult);
2071+ System.out.println(Expected:);
2072+ System.out.println(test);
2073+ return (queryResult.indexOf(test)=0) ||
(test.indexOf(queryResult)=0);
2074+ }
--
https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba
@Chris ZorbaIOStream is the base class that should be used in other languages to stream to/from Zorba, it works as a wrapper for other language stream classes, for example, in Java this class becomes: ZorbaInputWrapper to manage InputStream Objects ZorbaOutputWrapper to manage OutputStream Objects ZorbaReaderWrapper to manage Reader Objects ZorbaWriterWrapper to manage Writer Objects The documentation is now correct. @Cezar Changes completed, now is strict result comparison. Note: these changes also showed a bug on XQJ's serialization. -- https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba
Ah, ok, I get it. Thanks for the explanation. I'll review the rest of the code soon. -- https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba
Review: Needs Information General question: Is there a reason you created ZorbaIOStream rather than using normal C++ iostreams? It seems like re-inventing the wheel, and it also makes it harder to use this feature with streams from other sources. Also, comments in swig/Item.h are inaccurate - a. Both functions say returns a string, but they are void b. Second function also has a @return note I'll withhold further comments until hearing about using iostreams, though... -- https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
