Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-07-09 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/113650 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-07-05 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/113650 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-06-08 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/109457 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-06-08 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/109457 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-18 Thread Matthias Brantner
Review: Approve The comment is wrong: #endif /* __GNUC__ */ -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/106480 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-18 Thread Paul J. Lucas
Until it's actually needed in more than one place, I don't see the point. -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/106480 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lis

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-18 Thread Matthias Brantner
Review: Needs Information Why not put the definition of the preprocessor variable into a common place such as zorba/include/zorba/config.h.cmake? This file already contains similar definitions. -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/106480 Your team Zorba Cod

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-18 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/106480 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-17 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/106235 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-17 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/feature-ft_module into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job feature-ft_module-2012-05-17T21-57-06.963Z is finished.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-17 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/106235 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-16 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/105914 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-15 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/105914 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-15 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/105913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-11 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/105506 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-11 Thread Paul J. Lucas
It doesn't. The '-' is part of the line, not the diff. -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/105506 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net U

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-11 Thread Matthias Brantner
Review: Needs Information Why does the commit remove references to the stemmer, thesaurus, and tokenizer documentation? -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/105506 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-11 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/105506 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-10 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/feature-ft_module into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job feature-ft_module-2012-05-11T02-08-17.708Z is finished.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-10 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/105421 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-10 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/105421 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-09 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/105276 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-09 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/105276 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-07 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/105023 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-07 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/105023 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-07 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/104841 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-06 Thread Matthias Brantner
> OK, so write the code that constructs the nodes with the right type > information. Not for 2.5. Doing this is a source of too many errors. -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/104841 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-06 Thread Paul J. Lucas
OK, so write the code that constructs the nodes with the right type information. -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/104841 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-cod

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-06 Thread Matthias Brantner
> I don't understand why the result doesn't have to be validated. Isn't that > what Dana requires? Simply because validation is too expensive. It takes about 45% of the time and that's not worth it. If we want it to be typed, we could already construct the nodes to have the right type information

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-06 Thread Paul J. Lucas
I don't understand why the result doesn't have to be validated. Isn't that what Dana requires? -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/104841 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-05 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/104841 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-05 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/104841 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://laun

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-05 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/feature-ft_module into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job feature-ft_module-2012-05-05T14-18-05.028Z is finished.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-05-05 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/104830 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-04-27 Thread Chris Hillery
Review: Approve I have reviewed the thesuarus-URI code and made a couple minor changes. I also fixed the ZORBA_NO_FULL_TEXT build. -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/103953 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https:/

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-04-27 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/103953 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-04-27 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/feature-ft_module into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job feature-ft_module-2012-04-27T15-39-39.923Z is finished.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-04-27 Thread Markos Zaharioudakis
Review: Approve I think Chris should be a reviewer too as there is a lot of URI-resolution stuff here, and the two of you have worked together on this. -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/103741 Your team Zorba Coders is subscribed to branch lp:zorba. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-04-26 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/feature-ft_module into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job feature-ft_module-2012-04-26T17-42-44.771Z is finished.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-04-26 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/feature-ft_module into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job feature-ft_module-2012-04-26T13-44-25.114Z is finished.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-04-26 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/feature-ft_module into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job feature-ft_module-2012-04-26T13-32-05.014Z is finished.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-04-24 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/feature-ft_module into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job feature-ft_module-2012-04-25T02-04-01.152Z is finished.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-04-24 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/103401 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://laun

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-04-24 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/feature-ft_module into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job feature-ft_module-2012-04-25T01-24-19.624Z is finished.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-04-24 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/103378 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://laun

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-04-24 Thread Paul J. Lucas
I diff'd the output times between the trunk and this branch and nothing jumps out at being significantly longer. (Some tests actually run in less time.) My latest running of the test suite on my machine took 69 minutes. -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-04-22 Thread Chris Hillery
Other branches have been ok on the RQ machine with a 40-minute timeout. Why does this branch take so much longer? If it added a great many slow tests then that's probably ok, but if something is causing everything to go slower than that's a problem. Maybe ask on zorba-dev if it would be possible to

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-04-22 Thread Paul J. Lucas
On Apr 21, 2012, at 10:44 PM, Chris Hillery wrote: > What seems to be happening with the queue is that the build/test is timing > out after 40 minutes, which unfortunately doesn't log appropriately. I have > increased the timeout to 60 minutes and we'll see if it runs. But before this > gets me

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-04-21 Thread Chris Hillery
What seems to be happening with the queue is that the build/test is timing out after 40 minutes, which unfortunately doesn't log appropriately. I have increased the timeout to 60 minutes and we'll see if it runs. But before this gets merged, we should look and see if we can figure out why it's t

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-04-21 Thread Paul J. Lucas
The Remote Queue seems to have gotten itself into an infinite loop. I've notified Chris. PLEASE DO NOT SET THE PROPOSAL TO "APPROVED" TO START THE REMOTE QUEUE UNTIL THIS IS FIXED. @Matthias: The "theSerStream" change was do fix a crash in the module. No, I don't remember why it's fixed in t

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-ft_module into lp:zorba

2012-04-20 Thread Matthias Brantner
Review: Needs Information What's the change in modules/com/zorba-xquery/www/modules/http-client.xq.src/http_request_handler.cpp supposed to do? Isn't this introducing a memory leak? -- https://code.launchpad.net/~zorba-coders/zorba/feature-ft_module/+merge/102949 Your team Zorba Coders is subsc