Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-12 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-12 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 1 Approve. -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launch

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-12 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-12 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launch

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-12 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-12 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job fix_bug_1086398-2013-03-12T14-03-44.003Z is finished. The

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-12 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-12 Thread Sorin Marian Nasoi
> 1. Unless I'm missing something, we don't want the function util:replace- > entity-references(). The result of calling fn:serialize() should be exactly > the XML we wish to canonicalize; if it contains < and > then there's a > problem. It's because in FOTS it's stated that we should use XML seria

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-12 Thread Chris Hillery
Review: Needs Fixing 1. Unless I'm missing something, we don't want the function util:replace-entity-references(). The result of calling fn:serialize() should be exactly the XML we wish to canonicalize; if it contains < and > then there's a problem. 2. I also don't like the $actualResult1 / $a

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-11 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-11 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job fix_bug_1086398-2013-03-11T22-03-38.682Z is finished. The

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-11 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152760 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-11 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job fix_bug_1086398-2013-03-11T21-55-35.204Z is finished. The

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-11 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job fix_bug_1086398-2013-03-11T21-47-47.406Z is finished. The

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-11 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152760 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-11 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job fix_bug_1086398-2013-03-11T21-15-38.589Z is finished. The

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-11 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152760 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-11 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152760 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launch

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-11 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job fix_bug_1086398-2013-03-11T20-16-43.938Z is finished. The

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba

2013-03-11 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152760 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb