It's strange that a few tests where failing because pdfbox was trying to use
lob4j. The website clearly says it depends on commons-logging which can use
log4j if available but fall down to java's default logging api.
I added explicit checks for jempbox and commons-lib to read-pdf module. And
Attempt to merge into lp:zorba failed due to conflicts:
text conflict in ChangeLog
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/126568
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/126743
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
Fixed fonts on build box and changed tests to be machine independent.
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/126743
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/126743
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Attempt to merge into lp:zorba failed due to conflicts:
text conflict in modules/ExternalModules.conf
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/126743
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Review: Approve
Merged and solved conflict.
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/126822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Attempt to merge into lp:zorba failed due to conflicts:
text conflict in modules/ExternalModules.conf
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/126822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Review: Approve
Merged and solved conflict.
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/126823
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
Now with tag for read-pdf.
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/126824
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
I added texts for all functions.
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125858
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Attempt to merge into lp:zorba failed due to conflicts:
text conflict in ChangeLog
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125858
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/126568
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The attempt to merge lp:~zorba-coders/zorba/fread-pdf-trunk into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job fread-pdf-trunk-2012-09-26T23-05-52.544Z is finished.
The attempt to merge lp:~zorba-coders/zorba/fread-pdf-trunk into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job fread-pdf-trunk-2012-09-27T01-51-44.419Z is finished.
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125858
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 2 Approve, 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125858
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Cezar - The remote queue is still not finding the jars, although they are
installed correctly in /usr/share/java as requested. (This is also probably why
the experimental build isn't including the module.) The problem, I believe, is
that you are using FIND_FILE() to find them, and you only list
I have re-assigned my review request to Juan, since I will not be around much
longer to vote on this proposal.
Juan, all you need to review is the CMake stuff in the lp:zorba/read-pdf-module
branch, specifically to ensure that it uses FIND_ZORBA_JAR() appropriately.
Once Cezar makes that
The attempt to merge lp:~zorba-coders/zorba/fread-pdf-trunk into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job fread-pdf-trunk-2012-09-25T23-51-47.915Z is finished.
The read-pdf module was found and built with this latest RQ run.
However, it has no tests. I personally don't think that's acceptable, even for
a beta release.
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125858
Your team Zorba Coders is subscribed to branch
The attempt to merge lp:~zorba-coders/zorba/fread-pdf-trunk into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job fread-pdf-trunk-2012-09-26T04-11-47.786Z is finished.
See answers inline:
- the error seems to be too general, essentially it always raises
JAVA-EXCEPTION no matter what goes wrong (e.g. it the given input is not a
valid pdf)
I adapted the error msg to be more clear/specific.
- the java stack trace seems to be sent to standard error
Goes to std
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125858
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Approve, 2 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125858
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
It doesn't look like the fpdf.* files were added via bzr add -- were they
supposed to be?
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125338
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Paul,
If you're asking about my last commit msg, it is as it should be just one line
change, by deleting the tag name, it makes trunk use the latest HEAD version of
the module branch. The files in util-jvm were already reviewed and merged see
this merge:
Review: Needs Fixing
The module works pretty decent. I was able to extract text or generate images
for several pdfs without any problems.
There are some minor things that should be discussed and/or fixed:
- the error seems to be too general, essentially it always raises
JAVA-EXCEPTION no
Review: Needs Fixing
You changed the URIs of the test modules back to www.zorba-xquery.com, instead
of zorba-tests.28msec.us. That will cause test failures. Make sure you've
merged from the trunk recently.
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125338
Your
(Other than that the changes look fine)
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125338
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
You still haven't corrected the URIs of the test modules, though
(test/rbkt/modules/CMakeLists.txt).
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125338
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Review: Needs Fixing
Let me add the new module.
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125338
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
The ref to the new module is in, please review it too: lp:zorba/read-pdf-module
at
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-the-module .
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125338
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Back to zorba-tests.28msec.us in test/rbkt/modules/CMakeLists.txt and mention
in Changelog.
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125338
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to
Review: Approve
Great, thanks.
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125338
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Attempt to merge into lp:zorba failed due to conflicts:
text conflict in ChangeLog
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125338
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Needs Fixing
It looks nice (without being able to testing it ;-)
- The module should follow XQuery coding conventions. For example, no camel-case
but function and variable names using dashes.
- The read-pdf:renderToImages-internal function is not documented. This will
probably cause
I fixed all the comments with the exception of the optional occurrence
indicator for internal functions. I tested it with empty sequence and works
fine.
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125338
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Approve, 2 Needs Fixing.
--
https://code.launchpad.net/~zorba-coders/zorba/fread-pdf-trunk/+merge/125338
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
39 matches
Mail list logo
