Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/temp-csx-schema into lp:zorba

2012-04-26 Thread Markos Zaharioudakis 
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/temp-csx-schema into lp:zorba

2012-04-19 Thread Chris Hillery 
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/temp-csx-schema into lp:zorba

2012-04-19 Thread Matthias Brantner 
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/temp-csx-schema into lp:zorba

2012-04-18 Thread Chris Hillery 
IMHO, it's better on ItemFactory, although it doesn't really fit either place 
very well. Putting it on ItemFactory at least makes it clearer that it should 
be used while constructing a new tree, while you're making other ItemFactory 
calls. I'd be afraid that putting it on Item would make it seem like a 
general-purpose update method.
-- 
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/temp-csx-schema into lp:zorba

2012-04-18 Thread Matthias Brantner 
Review: Needs Information

Wouldn't it be better if the new functions in the ItemFactory (e.g. 
assignElementTypedValue) would be members of Item?
-- 
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/temp-csx-schema into lp:zorba

2012-04-18 Thread Chris Hillery 
I've cleaned this up a bit, and IMHO it's ready to merge.

Markos, I've added you as a reviewer since we discussed these changes in email 
a while ago (late February / early March, email subjects "Zorba public API 
problem" and "SchemaTypeCode"). At the time, you said that you thought the 
SchemaTypeCode enum should perhaps go into identtypes.h rather than 
store_consts.h. Do you still feel that way strongly enough that I should move 
it, and if so, what C++ namespace should it be in? I originally chose 
store_consts.h because the enum was zorba::store::SchemaTypeCode, and there 
were already other zorba::store::Xxx enums in store_consts.h.
-- 
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/temp-csx-schema into lp:zorba

2012-03-05 Thread Zorba Build Bot 
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, 
Needs Fixing < 1, Pending < 1. Got: 1 Needs Fixing, 1 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/temp-csx-schema into lp:zorba

2012-03-05 Thread Zorba Build Bot 
Attempt to merge into lp:zorba failed due to conflicts: 

text conflict in src/store/naive/atomic_items.h
-- 
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/temp-csx-schema into lp:zorba

2012-03-05 Thread Chris Hillery 
Review: Needs Fixing


-- 
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp