On Wed, 3 Oct 2001, Harry Putnam wrote: > One thing that would help would be to heavily comment all init > scripts. Maybe this isn't done because they change frequently or > maybe it is just assumed that any one paging thru them will be able > to follow the code easily, which is absolutely wrong in my opinion. >
It's not done because we're understaffed, and just haven't had time. We agree that it should be done, fwiw. > Admittedly I am a rank amateur script writer but I usually have 40 > percent or more comments in scripts that I expect to come back to at > some future date. And still sometimes have trouble seeing what I was > trying to do. I'm not going to pretend that our init scripts are readable but rank amatuer script writers. Many of them are complicated, but they should all be comprehensible. > > if [ -f /etc/sysconfig/i18n -a -z "$NOLOCALE" ] ; then > . /etc/sysconfig/i18n > if [ "$LANG" = "ja_JP.eucJP" -a "`/sbin/consoletype`" != "pty" ]; then > unset LANG > else > export LANG > fi > fi > > # Read in our configuration > [...] > > Note there is no clue whatever as to what the `if' clauses are doing. This is all really basic shell scripting. "man test" would make good reading some time, fwiw. Erik ------------------------------------------------------------------------------- | "Who is John Galt?" - Atlas Shrugged by Ayn Rand | | | | Linux Application Development -- http://people.redhat.com/johnsonm/lad | _______________________________________________ Seawolf-list mailing list [EMAIL PROTECTED] https://listman.redhat.com/mailman/listinfo/seawolf-list
